squareetlabs / LaravelAuthorizeNet

src/Services/PaymentProfileService.php

<?php

namespace Squareetlabs\AuthorizeNet\Services;

use Squareetlabs\AuthorizeNet\AuthorizeNet;
use Squareetlabs\AuthorizeNet\Models\UserPaymentProfile;
use net\authorize\api\contract\v1 as AnetAPI;
use net\authorize\api\controller as AnetControllers;

class PaymentProfileService extends AuthorizeNet
{
    /**
     * Create a payment profile for the user.
     *
     * @param array<string, string> $opaqueData
     * @param array<string, mixed> $source
     * @return AnetAPI\CreateCustomerPaymentProfileResponse
     */
    public function create(array $opaqueData, array $source): AnetAPI\CreateCustomerPaymentProfileResponse
    {
        $merchantKeys = $this->getMerchantAuthentication();

        $opaqueDataType = new AnetAPI\OpaqueDataType();
        $opaqueDataType->setDataDescriptor($opaqueData['dataDescriptor']);
        $opaqueDataType->setDataValue($opaqueData['dataValue']);

        $paymentType = new AnetAPI\PaymentType();
        $paymentType->setOpaqueData($opaqueDataType);

        $customerPaymentProfileType = new AnetAPI\CustomerPaymentProfileType();
        $customerPaymentProfileType->setPayment($paymentType);

        $paymentProfileRequest = new AnetAPI\CreateCustomerPaymentProfileRequest();
        $paymentProfileRequest->setMerchantAuthentication($merchantKeys);
        $paymentProfileRequest->setCustomerProfileId($this->user->anet()->getCustomerProfileId());

It seems like $this->user->anet()->getCustomerProfileId() can also be of type Illuminate\Database\Eloquent\Builder and Illuminate\Database\Eloquent\PendingHasThroughRelationship; however, parameter $customerProfileId of net\authorize\api\contract\v1\CreateCustomerPaymentProfileRequest::setCustomerProfileId() does only seem to accept string, maybe add an additional type check?

The method anet() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

        $paymentProfileRequest->setPaymentProfile($customerPaymentProfileType);

        $controller = new AnetControllers\CreateCustomerPaymentProfileController($paymentProfileRequest);
        $response = $this->execute($controller);

        if ($response->getCustomerPaymentProfileId() !== null) {
            $this->storeInDatabase($response, $source);
        }

        return $response;
    }

    /**
     * Store payment profile in the database.
     *
     * @param AnetAPI\CreateCustomerPaymentProfileResponse $response
     * @param array<string, mixed> $source
     * @return UserPaymentProfile
     */
    protected function storeInDatabase(AnetAPI\CreateCustomerPaymentProfileResponse $response, array $source): UserPaymentProfile
    {
        return UserPaymentProfile::create([

The expression return Squareetlabs\AuthorizeNet\Models\UserPaymentProfile::create(array('user_id' => $this->user->id, 'payment_profile_id' => $response->getCustomerPaymentProfileId(), 'last_4' => $source['last_4'] ?? '', 'brand' => $source['brand'] ?? '', 'type' => $source['type'] ?? 'card')) could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Squareetlabs\AuthorizeNet\Models\UserPaymentProfile. Consider adding an additional type-check to rule them out.

            'user_id' => $this->user->id,
            'payment_profile_id' => $response->getCustomerPaymentProfileId(),
            'last_4' => $source['last_4'] ?? '',
            'brand' => $source['brand'] ?? '',
            'type' => $source['type'] ?? 'card',
        ]);
    }




}