squareetlabs / LaravelAuthorizeNet

src/Services/CustomerProfileService.php

<?php

namespace Squareetlabs\AuthorizeNet\Services;

use Squareetlabs\AuthorizeNet\AuthorizeNet;
use Squareetlabs\AuthorizeNet\Models\UserGatewayProfile;
use Illuminate\Support\Facades\Log;
use net\authorize\api\contract\v1 as AnetAPI;
use net\authorize\api\controller as AnetController;

class CustomerProfileService extends AuthorizeNet
{
    /**
     * Create a customer profile on authorize.net.
     *
     * @return AnetAPI\CreateCustomerProfileResponse
     * @throws \Exception
     */
    public function create(): AnetAPI\CreateCustomerProfileResponse
    {
        $customerProfileDraft = $this->draftCustomerProfile();
        $request = $this->draftRequest($customerProfileDraft);
        $controller = new AnetController\CreateCustomerProfileController($request);

        $response = $this->execute($controller);
        $response = $this->handleCreateCustomerResponse($response);

        if (method_exists($response, 'getCustomerProfileId') && $response->getCustomerProfileId() !== null) {
            $this->persistInDatabase($response->getCustomerProfileId());
        }

        return $response;
    }

    /**
     * Handle the response from creating a customer profile.
     *
     * @param AnetAPI\CreateCustomerProfileResponse $response
     * @return AnetAPI\CreateCustomerProfileResponse
     * @throws \Exception
     */
    protected function handleCreateCustomerResponse(AnetAPI\CreateCustomerProfileResponse $response): AnetAPI\CreateCustomerProfileResponse
    {
        if ($response->getCustomerProfileId() === null) {

The condition $response->getCustomerProfileId() === null is always false.

            $message = $response->getMessages()->getMessage()[0]->getText() ?? 'Unknown error';
            
            if (app()->environment() === 'local') {
                dd($message);
            }
            
            Log::debug('Failed to create customer profile: ' . $message);
            throw new \Exception('Failed to create customer profile.');
        }

        return $response;
    }

    /**
     * Persist customer profile ID in the database.
     *
     * @param string $customerProfileId
     * @return UserGatewayProfile
     */
    protected function persistInDatabase(string $customerProfileId): UserGatewayProfile
    {
        return UserGatewayProfile::create([

The expression return Squareetlabs\AuthorizeNet\Models\UserGatewayProfile::create(array('profile_id' => $customerProfileId, 'user_id' => $this->user->id)) could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Squareetlabs\AuthorizeNet\Models\UserGatewayProfile. Consider adding an additional type-check to rule them out.

            'profile_id' => $customerProfileId,
            'user_id' => $this->user->id,
        ]);
    }

    /**
     * Create a draft customer profile object.
     *
     * @return AnetAPI\CustomerProfileType
     */
    protected function draftCustomerProfile(): AnetAPI\CustomerProfileType
    {
        $customerProfile = new AnetAPI\CustomerProfileType();
        $customerProfile->setDescription('Customer Profile');
        $customerProfile->setMerchantCustomerId((string) $this->user->id);
        $customerProfile->setEmail($this->user->email ?? '');

It seems like $this->user->email ?? '' can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\PendingHasThroughRelationship&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $email of net\authorize\api\contract\v1\CustomerProfileBaseType::setEmail() does only seem to accept string, maybe add an additional type check?

        return $customerProfile;
    }

    /**
     * Create a draft request object.
     *
     * @param AnetAPI\CustomerProfileType $customerProfile
     * @return AnetAPI\CreateCustomerProfileRequest
     */
    protected function draftRequest(AnetAPI\CustomerProfileType $customerProfile): AnetAPI\CreateCustomerProfileRequest
    {
        $request = new AnetAPI\CreateCustomerProfileRequest();
        $request->setMerchantAuthentication($this->getMerchantAuthentication());
        $request->setRefId($this->getRefId());
        $request->setProfile($customerProfile);

        return $request;
    }



}