qtsass.events.SourceModificationEventHandler._recompile() - Code Metrics - Inspection of "PR: Reorganize package" - spyder-ide/qtsass - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#22)

unknown

created 2018-05-09 02:48 UTC

SourceModificationEventHandler._recompile() A

↳ Parent: qtsass.events

Complexity

Conditions

Size

Total Lines	10
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	10
nop	1
dl	0
loc	10
rs	9.2
c	0
b	0
f	0

# -*- coding: utf-8 -*-
# -----------------------------------------------------------------------------
# Copyright (c) 2015 Yann Lanthony
# Copyright (c) 2017-2018 Spyder Project Contributors
#
# Licensed under the terms of the MIT License
# (See LICENSE.txt for details)
# -----------------------------------------------------------------------------
"""Source files event handler."""

# Standard library imports
import os
import time

# Third party imports
from watchdog.events import FileSystemEventHandler


# py2 has no FileNotFoundError
try:
    FileNotFoundError
except NameError:
    FileNotFoundError = IOError



class SourceModificationEventHandler(FileSystemEventHandler):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    def __init__(self, input_file, dest_file, watched_dir, compiler):
        super(SourceModificationEventHandler, self).__init__()
        self._input_file = input_file
        self._dest_file = dest_file
        self._compiler = compiler
        self._watched_dir = watched_dir
        self._watched_extension = os.path.splitext(self._input_file)[1]

    def _recompile(self):
        i = 0
        success = False
        while i < 10 and not success:
            try:
                time.sleep(0.2)
                self._compiler(self._input_file, self._dest_file)
                success = True
            except FileNotFoundError:
                i += 1

    def on_modified(self, event):
        # On Mac, event will always be a directory.
        # On Windows, only recompile if event's file
        # has the same extension as the input file
        we_should_recompile = (

            event.is_directory and
            os.path.samefile(event.src_path, self._watched_dir) or
            os.path.splitext(event.src_path)[1] == self._watched_extension
        )
        if we_should_recompile:
            self._recompile()

    def on_created(self, event):
        if os.path.splitext(event.src_path)[1] == self._watched_extension:
            self._recompile()


1			# -- coding: utf-8 --
2			# -----------------------------------------------------------------------------
3			# Copyright (c) 2015 Yann Lanthony
4			# Copyright (c) 2017-2018 Spyder Project Contributors
5			#
6			# Licensed under the terms of the MIT License
7			# (See LICENSE.txt for details)
8			# -----------------------------------------------------------------------------
9			"""Source files event handler."""
10
11			# Standard library imports
12			import os
13			import time
14
15			# Third party imports
16			from watchdog.events import FileSystemEventHandler
17
18
19			# py2 has no FileNotFoundError
20			try:
21			FileNotFoundError
22			except NameError:
23			FileNotFoundError = IOError
			0 ignored issues – show Bug Best Practice introduced 2018-05-09 02:49 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `FileNotFoundError`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
24
25
26			class SourceModificationEventHandler(FileSystemEventHandler):
			0 ignored issues – show Coding Style introduced 2018-05-08 02:01 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-05-08 02:01 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
27
28			def __init__(self, input_file, dest_file, watched_dir, compiler):
29			super(SourceModificationEventHandler, self).__init__()
30			self._input_file = input_file
31			self._dest_file = dest_file
32			self._compiler = compiler
33			self._watched_dir = watched_dir
34			self._watched_extension = os.path.splitext(self._input_file)[1]
35
36			def _recompile(self):
37			i = 0
38			success = False
39			while i < 10 and not success:
40			try:
41			time.sleep(0.2)
42			self._compiler(self._input_file, self._dest_file)
43			success = True
44			except FileNotFoundError:
45			i += 1
46
47			def on_modified(self, event):
48			# On Mac, event will always be a directory.
49			# On Windows, only recompile if event's file
50			# has the same extension as the input file
51			we_should_recompile = (
			0 ignored issues – show Unused Code introduced 2018-05-08 02:01 UTC by Report Bug Copy Issue Report Consider using ternary (os.path.samefile(event.src_path, self._watched_dir) if event.is_directory else os.path.splitext(event.src_path)[1] == self._watched_extension) Loading history...
52			event.is_directory and
53			os.path.samefile(event.src_path, self._watched_dir) or
54			os.path.splitext(event.src_path)[1] == self._watched_extension
55			)
56			if we_should_recompile:
57			self._recompile()
58
59			def on_created(self, event):
60			if os.path.splitext(event.src_path)[1] == self._watched_extension:
61			self._recompile()
62

spyder-ide / qtsass

GitHub Access Token became invalid

Pull Request — master (#22)

SourceModificationEventHandler._recompile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like