spyder-ide /
qtpy
| Conditions | 21 |
| Total Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 6 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like test_patched_qcombobox() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | from __future__ import absolute_import |
||
| 22 | def test_patched_qcombobox(): |
||
| 23 | """ |
||
| 24 | In PySide, using Python objects as userData in QComboBox causes |
||
| 25 | Segmentation faults under certain conditions. Even in cases where it |
||
| 26 | doesn't, findData does not work correctly. Likewise, findData also |
||
| 27 | does not work correctly with Python objects when using PyQt4. On the |
||
| 28 | other hand, PyQt5 deals with this case correctly. We therefore patch |
||
| 29 | QComboBox when using PyQt4 and PySide to avoid issues. |
||
| 30 | """ |
||
| 31 | |||
| 32 | app = get_qapp() |
||
| 33 | |||
| 34 | data1 = Data() |
||
| 35 | data2 = Data() |
||
| 36 | data3 = Data() |
||
| 37 | data4 = Data() |
||
| 38 | data5 = Data() |
||
| 39 | data6 = Data() |
||
| 40 | |||
| 41 | icon1 = QtGui.QIcon() |
||
| 42 | icon2 = QtGui.QIcon() |
||
| 43 | |||
| 44 | widget = QtWidgets.QComboBox() |
||
| 45 | widget.addItem('a', data1) |
||
| 46 | widget.insertItem(0, 'b', data2) |
||
| 47 | widget.addItem('c', data1) |
||
| 48 | widget.setItemData(2, data3) |
||
| 49 | widget.addItem(icon1, 'd', data4) |
||
| 50 | widget.insertItem(3, icon2, 'e', data5) |
||
| 51 | widget.addItem(icon1, 'f') |
||
| 52 | widget.insertItem(5, icon2, 'g') |
||
| 53 | |||
| 54 | widget.show() |
||
| 55 | |||
| 56 | assert widget.findData(data1) == 1 |
||
| 57 | assert widget.findData(data2) == 0 |
||
| 58 | assert widget.findData(data3) == 2 |
||
| 59 | assert widget.findData(data4) == 4 |
||
| 60 | assert widget.findData(data5) == 3 |
||
| 61 | assert widget.findData(data6) == -1 |
||
| 62 | |||
| 63 | assert widget.itemData(0) == data2 |
||
| 64 | assert widget.itemData(1) == data1 |
||
| 65 | assert widget.itemData(2) == data3 |
||
| 66 | assert widget.itemData(3) == data5 |
||
| 67 | assert widget.itemData(4) == data4 |
||
| 68 | assert widget.itemData(5) is None |
||
| 69 | assert widget.itemData(6) is None |
||
| 70 | |||
| 71 | assert widget.itemText(0) == 'b' |
||
| 72 | assert widget.itemText(1) == 'a' |
||
| 73 | assert widget.itemText(2) == 'c' |
||
| 74 | assert widget.itemText(3) == 'e' |
||
| 75 | assert widget.itemText(4) == 'd' |
||
| 76 | assert widget.itemText(5) == 'g' |
||
| 77 | assert widget.itemText(6) == 'f' |
||
| 78 | |||
| 96 |
