spryker / spryker-core

Bundles/Payment/src/Spryker/Client/Payment/Dependency/Service/PaymentToUtilEncodingServiceBridge.php

<?php

/**
 * Copyright © 2016-present Spryker Systems GmbH. All rights reserved.
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace Spryker\Client\Payment\Dependency\Service;

class PaymentToUtilEncodingServiceBridge implements PaymentToUtilEncodingServiceInterface
{
    /**
     * @var \Spryker\Service\UtilEncoding\UtilEncodingServiceInterface
     */
    protected $utilEncodingService;

    /**
     * @param \Spryker\Service\UtilEncoding\UtilEncodingServiceInterface $utilEncodingService
     */
    public function __construct($utilEncodingService)
    {
        $this->utilEncodingService = $utilEncodingService;
    }

    /**
     * @param string $jsonValue
     * @param bool $assoc
     * @param int|null $depth
     * @param int|null $options
     *
     * @return array|null
     */
    public function decodeJson(string $jsonValue, bool $assoc = false, ?int $depth = null, ?int $options = null): ?array
    {
        if ($assoc === false) {
            trigger_error(
                'Param #2 `$assoc` must be `true` as return of type `object` is not accepted.',
                E_USER_DEPRECATED,
            );
        }

        return $this->utilEncodingService->decodeJson($jsonValue, $assoc, $depth, $options);

The expression return $this->utilEncodingService->decodeJson($jsonValue, $assoc, $depth, $options) could return the type object which is incompatible with the type-hinted return array|null. Consider adding an additional type-check to rule them out.

    }
}