spryker / spryker-core

Bundles/DataImport/src/Spryker/Zed/DataImport/Communication/Console/Executor/DataImportersDumpExecutor.php

<?php

/**
 * Copyright © 2016-present Spryker Systems GmbH. All rights reserved.
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace Spryker\Zed\DataImport\Communication\Console\Executor;

use Spryker\Zed\DataImport\Business\DataImportFacadeInterface;
use Spryker\Zed\DataImport\Communication\Console\Parser\DataImportConfigurationParserInterface;
use Spryker\Zed\DataImport\DataImportConfig;

class DataImportersDumpExecutor implements DataImportersDumpExecutorInterface
{
    /**
     * @var \Spryker\Zed\DataImport\Communication\Console\Parser\DataImportConfigurationParserInterface
     */
    protected $dataImportConfigurationParser;

    /**
     * @var \Spryker\Zed\DataImport\Business\DataImportFacadeInterface
     */
    protected $dataImportFacade;

    /**
     * @var \Spryker\Zed\DataImport\DataImportConfig
     */
    protected $dataImportConfig;

    /**
     * @param \Spryker\Zed\DataImport\Communication\Console\Parser\DataImportConfigurationParserInterface $dataImportConfigurationParser
     * @param \Spryker\Zed\DataImport\Business\DataImportFacadeInterface $dataImportFacade
     * @param \Spryker\Zed\DataImport\DataImportConfig $dataImportConfig
     */
    public function __construct(
        DataImportConfigurationParserInterface $dataImportConfigurationParser,
        DataImportFacadeInterface $dataImportFacade,
        DataImportConfig $dataImportConfig
    ) {
        $this->dataImportConfigurationParser = $dataImportConfigurationParser;
        $this->dataImportFacade = $dataImportFacade;
        $this->dataImportConfig = $dataImportConfig;
    }

    /**
     * @return array<string>
     */
    public function executeDataImportersDump(): array
    {
        $configPath = $this->dataImportConfig->getDefaultYamlConfigPath();

Are you sure the assignment to $configPath is correct as $this->dataImportConfig->getDefaultYamlConfigPath() targeting Spryker\Zed\DataImport\DataImportConfig::getDefaultYamlConfigPath() seems to always return null.

        $dataImportConfigurationTransfer = $this->dataImportConfigurationParser->parseConfigurationFile($configPath);

$configPath of type null is incompatible with the type string expected by parameter $filename of Spryker\Zed\DataImport\Communication\Console\Parser\DataImportConfigurationParserInterface::parseConfigurationFile().

        return $this->dataImportFacade->getImportersDumpByConfiguration($dataImportConfigurationTransfer);
    }
}