View GitHub Repository spryker-core

Schedule Inspection
Subscribe
Passed
Branch — master (7a7cfe)
by Fabian
45:14
created
Category
Toggle Patches
Specification/CollectorSpecification/CollectorOrSpecificationTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -69,7 +69,7 @@
 
 block discarded – undo
69 69 
     }
70 70
71 71 
     /**
72 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\QueryString\Specification\CollectorSpecification\CollectorSpecificationInterface
72 
+     * @return CollectorSpecificationInterface
73 73 
      */
74 74 
     protected function createCollectorSpecificationMock()
75 75 
     {
Please login to merge, or discard this patch.
Discount/Business/QueryString/Specification/DecisionRuleProviderTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -114,7 +114,7 @@  discard block
 
 block discarded – undo
114 114 
     }
115 115
116 116 
     /**
117 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Dependency\Plugin\DecisionRulePluginInterface
117 
+     * @return DecisionRulePluginInterface|null
118 118 
      */
119 119 
     protected function createDecisionRulePluginMock()
120 120 
     {
 
@@ -122,7 +122,7 @@  discard block
 
 block discarded – undo
122 122 
     }
123 123
124 124 
     /**
125 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\QueryString\Specification\DecisionRuleSpecification\DecisionRuleSpecificationInterface
125 
+     * @return DecisionRuleSpecificationInterface
126 126 
      */
127 127 
     protected function createDecisionRuleSpecificationMock()
128 128 
     {
Please login to merge, or discard this patch.
DecisionRuleSpecification/DecisionRuleAndSpecificationTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -84,7 +84,7 @@
 
 block discarded – undo
84 84 
     }
85 85
86 86 
     /**
87 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\QueryString\Specification\DecisionRuleSpecification\DecisionRuleSpecificationInterface
87 
+     * @return DecisionRuleSpecificationInterface
88 88 
      */
89 89 
     protected function createDecisionRuleSpecificationMock()
90 90 
     {
Please login to merge, or discard this patch.
Specification/DecisionRuleSpecification/DecisionRuleOrSpecificationTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -83,7 +83,7 @@
 
 block discarded – undo
83 83 
     }
84 84
85 85 
     /**
86 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\QueryString\Specification\DecisionRuleSpecification\DecisionRuleSpecificationInterface
86 
+     * @return DecisionRuleSpecificationInterface
87 87 
      */
88 88 
     protected function createDecisionRuleSpecificationMock()
89 89 
     {
Please login to merge, or discard this patch.
Zed/Discount/Business/QueryString/Specification/MetaProviderFactoryTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -84,7 +84,7 @@  discard block
 
 block discarded – undo
84 84 
     /**
85 85 
      * @param \Spryker\Zed\Discount\Business\DiscountBusinessFactory|null $discountBusinessFactoryMock
86 86 
      *
87 
-     * @return \Spryker\Zed\Discount\Business\QueryString\Specification\MetaProviderFactory
87 
+     * @return MetaProviderFactory
88 88 
      */
89 89 
     protected function createMetaProviderFactory(DiscountBusinessFactory $discountBusinessFactoryMock = null)
90 90 
     {
 
@@ -96,7 +96,7 @@  discard block
 
 block discarded – undo
96 96 
     }
97 97
98 98 
     /**
99 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\DiscountBusinessFactory
99 
+     * @return null|DiscountBusinessFactory
100 100 
      */
101 101 
     protected function createDiscountBusinessFactoryMock()
102 102 
     {
Please login to merge, or discard this patch.
SprykerTest/Zed/Discount/Business/QueryString/SpecificationBuilderTest.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -154,7 +154,7 @@  discard block
 
 block discarded – undo
154 154 
     }
155 155
156 156 
     /**
157 
-     * @return array
157 
+     * @return SkuDecisionRulePlugin[]
158 158 
      */
159 159 
     protected function createDecisionRulePlugins()
160 160 
     {
 
@@ -460,7 +460,7 @@  discard block
 
 block discarded – undo
460 460 
     }
461 461
462 462 
     /**
463 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\QueryString\ClauseValidatorInterface
463 
+     * @return ClauseValidatorInterface
464 464 
      */
465 465 
     protected function createClauseValidatorMock()
466 466 
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -159,7 +159,7 @@
 
 block discarded – undo
159 159 
     protected function createDecisionRulePlugins()
160 160 
     {
161 161 
         return [
162 
-           new SkuDecisionRulePlugin()
162 
+            new SkuDecisionRulePlugin()
163 163 
         ];
164 164 
     }
165 165
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -233,7 +233,7 @@  discard block
 
 block discarded – undo
233 233
234 234 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
235 235 
         $createComparatorOperatorsMock->method('isExistingComparator')
236 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
236 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
237 237 
                 return $clauseTransfer->getOperator() === '=' ? true : false;
238 238 
             });
239 239 
 
@@ -258,7 +258,7 @@  discard block
 
 block discarded – undo
258 258
259 259 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
260 260 
         $createComparatorOperatorsMock->method('isExistingComparator')
261 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
261 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
262 262 
                 return $clauseTransfer->getOperator() === '=' ? true : false;
263 263 
             });
264 264 
 
@@ -283,7 +283,7 @@  discard block
 
 block discarded – undo
283 283
284 284 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
285 285 
         $createComparatorOperatorsMock->method('isExistingComparator')
286 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
286 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
287 287 
                 return $clauseTransfer->getOperator() === '=' ? true : false;
288 288 
             });
289 289 
 
@@ -313,7 +313,7 @@  discard block
 
 block discarded – undo
313 313
314 314 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
315 315 
         $createComparatorOperatorsMock->method('isExistingComparator')
316 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
316 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
317 317 
                 if ($clauseTransfer->getOperator() === '=' || $clauseTransfer->getOperator() === 'is in') {
318 318 
                     return true;
319 319 
                 }
 
@@ -341,7 +341,7 @@  discard block
 
 block discarded – undo
341 341
342 342 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
343 343 
         $createComparatorOperatorsMock->method('isExistingComparator')
344 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
344 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
345 345 
                 if ($clauseTransfer->getOperator() === '=') {
346 346 
                     return true;
347 347 
                 }
 
@@ -366,7 +366,7 @@  discard block
 
 block discarded – undo
366 366
367 367 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
368 368 
         $createComparatorOperatorsMock->method('isExistingComparator')
369 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
369 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
370 370 
                 if ($clauseTransfer->getOperator() === '=') {
371 371 
                     return true;
372 372 
                 }
 
@@ -405,7 +405,7 @@  discard block
 
 block discarded – undo
405 405
406 406 
         $createComparatorOperatorsMock = $this->createComparatorOperatorsMock();
407 407 
         $createComparatorOperatorsMock->method('isExistingComparator')
408 
-            ->willReturnCallback(function (ClauseTransfer $clauseTransfer) {
408 
+            ->willReturnCallback(function(ClauseTransfer $clauseTransfer) {
409 409 
                 if ($clauseTransfer->getOperator() === '=') {
410 410 
                     return true;
411 411 
                 }
Please login to merge, or discard this patch.
tests/SprykerTest/Zed/Discount/Business/Voucher/VoucherCodeTest.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -239,7 +239,7 @@
 
 block discarded – undo
239 239 
     }
240 240
241 241 
     /**
242 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Persistence\DiscountQueryContainerInterface
242 
+     * @return null|DiscountQueryContainerInterface
243 243 
      */
244 244 
     protected function createDiscountQueryContainerMock()
245 245 
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -58,7 +58,7 @@
 
 block discarded – undo
58 58
59 59 
         $discountQueryContainerMock = $this->createDiscountQueryContainerMock();
60 60 
         $discountQueryContainerMock->method('queryVoucherPoolByVoucherCodes')
61 
-             ->willReturn($discountQueryMock);
61 
+                ->willReturn($discountQueryMock);
62 62
63 63 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
64 64 
         $updated = $voucherCode->useCodes(['123']);
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
64 64 
         $updated = $voucherCode->useCodes(['123']);
65 65
66 
-        $this->assertEquals(1,  $updated);
66 
+        $this->assertEquals(1, $updated);
67 67 
     }
68 68
69 69 
     /**
 
@@ -81,7 +81,7 @@  discard block
 
 block discarded – undo
81 81 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
82 82 
         $updated = $voucherCode->useCodes(['123']);
83 83
84 
-        $this->assertEquals(0,  $updated);
84 
+        $this->assertEquals(0, $updated);
85 85 
     }
86 86
87 87 
     /**
 
@@ -105,7 +105,7 @@  discard block
 
 block discarded – undo
105 105 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
106 106 
         $updated = $voucherCode->useCodes(['123']);
107 107
108 
-        $this->assertEquals(0,  $updated);
108 
+        $this->assertEquals(0, $updated);
109 109 
     }
110 110
111 111 
     /**
 
@@ -141,7 +141,7 @@  discard block
 
 block discarded – undo
141 141 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
142 142 
         $updated = $voucherCode->useCodes(['123']);
143 143
144 
-        $this->assertEquals(1,  $updated);
144 
+        $this->assertEquals(1, $updated);
145 145 
     }
146 146
147 147 
     /**
 
@@ -177,7 +177,7 @@  discard block
 
 block discarded – undo
177 177 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
178 178 
         $updated = $voucherCode->releaseUsedCodes(['123']);
179 179
180 
-        $this->assertEquals(1,  $updated);
180 
+        $this->assertEquals(1, $updated);
181 181 
     }
182 182
183 183 
     /**
 
@@ -195,7 +195,7 @@  discard block
 
 block discarded – undo
195 195 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
196 196 
         $updated = $voucherCode->releaseUsedCodes(['123']);
197 197
198 
-        $this->assertEquals(0,  $updated);
198 
+        $this->assertEquals(0, $updated);
199 199 
     }
200 200
201 201 
     /**
 
@@ -219,7 +219,7 @@  discard block
 
 block discarded – undo
219 219 
         $voucherCode = $this->createVoucherCode($discountQueryContainerMock);
220 220 
         $updated = $voucherCode->releaseUsedCodes(['123']);
221 221
222 
-        $this->assertEquals(0,  $updated);
222 
+        $this->assertEquals(0, $updated);
223 223 
     }
224 224
225 225 
     /**
Please login to merge, or discard this patch.
tests/SprykerTest/Zed/Discount/Business/Voucher/VoucherEngineTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -236,7 +236,7 @@
 
 block discarded – undo
236 236 
     }
237 237
238 238 
     /**
239 
-     * @param \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\DiscountConfig $discountConfigMock
239 
+     * @param DiscountConfig $discountConfigMock
240 240 
      *
241 241 
      * @return void
242 242 
      */
Please login to merge, or discard this patch.
tests/SprykerTest/Zed/Discount/Business/Voucher/VoucherValidatorTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -208,7 +208,7 @@
 
 block discarded – undo
208 208 
     /**
209 209 
      * @param \Orm\Zed\Discount\Persistence\SpyDiscountVoucher $discountVoucherEntity
210 210 
      *
211 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Persistence\DiscountQueryContainerInterface
211 
+     * @return null|DiscountQueryContainerInterface
212 212 
      */
213 213 
     protected function configureDiscountQueryContainerMock(SpyDiscountVoucher $discountVoucherEntity)
214 214 
     {
Please login to merge, or discard this patch.