Passed
Branch master (7a7cfe)
by Fabian
45:14
created
Discount/Business/QueryString/Specification/MetaData/MetaDataProvider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
     }
128 128
 
129 129
     /**
130
-     * @param \Spryker\Zed\Discount\Dependency\Plugin\DecisionRulePluginInterface|\Spryker\Zed\Discount\Dependency\Plugin\DiscountRuleWithAttributesPluginInterface $specificationPlugin
130
+     * @param DiscountRuleWithAttributesPluginInterface $specificationPlugin
131 131
      *
132 132
      * @return array
133 133
      */
Please login to merge, or discard this patch.
tests/SprykerTest/Zed/Discount/Business/Calculator/CalculatorTest.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
     }
229 229
 
230 230
     /**
231
-     * @return \Spryker\Zed\Discount\Dependency\Plugin\DecisionRulePluginInterface[]
231
+     * @return SkuDecisionRulePlugin[]
232 232
      */
233 233
     protected function createDecisionRulePlugins()
234 234
     {
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
     }
249 249
 
250 250
     /**
251
-     * @return \Spryker\Zed\Discount\Dependency\Plugin\CollectorPluginInterface[]
251
+     * @return ItemBySkuCollectorPlugin[]
252 252
      */
253 253
     protected function createCollectorPlugins()
254 254
     {
@@ -582,7 +582,7 @@  discard block
 block discarded – undo
582 582
     }
583 583
 
584 584
     /**
585
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Dependency\Plugin\DiscountCalculatorPluginInterface
585
+     * @return DiscountCalculatorPluginInterface|null
586 586
      */
587 587
     protected function createCalculatorPluginMock()
588 588
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@
 block discarded – undo
252 252
      */
253 253
     protected function createCollectorPlugins()
254 254
     {
255
-         $collectorProviderPlugins[] = new ItemBySkuCollectorPlugin();
255
+            $collectorProviderPlugins[] = new ItemBySkuCollectorPlugin();
256 256
 
257 257
         return $collectorProviderPlugins;
258 258
     }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
 
487 487
         $calculatorMock
488 488
             ->method('calculateDiscount')
489
-            ->willReturnCallback(function ($discountableItems, DiscountTransfer $discountTransfer) {
489
+            ->willReturnCallback(function($discountableItems, DiscountTransfer $discountTransfer) {
490 490
                 return $discountTransfer->getAmount();
491 491
             });
492 492
 
@@ -550,7 +550,7 @@  discard block
 block discarded – undo
550 550
             $calculatorPluginMock = $this->createCalculatorPluginMock();
551 551
             $calculatorPluginMock
552 552
                 ->method('calculateDiscount')
553
-                ->willReturnCallback(function ($discountableItems, DiscountTransfer $discountTransfer) {
553
+                ->willReturnCallback(function($discountableItems, DiscountTransfer $discountTransfer) {
554 554
                     return $discountTransfer->getAmount();
555 555
                 });
556 556
         }
Please login to merge, or discard this patch.
SprykerTest/Zed/Discount/Business/Collector/ItemQuantityCollectorTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
     /**
55 55
      * @param \Spryker\Zed\Discount\Business\QueryString\ComparatorOperatorsInterface|null $comparatorMock
56 56
      *
57
-     * @return \Spryker\Zed\Discount\Business\Collector\ItemPriceCollector
57
+     * @return ItemQuantityCollector
58 58
      */
59 59
     protected function createItemQuantityCollector(ComparatorOperatorsInterface $comparatorMock = null)
60 60
     {
Please login to merge, or discard this patch.
Zed/Discount/Business/DecisionRule/ItemQuantityDecisionRuleTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     /**
48 48
      * @param \Spryker\Zed\Discount\Business\QueryString\ComparatorOperatorsInterface|null $comparatorMock
49 49
      *
50
-     * @return \Spryker\Zed\Discount\Business\DecisionRule\ItemSkuDecisionRule
50
+     * @return ItemQuantityDecisionRule
51 51
      */
52 52
     protected function createItemQuantityDecisionRule(ComparatorOperatorsInterface $comparatorMock = null)
53 53
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     public function testDecisionRuleWhenCurrentItemQuantityMatchesShouldReturnTrue()
31 31
     {
32 32
         $comparatorMock = $this->createComparatorMock();
33
-        $comparatorMock->method('compare')->willReturnCallback(function (ClauseTransfer  $clauseTransfer, $itemQuantity) {
33
+        $comparatorMock->method('compare')->willReturnCallback(function(ClauseTransfer  $clauseTransfer, $itemQuantity) {
34 34
             return $clauseTransfer->getValue() === $itemQuantity;
35 35
         });
36 36
 
Please login to merge, or discard this patch.
Zed/Discount/Business/DecisionRule/TotalQuantityDecisionRuleTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     /**
54 54
      * @param \Spryker\Zed\Discount\Business\QueryString\ComparatorOperatorsInterface|null $comparatorMock
55 55
      *
56
-     * @return \Spryker\Zed\Discount\Business\DecisionRule\GrandTotalDecisionRule
56
+     * @return TotalQuantityDecisionRule
57 57
      */
58 58
     protected function createTotalQuantityDecisionRule(ComparatorOperatorsInterface $comparatorMock = null)
59 59
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     public function testWhenTotalQuantityMatchesClauseShouldReturnTrue()
31 31
     {
32 32
         $comparatorMock = $this->createComparatorMock();
33
-        $comparatorMock->method('compare')->willReturnCallback(function (ClauseTransfer  $clauseTransfer, $grandTotal) {
33
+        $comparatorMock->method('compare')->willReturnCallback(function(ClauseTransfer  $clauseTransfer, $grandTotal) {
34 34
             return $clauseTransfer->getValue() === $grandTotal;
35 35
         });
36 36
 
Please login to merge, or discard this patch.
tests/SprykerTest/Zed/Discount/Business/DiscountFacadeCalculateTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -362,7 +362,7 @@
 block discarded – undo
362 362
     }
363 363
 
364 364
     /**
365
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Dependency\Plugin\DiscountableItemFilterPluginInterface
365
+     * @return DiscountableItemFilterPluginInterface
366 366
      */
367 367
     protected function createDiscountableItemFilterPluginMock()
368 368
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
         $filterPluginMock
182 182
             ->expects($this->once())
183 183
             ->method('filter')
184
-            ->willReturnCallback(function (CollectedDiscountTransfer $collectedDiscountTransfer) {
184
+            ->willReturnCallback(function(CollectedDiscountTransfer $collectedDiscountTransfer) {
185 185
 
186 186
                 $discountableItems = new ArrayObject();
187 187
                 foreach ($collectedDiscountTransfer->getDiscountableItems() as $discountableItemTransfer) {
@@ -319,37 +319,37 @@  discard block
 block discarded – undo
319 319
 
320 320
         $container = new Container();
321 321
 
322
-        $container[DiscountDependencyProvider::PLUGIN_COLLECTOR_STRATEGY_PLUGINS] = function () use ($collectorStrategyPlugins) {
322
+        $container[DiscountDependencyProvider::PLUGIN_COLLECTOR_STRATEGY_PLUGINS] = function() use ($collectorStrategyPlugins) {
323 323
             return $collectorStrategyPlugins;
324 324
         };
325 325
 
326
-        $container[DiscountDependencyProvider::DECISION_RULE_PLUGINS] = function () use ($decisionRulePlugins) {
326
+        $container[DiscountDependencyProvider::DECISION_RULE_PLUGINS] = function() use ($decisionRulePlugins) {
327 327
             return $decisionRulePlugins;
328 328
         };
329 329
 
330
-        $container[DiscountDependencyProvider::FACADE_MESSENGER] = function () use ($messengerFacade) {
330
+        $container[DiscountDependencyProvider::FACADE_MESSENGER] = function() use ($messengerFacade) {
331 331
             return $messengerFacade;
332 332
         };
333 333
 
334
-        $container[DiscountDependencyProvider::COLLECTOR_PLUGINS] = function () use ($collectorPlugins) {
334
+        $container[DiscountDependencyProvider::COLLECTOR_PLUGINS] = function() use ($collectorPlugins) {
335 335
             return $collectorPlugins;
336 336
         };
337 337
 
338
-        $container[DiscountDependencyProvider::CALCULATOR_PLUGINS] = function () use ($calculatorPlugins) {
338
+        $container[DiscountDependencyProvider::CALCULATOR_PLUGINS] = function() use ($calculatorPlugins) {
339 339
             return $calculatorPlugins;
340 340
         };
341 341
 
342
-        $container[DiscountDependencyProvider::PLUGIN_DISCOUNTABLE_ITEM_FILTER] = function () use ($filterPluginMock) {
342
+        $container[DiscountDependencyProvider::PLUGIN_DISCOUNTABLE_ITEM_FILTER] = function() use ($filterPluginMock) {
343 343
             return [
344 344
                 $filterPluginMock
345 345
             ];
346 346
         };
347 347
 
348
-        $container[DiscountDependencyProvider::PLUGIN_DISCOUNT_APPLICABLE_FILTER_PLUGINS] = function () use ($applicableFilterPlugins) {
348
+        $container[DiscountDependencyProvider::PLUGIN_DISCOUNT_APPLICABLE_FILTER_PLUGINS] = function() use ($applicableFilterPlugins) {
349 349
             return $applicableFilterPlugins;
350 350
         };
351 351
 
352
-        $container[DiscountDependencyProvider::FACADE_CURRENCY] = function () use ($currencyFacade) {
352
+        $container[DiscountDependencyProvider::FACADE_CURRENCY] = function() use ($currencyFacade) {
353 353
             return $currencyFacade;
354 354
         };
355 355
 
Please login to merge, or discard this patch.
Discount/tests/SprykerTest/Zed/Discount/Business/DiscountFacadeTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -739,7 +739,7 @@
 block discarded – undo
739 739
     }
740 740
 
741 741
     /**
742
-     * @return \Generated\Shared\Transfer\DiscountConfiguratorTransfer
742
+     * @return string|null
743 743
      */
744 744
     protected function createDiscountConfiguratorTransfer()
745 745
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -780,7 +780,7 @@
 block discarded – undo
780 780
         $discountFacade = $this->createDiscountFacade();
781 781
         $factory = new DiscountBusinessFactory();
782 782
         $container = new Container();
783
-        $container[$dependencyType] = function () use ($discountRulePluginMock) {
783
+        $container[$dependencyType] = function() use ($discountRulePluginMock) {
784 784
             return [
785 785
                 $discountRulePluginMock,
786 786
             ];
Please login to merge, or discard this patch.
SprykerTest/Zed/Discount/Business/Persistence/DiscountOrderSaverTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -198,7 +198,7 @@
 block discarded – undo
198 198
     }
199 199
 
200 200
     /**
201
-     * @param array $discountSaverMethods
201
+     * @param string[] $discountSaverMethods
202 202
      * @param array $queryContainerMethods
203 203
      *
204 204
      * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\Persistence\DiscountOrderSaver
Please login to merge, or discard this patch.
Zed/Discount/Business/QueryString/Specification/CollectorProviderTest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
     }
114 114
 
115 115
     /**
116
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Dependency\Plugin\CollectorPluginInterface
116
+     * @return null|CollectorPluginInterface
117 117
      */
118 118
     protected function createCollectorPluginMock()
119 119
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     }
122 122
 
123 123
     /**
124
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\Discount\Business\QueryString\Specification\CollectorSpecification\CollectorSpecificationInterface
124
+     * @return CollectorSpecificationInterface
125 125
      */
126 126
     protected function createCollectorSpecificationMock()
127 127
     {
Please login to merge, or discard this patch.