View GitHub Repository spryker-core

Schedule Inspection
Subscribe
Passed
Branch — master (7a7cfe)
by Fabian
45:14
created
Category
Toggle Patches
ProductBundle/Availability/PreCheck/ProductBundleCartAvailabilityCheck.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
     }
68 68
69 69 
     /**
70 
-     * @param \ArrayObject|\Generated\Shared\Transfer\ItemTransfer[] $items
70 
+     * @param ArrayObject $items
71 71 
      * @param string $sku
72 72 
      *
73 73 
      * @return int
 
@@ -147,7 +147,7 @@  discard block
 
 block discarded – undo
147 147 
     }
148 148
149 149 
     /**
150 
-     * @param \ArrayObject|\Generated\Shared\Transfer\MessageTransfer[] $messages
150 
+     * @param ArrayObject $messages
151 151 
      *
152 152 
      * @return \Generated\Shared\Transfer\CartPreCheckResponseTransfer
153 153 
      */
 
@@ -162,7 +162,7 @@  discard block
 
 block discarded – undo
162 162
163 163 
     /**
164 164 
      * @param \Generated\Shared\Transfer\ItemTransfer $itemTransfer
165 
-     * @param \ArrayObject|\Generated\Shared\Transfer\ItemTransfer[] $itemsInCart
165 
+     * @param ArrayObject $itemsInCart
166 166 
      *
167 167 
      * @return int
168 168 
      */
 
@@ -181,7 +181,7 @@  discard block
 
 block discarded – undo
181 181 
     }
182 182
183 183 
     /**
184 
-     * @param \ArrayObject|\Generated\Shared\Transfer\ItemTransfer[] $itemsInCart
184 
+     * @param ArrayObject $itemsInCart
185 185 
      * @param \Generated\Shared\Transfer\ItemTransfer $itemTransfer
186 186 
      *
187 187 
      * @return \Generated\Shared\Transfer\MessageTransfer|null
 
@@ -200,7 +200,7 @@  discard block
 
 block discarded – undo
200 200 
     }
201 201
202 202 
     /**
203 
-     * @param \ArrayObject|\Generated\Shared\Transfer\ItemTransfer[] $itemsInCart
203 
+     * @param ArrayObject $itemsInCart
204 204 
      * @param \Propel\Runtime\Collection\ObjectCollection|\Orm\Zed\ProductBundle\Persistence\Base\SpyProductBundle[] $bundledProducts
205 205 
      * @param \Generated\Shared\Transfer\ItemTransfer $itemTransfer
206 206 
      *
 
@@ -224,7 +224,7 @@  discard block
 
 block discarded – undo
224 224 
     }
225 225
226 226 
     /**
227 
-     * @param \ArrayObject|\Generated\Shared\Transfer\ItemTransfer[] $itemsInCart
227 
+     * @param ArrayObject $itemsInCart
228 228 
      * @param \Generated\Shared\Transfer\ItemTransfer $itemTransfer
229 229 
      *
230 230 
      * @return \Generated\Shared\Transfer\MessageTransfer|null
Please login to merge, or discard this patch.
Availability/PreCheck/ProductBundleCheckoutAvailabilityCheck.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@
 
 block discarded – undo
41 41 
     /**
42 42 
      * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
43 43 
      *
44 
-     * @return array
44 
+     * @return ArrayObject
45 45 
      */
46 46 
     protected function getCheckoutAvailabilityFailedItems(QuoteTransfer $quoteTransfer)
47 47 
     {
Please login to merge, or discard this patch.
Zed/ProductBundle/Business/ProductBundle/Cart/ProductBundleCartExpander.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -173,7 +173,7 @@
 
 block discarded – undo
173 173 
     /**
174 174 
      * @param array $options
175 175 
      *
176 
-     * @return array
176 
+     * @return ProductOptionTransfer[]
177 177 
      */
178 178 
     protected function sortOptions(array $options)
179 179 
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -316,7 +316,7 @@
 
 block discarded – undo
316 316 
             static::$productPriceCache[$sku] = $this->priceFacade->getPriceBySku($sku);
317 317 
         }
318 318
319 
-         return static::$productPriceCache[$sku];
319 
+            return static::$productPriceCache[$sku];
320 320 
     }
321 321
322 322 
     /**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -179,7 +179,7 @@  discard block
 
 block discarded – undo
179 179 
     {
180 180 
         usort(
181 181 
             $options,
182 
-            function (ProductOptionTransfer $productOptionLeft, ProductOptionTransfer $productOptionRight) {
182 
+            function(ProductOptionTransfer $productOptionLeft, ProductOptionTransfer $productOptionRight) {
183 183 
                 return ($productOptionLeft->getSku() < $productOptionRight->getSku()) ? -1 : 1;
184 184 
             }
185 185 
         );
 
@@ -364,7 +364,7 @@  discard block
 
 block discarded – undo
364 364 
      */
365 365 
     protected function calculateBundleTotalUnitGrossPrice(array $bundledProducts)
366 366 
     {
367 
-        $totalBundleItemAmount = (int)array_reduce($bundledProducts, function ($total, ItemTransfer $itemTransfer) {
367 
+        $totalBundleItemAmount = (int)array_reduce($bundledProducts, function($total, ItemTransfer $itemTransfer) {
368 368 
             $total += $itemTransfer->getUnitGrossPrice();
369 369 
             return $total;
370 370 
         });
Please login to merge, or discard this patch.
Spryker/Zed/ProductBundle/Business/ProductBundle/ProductBundleWriter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -96,7 +96,7 @@
 
 block discarded – undo
96 96
97 97 
     /**
98 98 
      * @param \Generated\Shared\Transfer\ProductConcreteTransfer $productConcreteTransfer
99 
-     * @param \ArrayObject|\Generated\Shared\Transfer\ProductForBundleTransfer[] $bundledProducts
99 
+     * @param ArrayObject $bundledProducts
100 100 
      *
101 101 
      * @return void
102 102 
      */
Please login to merge, or discard this patch.
Zed/ProductBundle/Business/Availability/PreCheck/PreCheckMocks.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,7 @@  discard block
 
 block discarded – undo
32 32 
     ];
33 33
34 34 
     /**
35 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\ProductBundle\Dependency\Facade\ProductBundleToAvailabilityInterface
35 
+     * @return null|ProductBundleToAvailabilityInterface
36 36 
      */
37 37 
     protected function createAvailabilityFacadeMock()
38 38 
     {
 
@@ -69,7 +69,7 @@  discard block
 
 block discarded – undo
69 69
70 70 
     /**
71 71 
      * @param array $fixtures
72 
-     * @param \Spryker\Zed\ProductBundle\Business\ProductBundle\Availability\PreCheck\BasePreCheck|\PHPUnit_Framework_MockObject_MockObject $productBundleAvailabilityCheckMock
72 
+     * @param BasePreCheck $productBundleAvailabilityCheckMock
73 73 
      *
74 74 
      * @return void
75 75 
      */
Please login to merge, or discard this patch.
Business/Availability/PreCheck/ProductBundleCartAvailabilityCheckTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -102,7 +102,7 @@
 
 block discarded – undo
102 102 
      * @param \Spryker\Zed\ProductBundle\Dependency\Facade\ProductBundleToAvailabilityInterface|null $availabilityFacadeMock
103 103 
      * @param \Spryker\Zed\ProductBundle\Dependency\QueryContainer\ProductBundleToAvailabilityQueryContainerInterface|null $availabilityQueryContainerMock
104 104 
      *
105 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\ProductBundle\Business\ProductBundle\Availability\ProductBundleAvailabilityCheck
105 
+     * @return \Spryker\Zed\ProductBundle\Business\ProductBundle\Availability\PreCheck\BasePreCheck
106 106 
      */
107 107 
     protected function createProductBundleCartAvailabilityCheckMock(
108 108 
         ProductBundleToAvailabilityInterface $availabilityFacadeMock = null,
Please login to merge, or discard this patch.
Availability/PreCheck/ProductBundleCheckoutAvailabilityCheckTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -84,7 +84,7 @@
 
 block discarded – undo
84 84 
     /**
85 85 
      * @param \Spryker\Zed\ProductBundle\Dependency\Facade\ProductBundleToAvailabilityInterface|null $availabilityFacadeMock
86 86 
      *
87 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\ProductBundle\Business\ProductBundle\Availability\ProductBundleAvailabilityCheck
87 
+     * @return \Spryker\Zed\ProductBundle\Business\ProductBundle\Availability\PreCheck\BasePreCheck
88 88 
      */
89 89 
     protected function createProductBundleCheckoutAvailabilityCheckMock(
90 90 
         ProductBundleToAvailabilityInterface $availabilityFacadeMock = null
Please login to merge, or discard this patch.
Business/Availability/ProductBundleAvailabilityHandlerTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -122,7 +122,7 @@
 
 block discarded – undo
122 122 
     }
123 123
124 124 
     /**
125 
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Spryker\Zed\ProductBundle\Dependency\Facade\ProductBundleToAvailabilityInterface
125 
+     * @return null|ProductBundleToAvailabilityInterface
126 126 
      */
127 127 
     protected function createAvailabilityFacadeMock()
128 128 
     {
Please login to merge, or discard this patch.
tests/SprykerTest/Zed/ProductBundle/Business/ProductBundleReaderTest.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -92,7 +92,7 @@  discard block
 
 block discarded – undo
92 92 
      * @param \Spryker\Zed\ProductBundle\Persistence\ProductBundleQueryContainerInterface|null $productBundleQueryContainerMock
93 93 
      * @param \Spryker\Zed\ProductBundle\Dependency\QueryContainer\ProductBundleToAvailabilityQueryContainerInterface|null $productBundleToAvailabilityQueryContainerMock
94 94 
      *
95 
-     * @return \Spryker\Zed\ProductBundle\Business\ProductBundle\ProductBundleReader|\PHPUnit_Framework_MockObject_MockObject
95 
+     * @return ProductBundleReader
96 96 
      */
97 97 
     protected function createProductBundleReader(
98 98 
         ProductBundleQueryContainerInterface $productBundleQueryContainerMock = null,
 
@@ -133,7 +133,7 @@  discard block
 
 block discarded – undo
133 133
134 134 
     /**
135 135 
      * @param array $fixtures
136 
-     * @param \Spryker\Zed\ProductBundle\Business\ProductBundle\ProductBundleReader|\PHPUnit_Framework_MockObject_MockObject $productBundleReaderMock
136 
+     * @param ProductBundleReader $productBundleReaderMock
137 137 
      *
138 138 
      * @return void
139 139 
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -108,7 +108,7 @@
 
 block discarded – undo
108 108 
         }
109 109
110 110 
         $productBundleReaderMock = $this->getMockBuilder(ProductBundleReader::class)
111 
-            ->setConstructorArgs([$productBundleQueryContainerMock, $productBundleToAvailabilityQueryContainerMock ])
111 
+            ->setConstructorArgs([$productBundleQueryContainerMock, $productBundleToAvailabilityQueryContainerMock])
112 112 
             ->setMethods(['findBundledProducts', 'findOrCreateProductBundleAvailabilityEntity'])
113 113 
             ->getMock();
114 114
Please login to merge, or discard this patch.