| Conditions | 11 |
| Paths | 1024 |
| Total Lines | 45 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 123 | protected function setCacheControlHeader(Response $response): Response |
||
| 124 | { |
||
| 125 | $cacheControlConfig = $this->getConfig()->getCacheControlConfig(); |
||
| 126 | |||
| 127 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_PUBLIC])) { |
||
| 128 | $response->setPublic(); |
||
| 129 | } |
||
| 130 | |||
| 131 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_PRIVATE])) { |
||
| 132 | $response->setPrivate(); |
||
| 133 | } |
||
| 134 | |||
| 135 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_MAX_AGE])) { |
||
| 136 | $response->setMaxAge($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_MAX_AGE]); |
||
| 137 | } |
||
| 138 | |||
| 139 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_S_MAX_AGE])) { |
||
| 140 | $response->setSharedMaxAge($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_S_MAX_AGE]); |
||
| 141 | } |
||
| 142 | |||
| 143 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_NO_CACHE])) { |
||
| 144 | $response->headers->addCacheControlDirective(static::CONFIG_CACHE_CONTROL_DIRECTIVE_NO_CACHE, true); |
||
| 145 | } |
||
| 146 | |||
| 147 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_MUST_REVALIDATE])) { |
||
| 148 | $response->headers->addCacheControlDirective(static::CONFIG_CACHE_CONTROL_DIRECTIVE_MUST_REVALIDATE, true); |
||
| 149 | } |
||
| 150 | |||
| 151 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_NO_STORE])) { |
||
| 152 | $response->headers->addCacheControlDirective(static::CONFIG_CACHE_CONTROL_DIRECTIVE_NO_STORE, true); |
||
| 153 | } |
||
| 154 | |||
| 155 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_NO_TRANSFORM])) { |
||
| 156 | $response->headers->addCacheControlDirective(static::CONFIG_CACHE_CONTROL_DIRECTIVE_NO_TRANSFORM, true); |
||
| 157 | } |
||
| 158 | |||
| 159 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_DIRECTIVE_IMMUTABLE])) { |
||
| 160 | $response->headers->addCacheControlDirective(static::CONFIG_CACHE_CONTROL_DIRECTIVE_IMMUTABLE, true); |
||
| 161 | } |
||
| 162 | |||
| 163 | if (!empty($cacheControlConfig[static::CONFIG_CACHE_CONTROL_STALE_WHILE_REVALIDATE])) { |
||
| 164 | $response->headers->addCacheControlDirective(static::CONFIG_CACHE_CONTROL_STALE_WHILE_REVALIDATE, true); |
||
| 165 | } |
||
| 166 | |||
| 167 | return $response; |
||
| 168 | } |
||
| 170 |