Code Quality Summary - spryker/spryker-core - Measure and Improve Code Quality continuously with Scrutinizer

2025-09-16 10:12 UTC

Inspected FRW-10957 Adjusted P&S logic f...

1 failure condition met
	5 issues (5 minor) were introduced.
	1 new patch (Spacing) is available.
	29 added classes/operations
		A	DiscountConfig::getMaxAllowedDatetime() added
		A	DiscountConfiguratorPeriodConstraintProvider::__construct() added
		A	ProductListSearchToEventBehaviorFacadeBridge::hydrateEventDataTransfer... added
		A	MerchantProductSearchToProductPageSearchFacadeBridge::publish() added
		A	ProductConcretePageSearchPublisher::unpublishWithTimestamp() added
		A	ProductConcretePageSearchPublisher::publishWithTimestamp() added
		A	ProductListSearchRepository::getProductAbstractIdsTimestampMap() added
		A	ProductListSearchRepository::getProductAbstractIdsTimestampMapByConcre... added
		A	ProductLabelSearchFacadeTest::testWriteCollectionByProductLabelStoreEv... added
		A	ProductLabelSearchFacadeTest::testWriteCollectionByProductLabelEventsp... added
C	↗	B	FileAttachmentQueryBuilder improved
C	↗	B	FileAttachmentQueryBuilder::addRelationsToAQuery() improved
A	↘	B	SspAssetSearchFormHandler::handleSearchForm() got worse
B	↗	A	ViewFileDetailTable improved
view all

2025-09-10 11:17 UTC

Inspected FRW-10614: Adjusted publish lo...

1 failure condition met
	28 issues (28 minor) were introduced. 4 issues were fixed.
	395 added classes/operations
		D	DataImportMerchantRepository::applyDataImportMerchantFileFilters() added
		B	CsvHeaderConstraintValidator::validate() added
		B	DataImportMerchantHelper::createDataImportMerchantFile() added
		A	MerchantCombinedProductMerchantFileRequestExpanderPluginTest::testExpa... added
		A	MerchantCombinedProductMerchantFileRequestExpanderPluginTest::testExpa... added
		A	MerchantCombinedProductMerchantFileRequestExpanderPluginTest::testExpa... added
		A	MerchantCombinedProductMerchantFileRequestExpanderPluginTest::testExpa... added
		A	MerchantCombinedProductMerchantFileRequestExpanderPluginTest::testExpa... added
		A	MerchantCombinedProductMerchantFileRequestExpanderPluginTest::testExpa... added
		A	ImportController::indexAction() added
B	↘	C	ProductPageSearchEventSubscriber got worse
A	↘	B	DataImporter got worse
view all

2025-09-08 12:07 UTC

Inspected ACP-5361: Fixed Algolia config...

1 failure condition met
	1 issue (major) was introduced.
	39 added classes/operations
		A	OmsConfig::getStateMachineLockerTimeoutIntervalInSeconds() added
		A	TriggerLocker::mapLockTransfers() added
		A	TriggerLocker::releaseForOrder() added
		A	TriggerLocker::acquireLockWithExternalMechanism() added
		A	TriggerLocker::acquireForOrder() added
		A	StorageRedisClient::evaluate() added
		A	StorageRedisOmsLockPlugin::acquireLock() added
		A	StorageRedisOmsLockPlugin::releaseLock() added
		A	RedisStore::putOffExpiration() added
		A	RedisStore::evaluate() added
C	↘	F	OmsFacade got worse
view all

2025-09-08 05:32 UTC

Inspected SUPESC-972 ElasticSearch index...

	1 issue (minor) was introduced.
	74 added classes/operations
		A	SspAssetStorageReader::findSspAssetStorageByReference() added
		A	UpdateModelController::handleFormSubmission() added
		A	UpdateModelController::indexAction() added
		A	UpdateModelController::getSspModel() added
		A	AssetWidgetContentController::getSspAssets() added
		A	SspModelReader::expandWithFile() added
		A	SspModelReader::__construct() added
		A	SspModelReader::getSspModelCollection() added
		A	SspModelReader::expandWithImage() added
		B	SspModelManagementFacadeTest::testUpdateSspModelCollectionIsSuccessful... added
view all

2025-09-03 10:36 UTC

Inspected SSP-885 Consolidate "Attach Fi...

	3 issues (1 major, 2 minor) were introduced.
	3 new patches (Spacing) are available.
	300 added classes/operations
		C	FormDataProcessor::preprocessRequestData() added
		C	FormDataNormalizer::normalizeFormFieldArray() added
		B	ProductMerchantPortalGuiRepository::getProductsDashboardCardCounts() added
		B	FormDataNormalizer::cleanFormData() added
		A	CompanyUserAttachmentScopeStrategy::getScopeType() added
		A	CompanyUserAttachmentScopeStrategy::canProcess() added
		A	CompanyUserAttachmentScopeStrategy::getFormData() added
		A	BusinessUnitAssignmentImporter::getIdsToAssign() added
		A	BusinessUnitAssignmentImporter::getIdsToUnassign() added
		A	BusinessUnitAssignmentImporter::__construct() added
A	↘	B	FileAttachmentMapper::setCompanyFileAttachments() got worse
A	↘	B	FileAttachmentMapper::setBusinessUnitFileAttachments() got worse
A	↘	B	FileAttachmentMapper::setSspAssetFileAttachments() got worse
A	↘	B	FileAttachmentMapper::setCompanyUserFileAttachments() got worse
B	↗	A	AttachFileController::indexAction() improved
view all

2025-08-28 15:29 UTC

Inspected FRW-10901 Implement MultiProce...

	13 issues (8 major, 5 minor) were introduced. 3 issues were fixed.
	1 new patch (Spacing) is available.
	279 added classes/operations
		B	MultiProcessRunConsole::prepareChildConsoleCommandInput() added
		B	MultiProcessRunConsole::runSubProcess() added
		B	SspAssetQueryExpander::expandQuery() added
		B	CmsPageMessageBrokerPublisherTest::testSendCmsPagesToMessageBrokerWith... added
		A	CmsPageSortSearchHttpResultFormatterPlugin::getName() added
		A	CmsPageSortSearchHttpResultFormatterPlugin::formatResult() added
		A	MultiProcessRunConsole::createProcess() added
		A	MultiProcessRunConsole::configure() added
		A	MultiProcessRunConsole::getSubprocessTimeout() added
		A	MultiProcessRunConsole::getSubscribedSignals() added
view all

2025-08-21 15:47 UTC

Inspected FRW-10578: Publish performance...

	2 issues (1 major, 1 unknown) were introduced.
	4 new patches (Spacing) are available.
	146 added classes/operations
		B	SspAssetManagementFacadeTest::testGetSspAssetCollectionReturnsCorrectA... added
		B	SspAssetManagementFacadeTest::testUpdateSspAssetCollection() added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
		A	FindProductConcretePricesWithoutPriceExtractionByConcreteAbstractMapTe... added
B	↗	A	SspAssetFormDataProvider::expandOptionsWithSubmittedData() improved
A	↘	B	ActiveRecordBatchProcessorTraitTest got worse
A	↘	B	SspAssetMapper::mapSpySspAssetEntityToSspAssetTransferIncludes() got worse
view all

2025-08-15 14:29 UTC

Inspected SSP-767 Cypress end-to-end tes...

1 failure condition met

2025-06-20 06:15 UTC

Inspected FRW-10505 Adjusted tests. (#11...

1 failure condition met
	56 issues (35 major, 19 minor, 2 unknown) were introduced. 28 issues were fixed.
	3445 added classes/operations
		F	SelfServicePortalRepository::applyInquiryFilters() added
		F	SelfServicePortalRepository added
		F	SelfServicePortalBusinessFactory added
		F	SelfServicePortalCommunicationFactory added
		F	SelfServicePortalEntityManager added
		F	SelfServicePortalFactory added
		C	SelfServicePortalRepository::applyServiceFilters() added
		D	SspAssetForm added
		F	SelfServicePortalHelper added
		C	SspAssetForm::addBusinessUnitAssignmentValidationListener() added
A	↘	B	EditController::updateAction() got worse
B	↗	A	CustomerMultiFactorAuthFlowController::getCustomerEnabledTypesAction() improved
A	↘	B	CustomerMultiFactorAuthReader::getAvailableCustomerMultiFactorAuthType... got worse
D	↘	F	StockFacadeTest got worse
view all

2025-05-29 14:44 UTC

Inspected CC-35703 Discount Improvements...

	3 issues (2 major, 1 minor) were introduced.
	4 new patches (Spacing, Indentation) are available.
	153 added classes/operations
		A	IndexController::handleTableFilter() added
		A	TableFilterForm::addStatusField() added
		A	TableFilterForm::getBlockPrefix() added
		A	TableFilterForm::createDateTimeTransformer() added
		A	TableFilterForm::addValidFromField() added
		A	TableFilterForm::addStoreField() added
		A	TableFilterForm::buildForm() added
		A	TableFilterForm::addTypeField() added
		A	TableFilterForm::addValidToField() added
		A	TableFilterForm::configureOptions() added
B	↘	C	ProductTable got worse
view all

2025-05-28 08:59 UTC

Inspected SSP-1002 Fix file display at s...

	12 issues (4 major, 7 minor, 1 unknown) were introduced. 2 issues were fixed.
	162 added classes/operations
		B	QuoteRequestMapper::findConcreteVersion() added
		A	SitemapGenerator::getPaginatedSitemapXmlContentIndexedByFileName() added
		B	StockUpdater::getChangedProperties() added
		A	SitemapGenerator::removeOutdatedSitemapFiles() added
		A	SitemapGenerator::writeSitemapChunk() added
		A	SessionHandlerConfigurableRedisLockingProviderPluginTest::testHasCorre... added
		A	SessionHandlerConfigurableRedisLockingProviderPluginTest::testPluginRe... added
		A	SessionHandlerConfigurableRedisLockingProviderPluginTest::getSharedCon... added
		A	SessionHandlerConfigurableRedisLockingProviderPluginTest::testPluginRe... added
		A	SessionHandlerConfigurableRedisLockingProviderPluginTest::setUp() added
A	↘	B	StockUpdater::executeUpdateStockTransaction() got worse
A	↘	B	ClassDefinition::normalizePropertyTypes() got worse
A	↘	B	ProductTable got worse
D	↘	F	AbstractTransfer got worse
C	↘	D	StockFacadeTest got worse
view all

2024-12-24 10:52 UTC

Inspected ACP-4316 Use abstract product...

	19 added classes/operations
		A	ProductReviewToProductBridge::getRawProductAbstractTransfersByAbstract... added
		A	VersionAgnosticPredisAdapter::get() added
		A	VersionAgnosticPredisAdapter::mget() added
		A	VersionAgnosticPredisAdapter::info() added
		A	VersionAgnosticPredisAdapter::flushDb() added
		A	VersionAgnosticPredisAdapter::del() added
		A	VersionAgnosticPredisAdapter::disconnect() added
		A	VersionAgnosticPredisAdapter::mset() added
		A	VersionAgnosticPredisAdapter::__construct() added
		A	VersionAgnosticPredisAdapter::connect() added
view all

2024-12-23 10:52 UTC

Inspected FRW-9524 Adjusted BO edit cust...

	4 issues (2 major, 2 minor) were introduced. 2 issues were fixed.
	1 new patch (Spacing) is available.
	36 added classes/operations
		A	ProductLocalizedAttributesDataMergerTest::testProductConcreteLocalized... added
		A	ProductSearchToStorageClientBridge::__construct() added
		A	ProductSearchToStorageClientBridge::get() added
		A	MessageBrokerConfig::getMessageBrokerConsumeSuccessCodeName() added
		A	MessageBrokerConfig::getMessageBrokerConsumeSuccessCode() added
		A	MessageBrokerConfig::getMessageBrokerConsumeErrorCodeName() added
		A	MessageBrokerConfig::isMessageBodyIncludedInLogs() added
		A	MessageBrokerConfig::getMessageBrokerConsumeErrorCode() added
		A	MessagePublisherTest::testPublishMessageThrowsExceptionInCaseOfMessage... added
		A	MessageLogger::isEnvelopeReceived() added
view all

2024-12-17 10:31 UTC

Inspected FRW-9434 Fixed error on sendin...

	10 issues (8 major, 1 minor, 1 unknown) were introduced. 1 issue was fixed.
	155 added classes/operations
		A	PreOrderPayment::cancelPreOrderPayment() added
		A	PreOrderPayment::confirmPreOrderPayment() added
		A	PreOrderPayment::initializePreOrderPayment() added
		A	PreOrderPayment::getErrorMessageFromCheckoutPaymentRequestTransfer() added
		A	PreOrderPayment::__construct() added
		A	MerchantReferenceDecisionRulePlugin::acceptedDataTypes() added
		A	MerchantReferenceDecisionRulePlugin::getFieldName() added
		A	MerchantReferenceDecisionRulePlugin::getQueryStringValueOptions() added
		A	MerchantReferenceDecisionRulePlugin::isSatisfiedBy() added
		A	IsProductOfferReferenceSatisfiedByTest::testReturnsFalseWhenProductOff... added
view all

2024-12-10 10:07 UTC

Inspected SUPESC-882 Fixed category brea...

Good job, 1 issue was fixed.
8 added classes/operations
	A	CustomerConfig::isCustomerEmailValidationCaseSensitive() added
	A	AbstractSpyCustomerQuery::filterByEmail() added
	A	PaymentUpdatedTest::testGivenSalesPaymentDetailsExistsForAnOrderRefere... added
	A	PaymentUpdatedTest::testGivenSalesPaymentDetailsDoNotExistsWhenThePaym... added
	A	ExportMerchantCommissionsByMerchantCommissionExportRequestTest::testRe... added
	A	CustomerRepository::isEmailAvailableForCustomer() added
	A	ProductCategoryStorageClientTest::testFilterProductCategoriesByHttpRef... added
	A	ProductCategoryStorageClientTest::testFilterProductCategoriesByHttpRef... added