SprykerEco\Zed\Ratepay\Business\Api\Model\AbstractRequest::keyValueToXml()

Complexity

Conditions	7
Paths	13

Size

Total Lines	30
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function keyValueToXml($key, $value, SimpleXMLElement $xml)
    {
        if ($value !== null) {
            if ($value instanceof BuilderInterface) {
                if (is_numeric($key)) {
                    $key = $value->getRootTag();
                }
                $value = $value->buildData();
            }

            if (substr($key, 0, 1) === '@') {
                $attributeKey = substr($key, 1);
                $xml->addAttribute($attributeKey, $value);

It seems like $value can also be of type array; however, parameter $value of SimpleXMLElement::addAttribute() does only seem to accept string, maybe add an additional type check?

                return;
            }

            if ($key === '#') {
                $dom = dom_import_simplexml($xml);
                $owner = $dom->ownerDocument;
                $dom->appendChild($owner->createCDATASection($value));

It seems like $value can also be of type array; however, parameter $data of DOMDocument::createCDATASection() does only seem to accept string, maybe add an additional type check?

                return;
            }

            if (is_array($value)) {
                $subnode = $xml->addChild($key);
                $this->arrayToXml($value, $subnode);
                return;
            }

            $xml->addCDataChild($key, $value);
        }