spryker-eco /
payone
| Conditions | 18 |
| Paths | 7 |
| Total Lines | 55 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 2 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 142 | protected function setPayonePayment(Request $request, QuoteTransfer $quoteTransfer, string $paymentSelection): void |
||
| 143 | { |
||
| 144 | $payonePaymentTransfer = $this->getPayonePaymentTransfer($quoteTransfer, $paymentSelection); |
||
| 145 | |||
| 146 | $paymentDetailTransfer = new PaymentDetailTransfer(); |
||
| 147 | // get it from quotaTransfer |
||
| 148 | $paymentDetailTransfer->setAmount($quoteTransfer->getTotals()->getGrandTotal()); |
||
| 149 | $paymentDetailTransfer->setCurrency($this->getCurrency()); |
||
| 150 | if ($payonePaymentTransfer instanceof PayonePaymentCreditCardTransfer && $paymentSelection === PaymentTransfer::PAYONE_CREDIT_CARD) { |
||
| 151 | $paymentDetailTransfer->setPseudoCardPan($payonePaymentTransfer->getPseudocardpan()); |
||
| 152 | } elseif ($payonePaymentTransfer instanceof PayonePaymentEWalletTransfer && $paymentSelection === PaymentTransfer::PAYONE_E_WALLET) { |
||
| 153 | $paymentDetailTransfer->setType($payonePaymentTransfer->getWallettype()); |
||
| 154 | } elseif ($payonePaymentTransfer instanceof PayonePaymentDirectDebitTransfer && $paymentSelection === PaymentTransfer::PAYONE_DIRECT_DEBIT) { |
||
| 155 | $paymentDetailTransfer->setBankCountry($payonePaymentTransfer->getBankcountry()); |
||
| 156 | $paymentDetailTransfer->setBankAccount($payonePaymentTransfer->getBankaccount()); |
||
| 157 | $paymentDetailTransfer->setBankCode($payonePaymentTransfer->getBankcode()); |
||
| 158 | $paymentDetailTransfer->setBic($payonePaymentTransfer->getBic()); |
||
| 159 | $paymentDetailTransfer->setIban($payonePaymentTransfer->getIban()); |
||
| 160 | $paymentDetailTransfer->setMandateIdentification($payonePaymentTransfer->getMandateIdentification()); |
||
| 161 | $paymentDetailTransfer->setMandateText($payonePaymentTransfer->getMandateText()); |
||
| 162 | } elseif ( |
||
| 163 | $payonePaymentTransfer instanceof PayonePaymentOnlinetransferTransfer && ( |
||
| 164 | $paymentSelection === PaymentTransfer::PAYONE_EPS_ONLINE_TRANSFER |
||
| 165 | || $paymentSelection === PaymentTransfer::PAYONE_INSTANT_ONLINE_TRANSFER |
||
| 166 | || $paymentSelection === PaymentTransfer::PAYONE_GIROPAY_ONLINE_TRANSFER |
||
| 167 | || $paymentSelection === PaymentTransfer::PAYONE_IDEAL_ONLINE_TRANSFER |
||
| 168 | || $paymentSelection === PaymentTransfer::PAYONE_POSTFINANCE_EFINANCE_ONLINE_TRANSFER |
||
| 169 | || $paymentSelection === PaymentTransfer::PAYONE_POSTFINANCE_CARD_ONLINE_TRANSFER |
||
| 170 | || $paymentSelection === PaymentTransfer::PAYONE_PRZELEWY24_ONLINE_TRANSFER |
||
| 171 | || $paymentSelection === PaymentTransfer::PAYONE_BANCONTACT_ONLINE_TRANSFER |
||
| 172 | ) |
||
| 173 | ) { |
||
| 174 | $paymentDetailTransfer->setType($payonePaymentTransfer->getOnlineBankTransferType()); |
||
| 175 | $paymentDetailTransfer->setBankCountry($payonePaymentTransfer->getBankCountry()); |
||
| 176 | if ($paymentSelection === PaymentTransfer::PAYONE_BANCONTACT_ONLINE_TRANSFER) { |
||
| 177 | $paymentDetailTransfer->setBankCountry($quoteTransfer->getBillingAddress()->getIso2Code()); |
||
| 178 | } |
||
| 179 | $paymentDetailTransfer->setBankAccount($payonePaymentTransfer->getBankAccount()); |
||
| 180 | $paymentDetailTransfer->setBankCode($payonePaymentTransfer->getBankCode()); |
||
| 181 | $paymentDetailTransfer->setBankBranchCode($payonePaymentTransfer->getBankBranchCode()); |
||
| 182 | $paymentDetailTransfer->setBankCheckDigit($payonePaymentTransfer->getBankCheckDigit()); |
||
| 183 | $paymentDetailTransfer->setBankGroupType($payonePaymentTransfer->getBankGroupType()); |
||
| 184 | $paymentDetailTransfer->setIban($payonePaymentTransfer->getIban()); |
||
| 185 | $paymentDetailTransfer->setBic($payonePaymentTransfer->getBic()); |
||
| 186 | } elseif ($paymentSelection == PaymentTransfer::PAYONE_CASH_ON_DELIVERY) { |
||
| 187 | $shippingProvider = $quoteTransfer->getShipment()->getMethod()->getCarrierName(); |
||
| 188 | $paymentDetailTransfer->setShippingProvider($shippingProvider); |
||
| 189 | } |
||
| 190 | |||
| 191 | $payonePaymentTransfer = new PayonePaymentTransfer(); |
||
| 192 | $payonePaymentTransfer->setReference(uniqid(static::PAYONE_PAYMENT_REFERENCE_PREFIX)); |
||
| 193 | $payonePaymentTransfer->setPaymentDetail($paymentDetailTransfer); |
||
| 194 | $paymentTransfer = $quoteTransfer->getPayment(); |
||
| 195 | $payonePaymentTransfer->setPaymentMethod($paymentTransfer->getPaymentMethod()); |
||
| 196 | $paymentTransfer->setPayone($payonePaymentTransfer); |
||
| 197 | } |
||
| 221 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths