PartialCaptureIsApprovedConditionPlugin::check() - Code Metrics - Inspection of "INT-72: Payone optimisations" - spryker-eco/payone - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#51)

by Aleksey

created 2020-06-22 13:19 UTC

PartialCaptureIsApprovedConditionPlugin::check() A

↳ Parent: PartialCaptureIsApprovedConditionPlugin

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	6
rs	10

<?php

/**
 * MIT License
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\Payone\Communication\Plugin\Oms\Condition;

use Orm\Zed\Sales\Persistence\SpySalesOrderItem;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Shared\Payone\PayoneTransactionStatusConstants;
use Spryker\Zed\Kernel\Communication\AbstractPlugin;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Spryker\Zed\Oms\Dependency\Plugin\Condition\ConditionInterface;

/**
 * @method \SprykerEco\Zed\Payone\Business\PayoneFacadeInterface getFacade()
 * @method \SprykerEco\Zed\Payone\Communication\PayoneCommunicationFactory getFactory()
 * @method \SprykerEco\Zed\Payone\PayoneConfig getConfig()
 */
class PartialCaptureIsApprovedConditionPlugin extends AbstractPlugin implements ConditionInterface
{
    /**
     * {@inheritDoc}
     * - Checks if payone order item status is `capture approved`.
     *
     * @api
     *
     * @param \Orm\Zed\Sales\Persistence\SpySalesOrderItem $orderItem
     *
     * @return bool
     */
    public function check(SpySalesOrderItem $orderItem): bool
    {
        $payoneOrderItemStatus = $this->getFacade()
            ->findPayoneOrderItemStatus($orderItem->getFkSalesOrder(), $orderItem->getIdSalesOrderItem());

        return $payoneOrderItemStatus === PayoneTransactionStatusConstants::STATUS_CAPTURE_APPROVED;
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\Payone\Communication\Plugin\Oms\Condition;
9
10			use Orm\Zed\Sales\Persistence\SpySalesOrderItem;
			0 ignored issues – show Bug introduced 2020-06-22 11:06 UTC by Report Bug Copy Issue Report The type `Orm\Zed\Sales\Persistence\SpySalesOrderItem` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use SprykerEco\Shared\Payone\PayoneTransactionStatusConstants;
12			use Spryker\Zed\Kernel\Communication\AbstractPlugin;
			0 ignored issues – show Bug introduced 2020-06-22 11:06 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `SprykerEco\Zed\Payone\Co...ondition\AbstractPlugin`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
13			use Spryker\Zed\Oms\Dependency\Plugin\Condition\ConditionInterface;
14
15			/**
16			* @method \SprykerEco\Zed\Payone\Business\PayoneFacadeInterface getFacade()
17			* @method \SprykerEco\Zed\Payone\Communication\PayoneCommunicationFactory getFactory()
18			* @method \SprykerEco\Zed\Payone\PayoneConfig getConfig()
19			*/
20			class PartialCaptureIsApprovedConditionPlugin extends AbstractPlugin implements ConditionInterface
21			{
22			/**
23			* {@inheritDoc}
24			* - Checks if payone order item status is `capture approved`.
25			*
26			* @api
27			*
28			* @param \Orm\Zed\Sales\Persistence\SpySalesOrderItem $orderItem
29			*
30			* @return bool
31			*/
32			public function check(SpySalesOrderItem $orderItem): bool
33			{
34			$payoneOrderItemStatus = $this->getFacade()
35			->findPayoneOrderItemStatus($orderItem->getFkSalesOrder(), $orderItem->getIdSalesOrderItem());
36
37			return $payoneOrderItemStatus === PayoneTransactionStatusConstants::STATUS_CAPTURE_APPROVED;
38			}
39			}
40

spryker-eco / payone

Pull Request — master (#51)

PartialCaptureIsApprovedConditionPlugin::check() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like