RefundChecker::isRefundPossible() - Code Metrics - Inspection of "ECO-3614 Payone Klarna" - spryker-eco/payone - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#67)

unknown

created 2021-06-10 14:42 UTC

RefundChecker::isRefundPossible() A

↳ Parent: RefundChecker

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
eloc	5
c	1
b	1
f	0
dl	0
loc	11
rs	10
cc	3
nc	3
nop	1

<?php

/**
 * MIT License
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\Payone\Business\ConditionChecker;

use Generated\Shared\Transfer\OrderTransfer;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Zed\Payone\Persistence\PayoneRepositoryInterface;

class RefundChecker implements RefundCheckerInterface
{
    /**
     * @var \SprykerEco\Zed\Payone\Persistence\PayoneRepositoryInterface
     */
    protected $payoneRepository;

    /**
     * @var \SprykerEco\Zed\Payone\Business\ConditionChecker\PaymentDataCheckerInterface
     */
    protected $paymentDataChecker;

    /**
     * @param \SprykerEco\Zed\Payone\Persistence\PayoneRepositoryInterface $payoneRepository
     * @param \SprykerEco\Zed\Payone\Business\ConditionChecker\PaymentDataCheckerInterface $paymentDataChecker
     */
    public function __construct(
        PayoneRepositoryInterface $payoneRepository,
        PaymentDataCheckerInterface $paymentDataChecker
    ) {
        $this->payoneRepository = $payoneRepository;
        $this->paymentDataChecker = $paymentDataChecker;
    }

    /**
     * @param \Generated\Shared\Transfer\OrderTransfer $orderTransfer
     *
     * @return bool
     */
    public function isRefundPossible(OrderTransfer $orderTransfer): bool
    {
        $paymentTransfer = $this->payoneRepository->getPayonePaymentByOrder($orderTransfer);

        if (!$this->paymentDataChecker->isPaymentDataRequired($orderTransfer)) {
            return true;
        }

        $paymentDetailTransfer = $paymentTransfer->getPaymentDetail();

        return $paymentDetailTransfer->getBic() && $paymentDetailTransfer->getIban();
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\Payone\Business\ConditionChecker;
9
10			use Generated\Shared\Transfer\OrderTransfer;
			0 ignored issues – show Bug introduced 2021-05-20 10:20 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\OrderTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use SprykerEco\Zed\Payone\Persistence\PayoneRepositoryInterface;
12
13			class RefundChecker implements RefundCheckerInterface
14			{
15			/**
16			* @var \SprykerEco\Zed\Payone\Persistence\PayoneRepositoryInterface
17			*/
18			protected $payoneRepository;
19
20			/**
21			* @var \SprykerEco\Zed\Payone\Business\ConditionChecker\PaymentDataCheckerInterface
22			*/
23			protected $paymentDataChecker;
24
25			/**
26			* @param \SprykerEco\Zed\Payone\Persistence\PayoneRepositoryInterface $payoneRepository
27			* @param \SprykerEco\Zed\Payone\Business\ConditionChecker\PaymentDataCheckerInterface $paymentDataChecker
28			*/
29			public function __construct(
30			PayoneRepositoryInterface $payoneRepository,
31			PaymentDataCheckerInterface $paymentDataChecker
32			) {
33			$this->payoneRepository = $payoneRepository;
34			$this->paymentDataChecker = $paymentDataChecker;
35			}
36
37			/**
38			* @param \Generated\Shared\Transfer\OrderTransfer $orderTransfer
39			*
40			* @return bool
41			*/
42			public function isRefundPossible(OrderTransfer $orderTransfer): bool
43			{
44			$paymentTransfer = $this->payoneRepository->getPayonePaymentByOrder($orderTransfer);
45
46			if (!$this->paymentDataChecker->isPaymentDataRequired($orderTransfer)) {
47			return true;
48			}
49
50			$paymentDetailTransfer = $paymentTransfer->getPaymentDetail();
51
52			return $paymentDetailTransfer->getBic() && $paymentDetailTransfer->getIban();
53			}
54			}
55

spryker-eco / payone

Pull Request — master (#67)

RefundChecker::isRefundPossible() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like