Conditions | 14 |
Paths | 7 |
Total Lines | 57 |
Code Lines | 45 |
Lines | 0 |
Ratio | 0 % |
Changes | 3 | ||
Bugs | 2 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
122 | protected function setPayonePayment(Request $request, QuoteTransfer $quoteTransfer, string $paymentSelection): void |
||
123 | { |
||
124 | $payonePaymentTransfer = $this->getPayonePaymentTransfer($quoteTransfer, $paymentSelection); |
||
125 | |||
126 | $paymentDetailTransfer = new PaymentDetailTransfer(); |
||
127 | // get it from quotaTransfer |
||
128 | $paymentDetailTransfer->setAmount($quoteTransfer->getTotals()->getGrandTotal()); |
||
129 | $paymentDetailTransfer->setCurrency($quoteTransfer->getCurrencyOrFail()->getCodeOrFail()); |
||
130 | if ($paymentSelection === PaymentTransfer::PAYONE_CREDIT_CARD) { |
||
131 | /** @var \Generated\Shared\Transfer\PayonePaymentCreditCardTransfer $payonePaymentTransfer */ |
||
132 | $paymentDetailTransfer->setPseudoCardPan($payonePaymentTransfer->getPseudocardpan()); |
||
133 | } elseif ($paymentSelection === PaymentTransfer::PAYONE_E_WALLET) { |
||
134 | /** @var \Generated\Shared\Transfer\PayonePaymentEWalletTransfer $payonePaymentTransfer */ |
||
135 | $paymentDetailTransfer->setType($payonePaymentTransfer->getWallettype()); |
||
136 | } elseif ($paymentSelection === PaymentTransfer::PAYONE_DIRECT_DEBIT) { |
||
137 | /** @var \Generated\Shared\Transfer\PayonePaymentDirectDebitTransfer $payonePaymentTransfer */ |
||
138 | $paymentDetailTransfer->setBankCountry($payonePaymentTransfer->getBankcountry()); |
||
139 | $paymentDetailTransfer->setBankAccount($payonePaymentTransfer->getBankaccount()); |
||
140 | $paymentDetailTransfer->setBankCode($payonePaymentTransfer->getBankcode()); |
||
141 | $paymentDetailTransfer->setBic($payonePaymentTransfer->getBic()); |
||
142 | $paymentDetailTransfer->setIban($payonePaymentTransfer->getIban()); |
||
143 | $paymentDetailTransfer->setMandateIdentification($payonePaymentTransfer->getMandateIdentification()); |
||
144 | $paymentDetailTransfer->setMandateText($payonePaymentTransfer->getMandateText()); |
||
145 | } elseif ( |
||
146 | $paymentSelection === PaymentTransfer::PAYONE_EPS_ONLINE_TRANSFER |
||
147 | || $paymentSelection === PaymentTransfer::PAYONE_INSTANT_ONLINE_TRANSFER |
||
148 | || $paymentSelection === PaymentTransfer::PAYONE_GIROPAY_ONLINE_TRANSFER |
||
149 | || $paymentSelection === PaymentTransfer::PAYONE_IDEAL_ONLINE_TRANSFER |
||
150 | || $paymentSelection === PaymentTransfer::PAYONE_POSTFINANCE_EFINANCE_ONLINE_TRANSFER |
||
151 | || $paymentSelection === PaymentTransfer::PAYONE_POSTFINANCE_CARD_ONLINE_TRANSFER |
||
152 | || $paymentSelection === PaymentTransfer::PAYONE_PRZELEWY24_ONLINE_TRANSFER |
||
153 | || $paymentSelection === PaymentTransfer::PAYONE_BANCONTACT_ONLINE_TRANSFER |
||
154 | ) { |
||
155 | /** @var \Generated\Shared\Transfer\PayonePaymentOnlinetransferTransfer $payonePaymentTransfer */ |
||
156 | $paymentDetailTransfer->setType($payonePaymentTransfer->getOnlineBankTransferType()); |
||
157 | $paymentDetailTransfer->setBankCountry($payonePaymentTransfer->getBankCountry()); |
||
158 | if ($paymentSelection === PaymentTransfer::PAYONE_BANCONTACT_ONLINE_TRANSFER) { |
||
159 | $paymentDetailTransfer->setBankCountry($quoteTransfer->getBillingAddress()->getIso2Code()); |
||
160 | } |
||
161 | $paymentDetailTransfer->setBankAccount($payonePaymentTransfer->getBankAccount()); |
||
162 | $paymentDetailTransfer->setBankCode($payonePaymentTransfer->getBankCode()); |
||
163 | $paymentDetailTransfer->setBankBranchCode($payonePaymentTransfer->getBankBranchCode()); |
||
164 | $paymentDetailTransfer->setBankCheckDigit($payonePaymentTransfer->getBankCheckDigit()); |
||
165 | $paymentDetailTransfer->setBankGroupType($payonePaymentTransfer->getBankGroupType()); |
||
166 | $paymentDetailTransfer->setIban($payonePaymentTransfer->getIban()); |
||
167 | $paymentDetailTransfer->setBic($payonePaymentTransfer->getBic()); |
||
168 | } elseif ($paymentSelection == PaymentTransfer::PAYONE_CASH_ON_DELIVERY) { |
||
169 | $shippingProvider = $quoteTransfer->getShipment()->getMethod()->getCarrierName(); |
||
170 | $paymentDetailTransfer->setShippingProvider($shippingProvider); |
||
171 | } |
||
172 | |||
173 | $payonePaymentTransfer = new PayonePaymentTransfer(); |
||
174 | $payonePaymentTransfer->setReference(uniqid(self::PAYONE_PAYMENT_REFERENCE_PREFIX)); |
||
175 | $payonePaymentTransfer->setPaymentDetail($paymentDetailTransfer); |
||
176 | $paymentTransfer = $quoteTransfer->getPayment(); |
||
177 | $payonePaymentTransfer->setPaymentMethod($paymentTransfer->getPaymentMethod()); |
||
178 | $paymentTransfer->setPayone($payonePaymentTransfer); |
||
179 | } |
||
195 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths