Passed
Pull Request — master (#13)
by Dmitri
05:33
created

RevertPartialPlugin   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 22
Duplicated Lines 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 1
eloc 7
dl 0
loc 22
rs 10
c 1
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A run() 0 11 1
1
<?php
2
3
/**
4
 * MIT License
5
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6
 */
7
8
namespace SprykerEco\Zed\Payolution\Communication\Plugin\Oms\Command;
9
10
use Orm\Zed\Sales\Persistence\SpySalesOrder;
0 ignored issues
show
Bug introduced by
The type Orm\Zed\Sales\Persistence\SpySalesOrder was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
11
use Spryker\Zed\Kernel\Communication\AbstractPlugin;
12
use Spryker\Zed\Oms\Business\Util\ReadOnlyArrayObject;
13
use Spryker\Zed\Oms\Dependency\Plugin\Command\CommandByOrderInterface;
14
15
/**
16
 * @method \SprykerEco\Zed\Payolution\Business\PayolutionFacade getFacade()
17
 * @method \SprykerEco\Zed\Payolution\Communication\PayolutionCommunicationFactory getFactory()
18
 */
19
class RevertPartialPlugin extends AbstractPlugin implements CommandByOrderInterface
20
{
21
    /**
22
     * @api
23
     *
24
     * @param \Orm\Zed\Sales\Persistence\SpySalesOrderItem[] $orderItems
25
     * @param \Orm\Zed\Sales\Persistence\SpySalesOrder $orderEntity
26
     * @param \Spryker\Zed\Oms\Business\Util\ReadOnlyArrayObject $data
27
     *
28
     * @return array
29
     */
30
    public function run(array $orderItems, SpySalesOrder $orderEntity, ReadOnlyArrayObject $data)
31
    {
32
        $omsEntityConverter = $this->getFactory()->createOmsEntityConverter($orderItems, $orderEntity);
33
34
        $this->getFacade()->revertPayment(
35
            $omsEntityConverter->extractOrderTransfer($orderEntity),
36
            $omsEntityConverter->extractPaymentEntity($orderEntity)->getIdPaymentPayolution(),
37
            $omsEntityConverter->extractPartialOrderItems($orderItems, $orderEntity)
0 ignored issues
show
Unused Code introduced by
The call to SprykerEco\Zed\Payolutio...Facade::revertPayment() has too many arguments starting with $omsEntityConverter->ext...derItems, $orderEntity). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

37
        $this->getFacade()->/** @scrutinizer ignore-call */ revertPayment(

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
38
        );
39
40
        return [];
41
    }
42
}
43