HeidelpayEasycreditStep::__construct() - Code Metrics - Inspection of "ECO-2747: Checkout steps moved to module." - spryker-eco/heidelpay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 65ef69...e609af )

by Aleksey

created 2019-05-13 06:13 UTC

HeidelpayEasycreditStep::__construct() A

↳ Parent: HeidelpayEasycreditStep

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Yves\Heidelpay\CheckoutPage\Process\Steps;

use Spryker\Shared\Kernel\Transfer\AbstractTransfer;
use Spryker\Yves\StepEngine\Dependency\Step\StepWithExternalRedirectInterface;
use SprykerEco\Shared\Heidelpay\HeidelpayConfig;
use SprykerShop\Yves\CheckoutPage\Process\Steps\AbstractBaseStep;
filter:
    dependency_paths: ["lib/*"]
use Symfony\Component\HttpFoundation\Request;

class HeidelpayEasycreditStep extends AbstractBaseStep implements StepWithExternalRedirectInterface
{
    public const HEIDELPAY_EASYCREDIT_STEP_ROUTE = 'HEIDELPAY_EASYCREDIT_STEP_ROUTE';

    /**
     * @var string
     */
    protected $externalRedirectUrl;

    /**
     * @param string $stepRoute
     * @param string $escapeRoute
     */
    public function __construct(
        string $stepRoute,
        string $escapeRoute
    ) {
        parent::__construct($stepRoute, $escapeRoute);
    }

    /**
     * @param \Spryker\Shared\Kernel\Transfer\AbstractTransfer $quoteTransfer
     *
     * @return bool
     */
    public function requireInput(AbstractTransfer $quoteTransfer)
    {
        return false;
    }

    /**
     * Empty quote transfer and mark logged in customer as "dirty" to force update it in the next request.
     *
     * @param \Symfony\Component\HttpFoundation\Request $request
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
filter:
    dependency_paths: ["lib/*"]
     *
     * @return \Generated\Shared\Transfer\QuoteTransfer|\Spryker\Shared\Kernel\Transfer\AbstractTransfer
     */
    public function execute(Request $request, AbstractTransfer $quoteTransfer)
    {
        if ($this->isEasyCreditPaymentMethod($quoteTransfer) === false) {
            return $quoteTransfer;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $this->externalRedirectUrl = $quoteTransfer->getHeidelpayPayment()->getExternalRedirectUrl();
        $this->externalRedirectUrl = $quoteTransfer->/** @scrutinizer ignore-call */ getHeidelpayPayment()->getExternalRedirectUrl();

        return $quoteTransfer;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * @return string
     */
    public function getExternalRedirectUrl()
    {
        return $this->externalRedirectUrl;
    }

    /**
     * @param \Spryker\Shared\Kernel\Transfer\AbstractTransfer|\Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return bool
     */
    public function postCondition(AbstractTransfer $quoteTransfer)
    {
        return true;
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return bool
     */
    protected function isEasyCreditPaymentMethod(AbstractTransfer $quoteTransfer): bool
    {
        $result = ($quoteTransfer->getPayment() !== null
        $result = ($quoteTransfer->/** @scrutinizer ignore-call */ getPayment() !== null
            && $quoteTransfer->getPayment()->getPaymentSelection() === HeidelpayConfig::PAYMENT_METHOD_EASY_CREDIT);

        return $result;
    }
}


spryker-eco / heidelpay

Push — dev ( 65ef69...e609af )

HeidelpayEasycreditStep::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like