SprykerEco\Yves\FactFinderWebComponents\Form\WebComponentConfigToTwigConfigTransformer

Complexity

Total Complexity

15

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	transformFromArrayToHtmlAttributes()	0	23	5
A	transform()	0	15	3
A	reverseTransform()	0	14	3
A	transformFropmHtmlAttributesToArray()	0	15	4

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Yves\FactFinderWebComponents\Form;

use Symfony\Component\Form\DataTransformerInterface;

class WebComponentConfigToTwigConfigTransformer implements DataTransformerInterface
{
    public const ITEMS_PARAMETER = 'items';

    /**
     * @inheritdoc
     *
     * @param mixed $value
     *
     * @return mixed|void
     */
    public function transform($value)
    {
        $result = [];
        $properties = '';

The assignment to $properties is dead and can be removed.

        if (is_array($value)) {
            $result = $value;

            if (isset($value['properties'])) {
                $result['component'] = $this->transformFromArrayToHtmlAttributes($result['properties'] ?? []);
                unset($result['properties']);
            }
        }

        return $result;
    }

    /**
     * @param array $collection
     *
     * @return string
     */
    protected function transformFromArrayToHtmlAttributes(array $collection): string
    {
        $htmlAttributesString = '';

        $iterationCount = 0;
        $maxIterationCount = count($collection);
        foreach ($collection as $itemKey => $itemValue) {
            if (is_bool($itemValue)) {
                if ($itemValue === true) {
                    $htmlAttributesString .= sprintf('%s', $itemKey);
                }
            } else {
                $htmlAttributesString .= sprintf('%s="%s"', $itemKey, $itemValue);
            }

            if ($iterationCount < $maxIterationCount) {
                $htmlAttributesString .= ' ';
            }

            ++$iterationCount;
        }

        return $htmlAttributesString;
    }

    /**
     * @inheritdoc
     *
     * @param mixed $value
     *
     * @return mixed|void
     */
    public function reverseTransform($value)
    {
        $result = [];

        if (is_array($value)) {
            $result = $value;

            if (isset($value['component'])) {
                $result['properties'] = $this->transformFropmHtmlAttributesToArray($result['component'] ?? []);

It seems like $result['component'] ?? array() can also be of type array; however, parameter $attributes of SprykerEco\Yves\FactFinderWebComponents\Form\WebComponentConfigToTwigConfigTransformer::transformFropmHtmlAttributesToArray() does only seem to accept string, maybe add an additional type check?

                unset($result['component']);
            }
        }

        return $result;
    }

    /**
     * @param string $attributes
     *
     * @return array
     */
    protected function transformFropmHtmlAttributesToArray(string $attributes): array
    {
        $properties = [];

        if (is_string($attributes)) {

The condition is_string($attributes) is always true.

            $attributeDataCollection = explode(' ', trim($attributes));
            foreach ($attributeDataCollection as $attributeDataString) {
                $varData = explode('=', $attributeDataString);
                if ($varData) {

The expression $varData of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    $properties[$varData[0]] = trim($varData[1], '"\'');
                }
            }
        }

        return $properties;
    }
}