Conditions | 8 |
Paths | 72 |
Total Lines | 67 |
Code Lines | 41 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
70 | protected function convertCampaigns($campaigns) |
||
71 | { |
||
72 | $factFinderDataCampaignIteratorTransfer = new FactFinderSdkDataCampaignIteratorTransfer(); |
||
73 | $factFinderDataCampaignIteratorTransfer->setHasRedirect($campaigns->hasRedirect()); |
||
74 | $factFinderDataCampaignIteratorTransfer->setRedirectUrl($campaigns->getRedirectUrl()); |
||
75 | $factFinderDataCampaignIteratorTransfer->setHasFeedback($campaigns->hasFeedback()); |
||
76 | // $factFinderDataCampaignIteratorTransfer->setFeedback($campaigns->getFeedback()); |
||
77 | $factFinderDataCampaignIteratorTransfer->setHasPushedProducts($campaigns->hasPushedProducts()); |
||
78 | /** @var \FACTFinder\Data\Record $pushedProduct */ |
||
79 | foreach ($campaigns->getPushedProducts() as $pushedProduct) { |
||
80 | $this->recordConverter->setRecord($pushedProduct); |
||
81 | $factFinderDataCampaignIteratorTransfer->addPushedProducts( |
||
82 | $this->recordConverter->convert() |
||
83 | ); |
||
84 | } |
||
85 | $factFinderDataCampaignIteratorTransfer->setHasActiveQuestions($campaigns->hasActiveQuestions()); |
||
86 | /** @var \FACTFinder\Data\Record $activeQuestion */ |
||
87 | foreach ($campaigns->getActiveQuestions() as $activeQuestion) { |
||
88 | $this->recordConverter->setRecord($activeQuestion); |
||
89 | $factFinderDataCampaignIteratorTransfer->addGetActiveQuestions( |
||
90 | $this->recordConverter->convert() |
||
91 | ); |
||
92 | } |
||
93 | $factFinderDataCampaignIteratorTransfer->setHasAdvisorTree($campaigns->hasAdvisorTree()); |
||
94 | /** @var \FACTFinder\Data\Record $advisorTree */ |
||
95 | foreach ($campaigns->getAdvisorTree() as $advisorTree) { |
||
96 | $this->recordConverter->setRecord($advisorTree); |
||
97 | $factFinderDataCampaignIteratorTransfer->addAdvisorTree( |
||
98 | $this->recordConverter->convert() |
||
99 | ); |
||
100 | } |
||
101 | |||
102 | /** @var \FACTFinder\Data\Campaign $campaign */ |
||
103 | foreach ($campaigns as $campaign) { |
||
104 | $factFinderDataCampaignTransfer = new FactFinderSdkDataCampaignTransfer(); |
||
105 | $factFinderDataCampaignTransfer->setName($campaign->getName()); |
||
106 | $factFinderDataCampaignTransfer->setCategory($campaign->getCategory()); |
||
107 | $factFinderDataCampaignTransfer->setRedirectUrl($campaign->getRedirectUrl()); |
||
108 | $factFinderDataCampaignTransfer->setFeedback($campaign->getFeedbackArray()); |
||
109 | $factFinderDataCampaignTransfer->setHasRedirect($campaign->hasRedirect()); |
||
110 | $factFinderDataCampaignTransfer->setHasPushedProducts($campaign->hasPushedProducts()); |
||
111 | /** @var \FACTFinder\Data\Record $pushedProduct */ |
||
112 | foreach ($campaign->getPushedProducts() as $pushedProduct) { |
||
113 | $this->recordConverter->setRecord($pushedProduct); |
||
114 | $factFinderDataCampaignTransfer->addPushedProducts( |
||
115 | $this->recordConverter->convert() |
||
116 | ); |
||
117 | } |
||
118 | /** @var \FACTFinder\Data\AdvisorQuestion $activeQuestion */ |
||
119 | foreach ($campaign->getActiveQuestions() as $activeQuestion) { |
||
120 | $this->advisorQuestionConverter->setAdvisorQuestion($activeQuestion); |
||
121 | $factFinderDataCampaignTransfer->addActiveQuestions( |
||
122 | $this->advisorQuestionConverter->convert() |
||
123 | ); |
||
124 | } |
||
125 | /** @var \FACTFinder\Data\AdvisorQuestion $advisorTree */ |
||
126 | foreach ($campaign->getAdvisorTree() as $advisorTree) { |
||
127 | $this->advisorQuestionConverter->setAdvisorQuestion($advisorTree); |
||
128 | $factFinderDataCampaignTransfer->addAdvisorTree( |
||
129 | $this->advisorQuestionConverter->convert() |
||
130 | ); |
||
131 | } |
||
132 | |||
133 | $factFinderDataCampaignIteratorTransfer->addCampaigns($factFinderDataCampaignTransfer); |
||
134 | } |
||
135 | |||
136 | return $factFinderDataCampaignIteratorTransfer; |
||
137 | } |
||
139 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"]
, you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths