FactFinderNgSearchToElasticaMapper::mapElasticaHits() - Code Metrics - Inspection of "Fixes" - spryker-eco/fact-finder-ng - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — feature/eco-3192/fact-finder-n... ( 3e466e...3cb71a )

by Volodymyr
created 2019-09-06 13:21 UTC
mapElasticaHits() A

↳ Parent: FactFinderNgSearchToElasticaMapper
Complexity

Conditions	4
Paths	4
Size

Total Lines	58
Code Lines	40
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
eloc	40
c	1
b	0
f	0
dl	0
loc	58
rs	9.28
cc	4
nc	4
nop	1
How to fix Long Method

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Client\FactFinderNg\Mapper\Elastica;

use Elastica\Query;
use Elastica\Response;
use Elastica\ResultSet;
use Elastica\ResultSet\DefaultBuilder;
use ErrorException;
use Generated\Shared\Transfer\StoreTransfer;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToPriceProductStorageClientInterface;
use SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToProductImageStorageClientInterface;
use SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToProductStorageClientInterface;

class FactFinderNgSearchToElasticaMapper extends AbstractFactFinderToElasticaMapper implements FactFinderToElasticaMapperInterface
{
    /**
     * @var \Elastica\ResultSet\DefaultBuilder
     */
    protected $elasticaDefaultBuilder;

    /**
     * @var \SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToProductStorageClientInterface
     */
    protected $productStorageClient;

    /**
     * @var \SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToProductImageStorageClientInterface
     */
    protected $productImageStorageClient;

    /**
     * @param \Elastica\ResultSet\DefaultBuilder $elasticaDefaultBuilder
     * @param \SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToProductStorageClientInterface $productStorageClient
     * @param \SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToProductImageStorageClientInterface $productImageStorageClient
     * @param \SprykerEco\Client\FactFinderNg\Dependency\Client\FactFinderNgToPriceProductStorageClientInterface $priceProductStorageClient
     */
    public function __construct(
        DefaultBuilder $elasticaDefaultBuilder,
        FactFinderNgToProductStorageClientInterface $productStorageClient,
        FactFinderNgToProductImageStorageClientInterface $productImageStorageClient,
        FactFinderNgToPriceProductStorageClientInterface $priceProductStorageClient
    ) {
        parent::__construct($priceProductStorageClient);

        $this->elasticaDefaultBuilder = $elasticaDefaultBuilder;
        $this->productStorageClient = $productStorageClient;
        $this->productImageStorageClient = $productImageStorageClient;
    }

    /**
     * @param array $searchResult
     * @param \Elastica\Query $elasticaQuery
     * @param string $currentLocale
     * @param \Generated\Shared\Transfer\StoreTransfer $currentStore
     *
     * @return \Elastica\ResultSet
     */
    public function map(
        array $searchResult,
        Query $elasticaQuery,
        string $currentLocale,
        StoreTransfer $currentStore
    ): ResultSet {
        $this->currentLocale = $currentLocale;
        $this->currentStore = $currentStore;

        try {
            $elasticaResponseArray = $this->mapSearchResultToElasticaResponseArray($searchResult);
        } catch (ErrorException $e) {
            $elasticaResponseArray = [];
        }

        $elasticaResponse = new Response($elasticaResponseArray, 200);

        return $this->elasticaDefaultBuilder->buildResultSet($elasticaResponse, $elasticaQuery);
    }

    /**
     * @param array $searchResult
     *
     * @return array
     */
    protected function mapSearchResultToElasticaResponseArray(array $searchResult): array
    {
        $elasticaResponseArray = [];
        $elasticaResponseArray[static::KEY_HITS] = $this->mapElasticaHits($searchResult);
        $elasticaResponseArray[static::KEY_SORT_ITEMS] = $this->mapSortItems($searchResult);
        $elasticaResponseArray[static::KEY_FACETS] = $this->mapFacets($searchResult);

        return $elasticaResponseArray;
    }

    /**
     * @param array $searchResult
     *
     * @return array
     */
    protected function mapElasticaHits(array $searchResult): array
    {

        $total = $searchResult[static::KEY_TOTAL_HITS];
        $maxScore = max($searchResult[static::KEY_SCORE_FIRST_HIT], $searchResult[static::KEY_SCORE_LAST_HIT]);
        $elasticaHits = [];
        foreach ($searchResult[static::KEY_HITS] as $searchHit) {
            if (!count($searchHit[static::KEY_VARIANT_VALUES])) {
                continue;
            }

            $productAbstract = $this->productStorageClient
                ->findProductAbstractStorageDataByMapping(
                    static::SKU_MAPPING_TYPE,
                    $searchHit[static::KEY_OPTION_ID],
                    $this->currentLocale
                );
            if ($productAbstract === null) {
                continue;
            }
            $productAbstractImageStorageTransfer = $this->productImageStorageClient
                ->findProductImageAbstractStorageTransfer(
                    $productAbstract[static::KEY_ID_PRODUCT_ABSTRACT],
                    $this->currentLocale
                );

            $elasticaImages = $this->mapElasticaImages($productAbstractImageStorageTransfer);
            $elasticaImages = $this->mapElasticaImages(/** @scrutinizer ignore-type */ $productAbstractImageStorageTransfer);
            $elasticaPrices = $this->mapElasticaPrices($productAbstract);

            $elasticaHit = [
                static::KEY_INDEX => $this->currentLocale . static::KEY_SEARCH,
                static::KEY_TYPE => static::KEY_PAGE,
                static::KEY_ID => $productAbstract[static::KEY_ID_PRODUCT_ABSTRACT],
                static::KEY_SCORE => $searchHit[static::KEY_SCORE],
                static::KEY_SOURCE =>
                    [
                        static::KEY_SEARCH_RESULT_DATA =>
                            [
                                static::KEY_IMAGES => $elasticaImages,
                                static::KEY_ID_PRODUCT_LABELS => [],
                                static::KEY_PRICE => 0,
                                static::KEY_ABSTRACT_NAME => $productAbstract[static::KEY_NAME],
                                static::KEY_ID_PRODUCT_ABSTRACT => $productAbstract[static::KEY_ID_PRODUCT_ABSTRACT],
                                static::KEY_OPTION_TYPE => static::KEY_PRODUCT_ABSTRACT,
                                static::KEY_PRICES => $elasticaPrices,
                                static::KEY_ABSTRACT_SKU => $productAbstract[static::KEY_SKU],
                                static::KEY_URL => $productAbstract[static::KEY_URL],
                            ],
                    ],
            ];

            $elasticaHits[] = $elasticaHit;
        }

        return [
            static::KEY_TOTAL => $total,
            static::KEY_MAX_SCORE => $maxScore,
            static::KEY_HITS => $elasticaHits,
        ];
    }

    /**
     * @param array $searchResult
     *
     * @return array
     */
    protected function mapSortItems(array $searchResult): array
    {
        return $searchResult[static::KEY_SORT_ITEMS] ?? [];
    }

    /**
     * @param array $searchResult
     *
     * @return array
     */
    protected function mapFacets(array $searchResult): array
    {
        return $searchResult[static::KEY_FACETS] ?? [];
    }
}

spryker-eco / fact-finder-ng

Push — feature/eco-3192/fact-finder-n... ( 3e466e...3cb71a )

mapElasticaHits() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
