CrefoPayUniqueIdGenerator::__construct() - Code Metrics - Inspection of "SUPESC-227: Updated tests" - spryker-eco/crefo-pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — bugfix/supesc-227-extend-the-c... ( e01b47 )

by Oleh

created 2021-03-16 07:07 UTC

CrefoPayUniqueIdGenerator::__construct() A

↳ Parent: CrefoPayUniqueIdGenerator

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Service\CrefoPay\Generator;

use Generated\Shared\Transfer\QuoteTransfer;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Service\CrefoPay\Dependency\Service\CrefoPayToUtilTextServiceInterface;

class CrefoPayUniqueIdGenerator implements CrefoPayUniqueIdGeneratorInterface
{
    /**
     * @var SprykerEco\Service\CrefoPay\Dependency\Service\CrefoPayToUtilTextServiceInterface $crefoPayUniqueIdGeneratorBridge

     */
    protected $crefoPayToUtilTextServiceBridge;

    /**
     * CrefoPayUniqueIdGenerator constructor.
     *
     * @param SprykerEco\Service\CrefoPay\Dependency\Service\CrefoPayToUtilTextServiceInterface $crefoPayUniqueIdGeneratorBridge
     */
    public function __construct(CrefoPayToUtilTextServiceInterface $crefoPayToUtilTextServiceBridge)
    {
        $this->crefoPayToUtilTextServiceBridge = $crefoPayToUtilTextServiceBridge;

    }

    /**
     * @deprecated Use {@link generateCrefoPayOrderIdIndependent()} instead.
     *
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return string
     */
    public function generateCrefoPayOrderId(QuoteTransfer $quoteTransfer): string
    {
        return uniqid($quoteTransfer->getCustomerReference() . '-', true);
    }

    /**
     * @return string
     */
    public function generateCrefoPayOrderIdIndependent(): string
    {
        return $this->crefoPayToUtilTextServiceBridge->generateRandomString(30);
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* For full license information, please view the LICENSE file that was distributed with this source code.
6			*/
7
8			namespace SprykerEco\Service\CrefoPay\Generator;
9
10			use Generated\Shared\Transfer\QuoteTransfer;
			0 ignored issues – show Bug introduced 2019-03-04 12:32 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\QuoteTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use SprykerEco\Service\CrefoPay\Dependency\Service\CrefoPayToUtilTextServiceInterface;
12
13			class CrefoPayUniqueIdGenerator implements CrefoPayUniqueIdGeneratorInterface
14			{
15			/**
16			* @var SprykerEco\Service\CrefoPay\Dependency\Service\CrefoPayToUtilTextServiceInterface $crefoPayUniqueIdGeneratorBridge
			0 ignored issues – show Bug introduced 2021-03-15 07:32 UTC by Report Bug Copy Issue Report The type `SprykerEco\Service\Crefo...tilTextServiceInterface` was not found. Did you mean `SprykerEco\Service\Crefo...tilTextServiceInterface`? If so, make sure to prefix the type with `\`. Loading history...
17			*/
18			protected $crefoPayToUtilTextServiceBridge;
19
20			/**
21			* CrefoPayUniqueIdGenerator constructor.
22			*
23			* @param SprykerEco\Service\CrefoPay\Dependency\Service\CrefoPayToUtilTextServiceInterface $crefoPayUniqueIdGeneratorBridge
24			*/
25			public function __construct(CrefoPayToUtilTextServiceInterface $crefoPayToUtilTextServiceBridge)
26			{
27			$this->crefoPayToUtilTextServiceBridge = $crefoPayToUtilTextServiceBridge;
			0 ignored issues – show Documentation Bug introduced 2021-03-15 07:32 UTC by Report Bug Copy Issue Report It seems like `$crefoPayToUtilTextServiceBridge` of type `SprykerEco\Service\Crefo...tilTextServiceInterface` is incompatible with the declared type `SprykerEco\Service\Crefo...tilTextServiceInterface` of property `$crefoPayToUtilTextServiceBridge`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
28			}
29
30			/**
31			* @deprecated Use {@link generateCrefoPayOrderIdIndependent()} instead.
32			*
33			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
34			*
35			* @return string
36			*/
37			public function generateCrefoPayOrderId(QuoteTransfer $quoteTransfer): string
38			{
39			return uniqid($quoteTransfer->getCustomerReference() . '-', true);
40			}
41
42			/**
43			* @return string
44			*/
45			public function generateCrefoPayOrderIdIndependent(): string
46			{
47			return $this->crefoPayToUtilTextServiceBridge->generateRandomString(30);
48			}
49			}
50

spryker-eco / crefo-pay

Push — bugfix/supesc-227-extend-the-c... ( e01b47 )

CrefoPayUniqueIdGenerator::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like