SprykerEco\Zed\CrefoPayApi\Business\Converter\AbstractConverter

Complexity

Total Complexity

9

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createResponseTransferWithError()	0	9	1
A	convertToResponseTransfer()	0	14	3
A	__construct()	0	4	1
A	createSuccessResponseTransfer()	0	4	1
A	isResultCodeSuccess()	0	5	3

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Zed\CrefoPayApi\Business\Converter;

use Generated\Shared\Transfer\CrefoPayApiErrorResponseTransfer;

The type Generated\Shared\Transfer\CrefoPayApiErrorResponseTransfer was not found. Maybe you did not declare it correctly or list all dependencies?

use Generated\Shared\Transfer\CrefoPayApiResponseTransfer;

The type Generated\Shared\Transfer\CrefoPayApiResponseTransfer was not found. Maybe you did not declare it correctly or list all dependencies?

use Psr\Http\Message\ResponseInterface;

The type Psr\Http\Message\ResponseInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use SprykerEco\Shared\CrefoPayApi\CrefoPayApiConfig;
use SprykerEco\Zed\CrefoPayApi\Dependency\Service\CrefoPayApiToUtilEncodingServiceInterface;

abstract class AbstractConverter implements CrefoPayApiConverterInterface
{
    /**
     * @var \SprykerEco\Zed\CrefoPayApi\Dependency\Service\CrefoPayApiToUtilEncodingServiceInterface
     */
    protected $encodingService;

    /**
     * @param \Generated\Shared\Transfer\CrefoPayApiResponseTransfer $responseTransfer
     * @param array $responseData
     *
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    abstract protected function updateResponseTransferWithApiCallResponse(
        CrefoPayApiResponseTransfer $responseTransfer,
        array $responseData
    ): CrefoPayApiResponseTransfer;

    /**
     * @param \SprykerEco\Zed\CrefoPayApi\Dependency\Service\CrefoPayApiToUtilEncodingServiceInterface $encodingService
     */
    public function __construct(
        CrefoPayApiToUtilEncodingServiceInterface $encodingService
    ) {
        $this->encodingService = $encodingService;
    }

    /**
     * @param \Psr\Http\Message\ResponseInterface $response
     * @param bool $isSuccess
     *
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    public function convertToResponseTransfer(
        ResponseInterface $response,
        bool $isSuccess = true
    ): CrefoPayApiResponseTransfer {
        $responseData = $this->encodingService->decodeJson($response->getBody(), true);

        if (!$isSuccess || !$this->isResultCodeSuccess($responseData)) {

It seems like $responseData can also be of type null; however, parameter $responseData of SprykerEco\Zed\CrefoPayApi\Business\Converter\AbstractConverter::isResultCodeSuccess() does only seem to accept array, maybe add an additional type check?

            return $this->createResponseTransferWithError($responseData);

It seems like $responseData can also be of type null; however, parameter $responseData of SprykerEco\Zed\CrefoPayApi\Business\Converter\AbstractConverter::createResponseTransferWithError() does only seem to accept array, maybe add an additional type check?

        }

        $responseTransfer = $this->createSuccessResponseTransfer();
        $responseTransfer = $this->updateResponseTransferWithApiCallResponse($responseTransfer, $responseData);

It seems like $responseData can also be of type null; however, parameter $responseData of SprykerEco\Zed\CrefoPayApi\Business\Converter\AbstractConverter::updateResponseTransferWithApiCallResponse() does only seem to accept array, maybe add an additional type check?

        return $responseTransfer;
    }

    /**
     * @param array $responseData
     *
     * @return bool
     */
    protected function isResultCodeSuccess(array $responseData): bool
    {
        $resultCode = $responseData[CrefoPayApiConfig::API_RESPONSE_FIELD_RESULT_CODE];

        return isset($resultCode) && ($resultCode === 0 || $resultCode === 1);
    }

    /**
     * @param array $responseData
     *
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    protected function createResponseTransferWithError(array $responseData): CrefoPayApiResponseTransfer
    {
        $errorTransfer = (new CrefoPayApiErrorResponseTransfer())
            ->fromArray($responseData, true)
            ->setErrorType(CrefoPayApiConfig::API_ERROR_TYPE_EXTERNAL);

        return (new CrefoPayApiResponseTransfer())
            ->setIsSuccess(false)
            ->setError($errorTransfer);
    }

    /**
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    protected function createSuccessResponseTransfer(): CrefoPayApiResponseTransfer
    {
        return (new CrefoPayApiResponseTransfer())
            ->setIsSuccess(true);
    }
}