SprykerEco\Zed\CrefoPayApi\Business\Response\Converter\CrefoPayApiResponseConverter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	updateResponseTransferWithError()	0	15	2
A	createResponseTransfer()	0	4	1
A	__construct()	0	8	1
A	convertToResponseTransfer()	0	13	3

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Zed\CrefoPayApi\Business\Response\Converter;

use Generated\Shared\Transfer\CrefoPayApiErrorResponseTransfer;

The type Generated\Shared\Transfer\CrefoPayApiErrorResponseTransfer was not found. Maybe you did not declare it correctly or list all dependencies?

use Generated\Shared\Transfer\CrefoPayApiResponseTransfer;

The type Generated\Shared\Transfer\CrefoPayApiResponseTransfer was not found. Maybe you did not declare it correctly or list all dependencies?

use SprykerEco\Zed\CrefoPayApi\Business\Response\Mapper\CrefoPayApiResponseMapperInterface;
use SprykerEco\Zed\CrefoPayApi\Business\Response\Validator\CrefoPayApiResponseValidatorInterface;
use SprykerEco\Zed\CrefoPayApi\Dependency\External\Guzzle\Response\CrefoPayApiGuzzleResponseInterface;
use SprykerEco\Zed\CrefoPayApi\Dependency\Service\CrefoPayApiToUtilEncodingServiceInterface;

class CrefoPayApiResponseConverter implements CrefoPayApiResponseConverterInterface
{
    protected const API_ERROR_TYPE_EXTERNAL = 'EXTERNAL';
    protected const EXTERNAL_ERROR_MESSAGE = 'CrefoPay service temporarily unavailable.';

    /**
     * @var \SprykerEco\Zed\CrefoPayApi\Dependency\Service\CrefoPayApiToUtilEncodingServiceInterface
     */
    protected $encodingService;

    /**
     * @var \SprykerEco\Zed\CrefoPayApi\Business\Response\Mapper\CrefoPayApiResponseMapperInterface
     */
    protected $responseMapper;

    /**
     * @var \SprykerEco\Zed\CrefoPayApi\Business\Response\Validator\CrefoPayApiResponseValidatorInterface
     */
    protected $responseValidator;

    /**
     * @param \SprykerEco\Zed\CrefoPayApi\Dependency\Service\CrefoPayApiToUtilEncodingServiceInterface $encodingService
     * @param \SprykerEco\Zed\CrefoPayApi\Business\Response\Mapper\CrefoPayApiResponseMapperInterface $responseMapper
     * @param \SprykerEco\Zed\CrefoPayApi\Business\Response\Validator\CrefoPayApiResponseValidatorInterface $responseValidator
     */
    public function __construct(
        CrefoPayApiToUtilEncodingServiceInterface $encodingService,
        CrefoPayApiResponseMapperInterface $responseMapper,
        CrefoPayApiResponseValidatorInterface $responseValidator
    ) {
        $this->encodingService = $encodingService;
        $this->responseMapper = $responseMapper;
        $this->responseValidator = $responseValidator;
    }

    /**
     * @param \SprykerEco\Zed\CrefoPayApi\Dependency\External\Guzzle\Response\CrefoPayApiGuzzleResponseInterface $response
     * @param bool $isSuccess
     *
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    public function convertToResponseTransfer(
        CrefoPayApiGuzzleResponseInterface $response,
        bool $isSuccess = true
    ): CrefoPayApiResponseTransfer {
        $responseData = $this->encodingService->decodeJson($response->getResponseBody(), true);
        $responseTransfer = $this->createResponseTransfer($isSuccess);

        if (!$isSuccess || !$this->responseValidator->validateResponse($response, $responseData)) {
            return $this->updateResponseTransferWithError($responseTransfer, $responseData);
        }

        return $this->responseMapper
            ->mapResponseDataToResponseTransfer($responseData, $responseTransfer);

It seems like $responseData can also be of type null; however, parameter $responseData of SprykerEco\Zed\CrefoPayApi\Business\Response\Mapper\CrefoPayApiResponseMapperInterface::mapResponseDataToResponseTransfer() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param \Generated\Shared\Transfer\CrefoPayApiResponseTransfer $responseTransfer
     * @param array|null $responseData
     *
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    protected function updateResponseTransferWithError(
        CrefoPayApiResponseTransfer $responseTransfer,
        ?array $responseData
    ): CrefoPayApiResponseTransfer {
        $errorTransfer = (new CrefoPayApiErrorResponseTransfer())
            ->setMessage(static::EXTERNAL_ERROR_MESSAGE)
            ->setErrorType(static::API_ERROR_TYPE_EXTERNAL);

        if ($responseData !== null) {

The condition $responseData !== null is always true.

            $errorTransfer->fromArray($responseData, true);
        }

        return $responseTransfer
            ->setIsSuccess(false)
            ->setError($errorTransfer);
    }

    /**
     * @param bool $isSuccess
     *
     * @return \Generated\Shared\Transfer\CrefoPayApiResponseTransfer
     */
    protected function createResponseTransfer(bool $isSuccess): CrefoPayApiResponseTransfer
    {
        return (new CrefoPayApiResponseTransfer())
            ->setIsSuccess($isSuccess);
    }
}