CrefoPayApiClient::performRequest() - Code Metrics - Inspection of "ECO-2346: Add general API client structure." - spryker-eco/crefo-pay-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/eco-2295/eco-2344-crea... ( 1e5ae0...217e63 )

by Aleksey

created 2018-12-28 11:28 UTC

CrefoPayApiClient::performRequest() A

↳ Parent: CrefoPayApiClient

Complexity

Conditions	3
Paths	5

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	11
dl	0
loc	18
rs	9.9
c	0
b	0
f	0
cc	3
nc	5
nop	1

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Zed\CrefoPayApi\Business\Client;

use Generated\Shared\Transfer\CrefoPayApiRequestTransfer;
filter:
    dependency_paths: ["lib/*"]
use Generated\Shared\Transfer\CrefoPayApiResponseTransfer;
filter:
    dependency_paths: ["lib/*"]
use GuzzleHttp\Exception\RequestException;
filter:
    dependency_paths: ["lib/*"]
use Spryker\Shared\Kernel\Transfer\Exception\RequiredTransferPropertyException;
filter:
    dependency_paths: ["lib/*"]

class CrefoPayApiClient implements CrefoPayApiClientInterface
{
    /**
     * @var \GuzzleHttp\ClientInterface
filter:
    dependency_paths: ["lib/*"]
     */
    protected $client;

    /**
     * @var \SprykerEco\Zed\CrefoPayApi\Business\Request\CrefoPayApiRequestInterface
     */
    protected $request;

    /**
     * @var \SprykerEco\Zed\CrefoPayApi\Business\Converter\CrefoPayApiConverterInterface
     */
    protected $converter;

    public function performRequest(CrefoPayApiRequestTransfer $requestTransfer): CrefoPayApiResponseTransfer
    {
        $method = $this->getMethod();

        try {
            /** @var \Psr\Http\Message\ResponseInterface $response */
            $response = $this->client->$method(
                $this->request->getUrl(),
                $this->request->getRequestOptions($requestTransfer)
            );

            return $this->converter->convertToResponseTransfer($response);

        } catch (RequestException $requestException) {
            $response = $requestException->getResponse();

            return;

        } catch (RequiredTransferPropertyException $requiredTransferPropertyException) {
            return;

        }
    }

    /**
     * @return string
     */
    protected function getMethod(): string
    {
        return strtolower($this->request->getHttpMethod());
    }
}

1			<?php
2
3			/**
4			* MIT License
5			* For full license information, please view the LICENSE file that was distributed with this source code.
6			*/
7
8			namespace SprykerEco\Zed\CrefoPayApi\Business\Client;
9
10			use Generated\Shared\Transfer\CrefoPayApiRequestTransfer;
			0 ignored issues – show Bug introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfe...foPayApiRequestTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Generated\Shared\Transfer\CrefoPayApiResponseTransfer;
			0 ignored issues – show Bug introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfe...oPayApiResponseTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use GuzzleHttp\Exception\RequestException;
			0 ignored issues – show Bug introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The type `GuzzleHttp\Exception\RequestException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13			use Spryker\Shared\Kernel\Transfer\Exception\RequiredTransferPropertyException;
			0 ignored issues – show Bug introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The type `Spryker\Shared\Kernel\Tr...ansferPropertyException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
14
15			class CrefoPayApiClient implements CrefoPayApiClientInterface
16			{
17			/**
18			* @var \GuzzleHttp\ClientInterface
			0 ignored issues – show Bug introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The type `GuzzleHttp\ClientInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
19			*/
20			protected $client;
21
22			/**
23			* @var \SprykerEco\Zed\CrefoPayApi\Business\Request\CrefoPayApiRequestInterface
24			*/
25			protected $request;
26
27			/**
28			* @var \SprykerEco\Zed\CrefoPayApi\Business\Converter\CrefoPayApiConverterInterface
29			*/
30			protected $converter;
31
32			public function performRequest(CrefoPayApiRequestTransfer $requestTransfer): CrefoPayApiResponseTransfer
33			{
34			$method = $this->getMethod();
35
36			try {
37			/** @var \Psr\Http\Message\ResponseInterface $response */
38			$response = $this->client->$method(
39			$this->request->getUrl(),
40			$this->request->getRequestOptions($requestTransfer)
41			);
42
43			return $this->converter->convertToResponseTransfer($response);
44
45			} catch (RequestException $requestException) {
46			$response = $requestException->getResponse();
			0 ignored issues – show Unused Code introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The assignment to `$response` is dead and can be removed. Loading history...
47			return;
			0 ignored issues – show Bug Best Practice introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The expression `return` returns the type `null` which is incompatible with the type-hinted return `Generated\Shared\Transfe...oPayApiResponseTransfer`. Loading history...
48			} catch (RequiredTransferPropertyException $requiredTransferPropertyException) {
49			return;
			0 ignored issues – show Bug Best Practice introduced 2018-12-28 11:29 UTC by Report Bug Copy Issue Report The expression `return` returns the type `null` which is incompatible with the type-hinted return `Generated\Shared\Transfe...oPayApiResponseTransfer`. Loading history...
50			}
51			}
52
53			/**
54			* @return string
55			*/
56			protected function getMethod(): string
57			{
58			return strtolower($this->request->getHttpMethod());
59			}
60			}

spryker-eco / crefo-pay-api

Push — feature/eco-2295/eco-2344-crea... ( 1e5ae0...217e63 )

CrefoPayApiClient::performRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like