ComputopPayPalExpressPaymentHandler::addPaymentToQuote() - Code Metrics - Inspection of "ECO-3658: Enable PayPal Express" - spryker-eco/computop - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — feature/eco-3656/dev-paypal-ex... (#40)

unknown

created 2021-10-12 12:50 UTC

addPaymentToQuote() A

↳ Parent: ComputopPayPalExpressPaymentHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	6
c	2
b	0
f	0
dl	0
loc	12
rs	10
cc	2
nc	2
nop	2

<?php

/**
 * MIT License
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Yves\Computop\Handler\PostPlace;

use Generated\Shared\Transfer\ComputopPayPalExpressPaymentTransfer;
filter:
    dependency_paths: ["lib/*"]
use Generated\Shared\Transfer\QuoteTransfer;
filter:
    dependency_paths: ["lib/*"]
use Spryker\Shared\Kernel\Transfer\AbstractTransfer;

class ComputopPayPalExpressPaymentHandler extends AbstractPostPlacePaymentHandler
{
    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     * @param \Spryker\Shared\Kernel\Transfer\AbstractTransfer $responseTransfer
     *
     * @return \Generated\Shared\Transfer\QuoteTransfer
     */
    protected function addPaymentToQuote(QuoteTransfer $quoteTransfer, AbstractTransfer $responseTransfer): QuoteTransfer
    {
        if ($quoteTransfer->getPayment()->getComputopPayPalExpress() === null) {
            $computopTransfer = new ComputopPayPalExpressPaymentTransfer();
            $quoteTransfer->getPayment()->setComputopPayPalExpress($computopTransfer);
        }
        /** @var \Generated\Shared\Transfer\ComputopPayPalExpressInitResponseTransfer $responseTransfer */
        $quoteTransfer->getPayment()->getComputopPayPalExpress()->setPayPalExpressInitResponse(
            $responseTransfer
        );

        return $quoteTransfer;
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return \Generated\Shared\Transfer\QuoteTransfer
     */
    protected function saveInitResponse(QuoteTransfer $quoteTransfer): QuoteTransfer
    {
        return $this->computopClient->savePayPalExpressInitResponse($quoteTransfer);
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Yves\Computop\Handler\PostPlace;
9
10			use Generated\Shared\Transfer\ComputopPayPalExpressPaymentTransfer;
			0 ignored issues – show Bug introduced 2021-05-28 13:05 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfe...lExpressPaymentTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Generated\Shared\Transfer\QuoteTransfer;
			0 ignored issues – show Bug introduced 2021-07-12 15:31 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\QuoteTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use Spryker\Shared\Kernel\Transfer\AbstractTransfer;
13
14			class ComputopPayPalExpressPaymentHandler extends AbstractPostPlacePaymentHandler
15			{
16			/**
17			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
18			* @param \Spryker\Shared\Kernel\Transfer\AbstractTransfer $responseTransfer
19			*
20			* @return \Generated\Shared\Transfer\QuoteTransfer
21			*/
22			protected function addPaymentToQuote(QuoteTransfer $quoteTransfer, AbstractTransfer $responseTransfer): QuoteTransfer
23			{
24			if ($quoteTransfer->getPayment()->getComputopPayPalExpress() === null) {
25			$computopTransfer = new ComputopPayPalExpressPaymentTransfer();
26			$quoteTransfer->getPayment()->setComputopPayPalExpress($computopTransfer);
27			}
28			/** @var \Generated\Shared\Transfer\ComputopPayPalExpressInitResponseTransfer $responseTransfer */
29			$quoteTransfer->getPayment()->getComputopPayPalExpress()->setPayPalExpressInitResponse(
30			$responseTransfer
31			);
32
33			return $quoteTransfer;
34			}
35
36			/**
37			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
38			*
39			* @return \Generated\Shared\Transfer\QuoteTransfer
40			*/
41			protected function saveInitResponse(QuoteTransfer $quoteTransfer): QuoteTransfer
42			{
43			return $this->computopClient->savePayPalExpressInitResponse($quoteTransfer);
44			}
45			}
46

spryker-eco / computop

Pull Request — feature/eco-3656/dev-paypal-ex... (#40)

addPaymentToQuote() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like