ComputopQuoteDefaultShipmentExpander::expandQuoteWithDefaultShippingMethod() - Code Metrics - Inspection of "ECO-3658 Refactoring Quote default shipping method..." - spryker-eco/computop - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/eco-3656/eco-3658-enab... ( da021b...202423 )

unknown

created 2021-06-17 16:08 UTC

expandQuoteWithDefaultShippingMethod() A

↳ Parent: ComputopQuoteDefaultShipmentExpander

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	7
rs	10
cc	3
nc	2
nop	1

<?php

/**
 * MIT License
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Client\Computop;

use Generated\Shared\Transfer\QuoteTransfer;
filter:
    dependency_paths: ["lib/*"]

class ComputopQuoteDefaultShipmentExpander implements ComputopQuoteDefaultShipmentExpanderInterface
{
    /**
     * @var \SprykerEco\Client\Computop\ComputopClientInterface
     */
    protected $computopClient;

    /**
     * @param \SprykerEco\Client\Computop\ComputopClientInterface $computopClient
     */
    public function __construct(ComputopClientInterface $computopClient)
    {
        $this->computopClient = $computopClient;
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return \Generated\Shared\Transfer\QuoteTransfer
     */
    public function expandQuoteWithDefaultShippingMethod(QuoteTransfer $quoteTransfer): QuoteTransfer
    {
        if (count($quoteTransfer->getItems()) === 0 || $this->quoteAlreadyHasShipment($quoteTransfer)) {
            return $quoteTransfer;
        }

        return $this->computopClient->expandQuoteWithDefaultShippingMethod($quoteTransfer);
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return bool
     */
    protected function quoteAlreadyHasShipment(QuoteTransfer $quoteTransfer): bool
    {
        foreach ($quoteTransfer->getItems() as $itemTransfer) {
            $itemShipmentTransfer = $itemTransfer->getShipment();
            if ($itemShipmentTransfer !== null) {
                //at least one item already has shipment method
                return true;
            }
        }

        return false;
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Client\Computop;
9
10			use Generated\Shared\Transfer\QuoteTransfer;
			0 ignored issues – show Bug introduced 2021-06-17 16:13 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\QuoteTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11
12			class ComputopQuoteDefaultShipmentExpander implements ComputopQuoteDefaultShipmentExpanderInterface
13			{
14			/**
15			* @var \SprykerEco\Client\Computop\ComputopClientInterface
16			*/
17			protected $computopClient;
18
19			/**
20			* @param \SprykerEco\Client\Computop\ComputopClientInterface $computopClient
21			*/
22			public function __construct(ComputopClientInterface $computopClient)
23			{
24			$this->computopClient = $computopClient;
25			}
26
27			/**
28			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
29			*
30			* @return \Generated\Shared\Transfer\QuoteTransfer
31			*/
32			public function expandQuoteWithDefaultShippingMethod(QuoteTransfer $quoteTransfer): QuoteTransfer
33			{
34			if (count($quoteTransfer->getItems()) === 0 \|\| $this->quoteAlreadyHasShipment($quoteTransfer)) {
35			return $quoteTransfer;
36			}
37
38			return $this->computopClient->expandQuoteWithDefaultShippingMethod($quoteTransfer);
39			}
40
41			/**
42			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
43			*
44			* @return bool
45			*/
46			protected function quoteAlreadyHasShipment(QuoteTransfer $quoteTransfer): bool
47			{
48			foreach ($quoteTransfer->getItems() as $itemTransfer) {
49			$itemShipmentTransfer = $itemTransfer->getShipment();
50			if ($itemShipmentTransfer !== null) {
51			//at least one item already has shipment method
52			return true;
53			}
54			}
55
56			return false;
57			}
58			}
59

spryker-eco / computop

Push — feature/eco-3656/eco-3658-enab... ( da021b...202423 )

expandQuoteWithDefaultShippingMethod() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like