ComputopQuoteDefaultShipmentExpander::expandQuoteWithDefaultShippingMethod() - Code Metrics - Inspection of "ECO-3658: Enable PayPal Express" - spryker-eco/computop - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — feature/eco-3656/dev-paypal-ex... (#40)

by Andrey

created 2021-09-06 09:25 UTC

expandQuoteWithDefaultShippingMethod() A

↳ Parent: ComputopQuoteDefaultShipmentExpander

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	7
rs	10
cc	3
nc	2
nop	1

<?php

/**
 * MIT License
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Client\Computop;

use Generated\Shared\Transfer\QuoteTransfer;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Client\Computop\Zed\ComputopStubInterface;

class ComputopQuoteDefaultShipmentExpander implements ComputopQuoteDefaultShipmentExpanderInterface
{
    /**
     * @var \SprykerEco\Client\Computop\Zed\ComputopStubInterface $computopStub
     */
    protected $computopStub;

    /**
     * @param \SprykerEco\Client\Computop\Zed\ComputopStubInterface $computopStub
     */
    public function __construct(ComputopStubInterface $computopStub)
    {
        $this->computopStub = $computopStub;
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return \Generated\Shared\Transfer\QuoteTransfer
     */
    public function expandQuoteWithDefaultShippingMethod(QuoteTransfer $quoteTransfer): QuoteTransfer
    {
        if ($quoteTransfer->getItems()->count() === 0 || $this->isQuoteHasShipment($quoteTransfer)) {
            return $quoteTransfer;
        }

        return $this->computopStub->expandQuoteWithDefaultShippingMethod($quoteTransfer);
    }

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     *
     * @return bool
     */
    protected function isQuoteHasShipment(QuoteTransfer $quoteTransfer): bool
    {
        foreach ($quoteTransfer->getItems() as $itemTransfer) {
            $itemShipmentTransfer = $itemTransfer->getShipment();
            if ($itemShipmentTransfer !== null) {
                //at least one item already has shipment method
                return true;
            }
        }

        return false;
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Client\Computop;
9
10			use Generated\Shared\Transfer\QuoteTransfer;
			0 ignored issues – show Bug introduced 2021-06-17 16:13 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\QuoteTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use SprykerEco\Client\Computop\Zed\ComputopStubInterface;
12
13			class ComputopQuoteDefaultShipmentExpander implements ComputopQuoteDefaultShipmentExpanderInterface
14			{
15			/**
16			* @var \SprykerEco\Client\Computop\Zed\ComputopStubInterface $computopStub
17			*/
18			protected $computopStub;
19
20			/**
21			* @param \SprykerEco\Client\Computop\Zed\ComputopStubInterface $computopStub
22			*/
23			public function __construct(ComputopStubInterface $computopStub)
24			{
25			$this->computopStub = $computopStub;
26			}
27
28			/**
29			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
30			*
31			* @return \Generated\Shared\Transfer\QuoteTransfer
32			*/
33			public function expandQuoteWithDefaultShippingMethod(QuoteTransfer $quoteTransfer): QuoteTransfer
34			{
35			if ($quoteTransfer->getItems()->count() === 0 \|\| $this->isQuoteHasShipment($quoteTransfer)) {
36			return $quoteTransfer;
37			}
38
39			return $this->computopStub->expandQuoteWithDefaultShippingMethod($quoteTransfer);
40			}
41
42			/**
43			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
44			*
45			* @return bool
46			*/
47			protected function isQuoteHasShipment(QuoteTransfer $quoteTransfer): bool
48			{
49			foreach ($quoteTransfer->getItems() as $itemTransfer) {
50			$itemShipmentTransfer = $itemTransfer->getShipment();
51			if ($itemShipmentTransfer !== null) {
52			//at least one item already has shipment method
53			return true;
54			}
55			}
56
57			return false;
58			}
59			}
60

spryker-eco / computop

Pull Request — feature/eco-3656/dev-paypal-ex... (#40)

expandQuoteWithDefaultShippingMethod() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like