SprykerEco\Yves\Computop\Controller\ExpressCheckoutController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	placeOrderPayPalExpressAction()	0	7	1
A	preparePayPalExpressAction()	0	16	1
A	completeOrderPayPalExpressAction()	0	8	1

<?php

/**
 * MIT License
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Yves\Computop\Controller;

use Spryker\Yves\Kernel\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;

/**
 * @method \SprykerEco\Yves\Computop\ComputopFactory getFactory()
 * @method \SprykerEco\Client\Computop\ComputopClientInterface getClient()
 */
class ExpressCheckoutController extends AbstractController
{
    /**
     * @uses CheckoutPageRouteProviderPlugin::ROUTE_NAME_CHECKOUT_PLACE_ORDER
     */
    protected const ROUTE_NAME_CHECKOUT_PLACE_ORDER = 'checkout-place-order';

    /**
     * @uses CheckoutPageRouteProviderPlugin::ROUTE_NAME_CHECKOUT_SUCCESS
     */
    protected const ROUTE_NAME_CHECKOUT_SUCCESS = 'checkout-success';

    /**
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function preparePayPalExpressAction(): JsonResponse
    {
        $quoteTransfer = $this->getFactory()->getQuoteClient()->getQuote();
        $payPalExpressPrepareHandler = $this->getFactory()->createComputopPayPalExpressPrepareHandler();
        $computopApiPayPalExpressPrepareResponseTransfer = $payPalExpressPrepareHandler->handle($quoteTransfer);

The assignment to $computopApiPayPalExpressPrepareResponseTransfer is dead and can be removed.

//        return new JsonResponse([
//            'orderId' => $computopApiPayPalExpressPrepareResponseTransfer->getOrderId(),
//            'merchantId' => $computopApiPayPalExpressPrepareResponseTransfer->getMid(),
//            'payId' => $computopApiPayPalExpressPrepareResponseTransfer->getPayID()
//        ]);

        return new JsonResponse([
            'orderId' => '1MB40413MG869772K',
            'merchantId' => 'spryker_test',
            'payId' => 'f3a0268fd98e4989938903c9c0e8760e',
        ]);
    }

    /**
     * @param \Symfony\Component\HttpFoundation\Request $request
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function placeOrderPayPalExpressAction(Request $request): RedirectResponse
    {
        $quoteTransfer = $this->getFactory()->getQuoteClient()->getQuote();
        $payPalExpressInitHandler = $this->getFactory()->createComputopPayPalExpressInitHandler();
        $payPalExpressInitHandler->handle($quoteTransfer, $request->query->all());

        return $this->redirectResponseInternal(static::ROUTE_NAME_CHECKOUT_PLACE_ORDER);
    }

    /**
     * @param \Symfony\Component\HttpFoundation\Request $request
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function completeOrderPayPalExpressAction(Request $request): RedirectResponse

The parameter $request is not used and could be removed.

    {
        $quoteTransfer = $this->getFactory()->getQuoteClient()->getQuote();
        $payPalExpressCompleteHandler = $this->getFactory()->createComputopPayPalExpressCompleteHandler();

        $payPalExpressCompleteHandler->handle($quoteTransfer);

        return $this->redirectResponseInternal(static::ROUTE_NAME_CHECKOUT_SUCCESS);
    }
}