AuthorizePlugin   A
last analyzed

Complexity

Total Complexity 1

Size/Duplication

Total Lines 21
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
wmc 1
eloc 5
dl 0
loc 21
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A run() 0 7 1
1
<?php
2
3
/**
4
 * MIT License
5
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6
 */
7
8
namespace SprykerEco\Zed\Computop\Communication\Plugin\Oms\Command;
9
10
use Orm\Zed\Sales\Persistence\SpySalesOrder;
0 ignored issues
show
Bug introduced by
The type Orm\Zed\Sales\Persistence\SpySalesOrder was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
11
use Spryker\Zed\Oms\Business\Util\ReadOnlyArrayObject;
12
use Spryker\Zed\Oms\Dependency\Plugin\Command\CommandByOrderInterface;
13
14
/**
15
 * @method \SprykerEco\Zed\Computop\Business\ComputopFacadeInterface getFacade()
16
 */
17
class AuthorizePlugin extends AbstractComputopPlugin implements CommandByOrderInterface
18
{
19
    /**
20
     * {@inheritDoc}
21
     *  - Executes Authorize command and performs Authorize API call.
22
     *
23
     * @api
24
     *
25
     * @param \Orm\Zed\Sales\Persistence\SpySalesOrderItem[] $orderItems
26
     * @param \Orm\Zed\Sales\Persistence\SpySalesOrder $orderEntity
27
     * @param \Spryker\Zed\Oms\Business\Util\ReadOnlyArrayObject $data
28
     *
29
     * @return \Spryker\Shared\Kernel\Transfer\TransferInterface
30
     */
31
    public function run(array $orderItems, SpySalesOrder $orderEntity, ReadOnlyArrayObject $data)
32
    {
33
        $orderTransfer = $this->getOrderTransfer($orderEntity);
34
35
        return $this
0 ignored issues
show
Bug Best Practice introduced by
The expression return $this->getFacade(...rItems, $orderTransfer) returns the type Spryker\Shared\Kernel\Transfer\TransferInterface which is incompatible with the return type mandated by Spryker\Zed\Oms\Dependen...ByOrderInterface::run() of array.

In the issue above, the returned value is violating the contract defined by the mentioned interface.

Let's take a look at an example:

interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
Loading history...
36
            ->getFacade()
37
            ->authorizeCommandHandle($orderItems, $orderTransfer);
38
    }
39
}
40