PaypalExpressControllerProvider - Code Metrics - Inspection of "Feature/paypal express" - spryker-eco/braintree - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Volodymyr

created 2019-05-13 12:49 UTC

PaypalExpressControllerProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	20
dl	0
loc	52
rs	10
c	0
b	0
f	0
wmc	3

3 Methods

Rating	Name	Size	Complexity
A	defineControllers()	6	1
A	addPaypalExpressSuccessResponseRoute()	11	1
A	addPaypalExpressAddShipmentRoute()	11	1

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Yves\Braintree\Plugin\Provider;

use Silex\Application;
use SprykerShop\Yves\ShopApplication\Plugin\Provider\AbstractYvesControllerProvider;

class PaypalExpressControllerProvider extends AbstractYvesControllerProvider
{
    public const ROUTE_PAYPAL_EXPRESS_SUCCESS_RESPONSE = 'paypal-express-success';
    public const ROUTE_PAYPAL_EXPRESS_SHIPMENT_ADD = 'paypal-express-shipment-add';

    /**
     * @param \Silex\Application $app
     *
     * @return $this
     */
    protected function defineControllers(Application $app)
    {
        $this->addPaypalExpressSuccessResponseRoute();
        $this->addPaypalExpressAddShipmentRoute();

        return $this;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * @uses \SprykerEco\Yves\Braintree\Controller\PaypalExpressController::successAction()
     *
     * @return $this
     */
    protected function addPaypalExpressSuccessResponseRoute()
    {
        $this->createController(
            '/paypal-express/payment/success',
            static::ROUTE_PAYPAL_EXPRESS_SUCCESS_RESPONSE,
            'Braintree',
            'PaypalExpress',
            'success'
        );

        return $this;
    }

    /**
     * @uses \SprykerEco\Yves\Braintree\Controller\PaypalExpressController::successAction()
     *
     * @return $this
     */
    protected function addPaypalExpressAddShipmentRoute()
    {
        $this->createPostController(
            '/paypal-express/shipment/add',
            static::ROUTE_PAYPAL_EXPRESS_SHIPMENT_ADD,
            'Braintree',
            'PaypalExpress',
            'addShipment'
        );

        return $this;
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* For full license information, please view the LICENSE file that was distributed with this source code.
6			*/
7
8			namespace SprykerEco\Yves\Braintree\Plugin\Provider;
9
10			use Silex\Application;
11			use SprykerShop\Yves\ShopApplication\Plugin\Provider\AbstractYvesControllerProvider;
12
13			class PaypalExpressControllerProvider extends AbstractYvesControllerProvider
14			{
15			public const ROUTE_PAYPAL_EXPRESS_SUCCESS_RESPONSE = 'paypal-express-success';
16			public const ROUTE_PAYPAL_EXPRESS_SHIPMENT_ADD = 'paypal-express-shipment-add';
17
18			/**
19			* @param \Silex\Application $app
20			*
21			* @return $this
22			*/
23			protected function defineControllers(Application $app)
24			{
25			$this->addPaypalExpressSuccessResponseRoute();
26			$this->addPaypalExpressAddShipmentRoute();
27
28			return $this;
			0 ignored issues – show Bug Best Practice introduced 2019-05-07 09:04 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `SprykerEco\Yves\Braintre...pressControllerProvider` which is incompatible with the return type mandated by `Spryker\Yves\Application...er::defineControllers()` of `void`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
29			}
30
31			/**
32			* @uses \SprykerEco\Yves\Braintree\Controller\PaypalExpressController::successAction()
33			*
34			* @return $this
35			*/
36			protected function addPaypalExpressSuccessResponseRoute()
37			{
38			$this->createController(
39			'/paypal-express/payment/success',
40			static::ROUTE_PAYPAL_EXPRESS_SUCCESS_RESPONSE,
41			'Braintree',
42			'PaypalExpress',
43			'success'
44			);
45
46			return $this;
47			}
48
49			/**
50			* @uses \SprykerEco\Yves\Braintree\Controller\PaypalExpressController::successAction()
51			*
52			* @return $this
53			*/
54			protected function addPaypalExpressAddShipmentRoute()
55			{
56			$this->createPostController(
57			'/paypal-express/shipment/add',
58			static::ROUTE_PAYPAL_EXPRESS_SHIPMENT_ADD,
59			'Braintree',
60			'PaypalExpress',
61			'addShipment'
62			);
63
64			return $this;
65			}
66			}
67

spryker-eco / braintree

Pull Request — master (#9)

PaypalExpressControllerProvider A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like