CheckoutPaymentChecker::isQuotePaymentValid() - Code Metrics - Inspection of "ECO-3539 [Braintree] Fixed "payment_method_nonce m..." - spryker-eco/braintree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Roman

created 2021-03-30 13:25 UTC

CheckoutPaymentChecker::isQuotePaymentValid() A

↳ Parent: CheckoutPaymentChecker

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	14
nc	3
nop	2
dl	0
loc	23
rs	9.7998
c	1
b	0
f	0

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Zed\Braintree\Business\Checkout;

use Generated\Shared\Transfer\CheckoutErrorTransfer;
filter:
    dependency_paths: ["lib/*"]
use Generated\Shared\Transfer\CheckoutResponseTransfer;
filter:
    dependency_paths: ["lib/*"]
use Generated\Shared\Transfer\QuoteTransfer;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Shared\Braintree\BraintreeConfig;

class CheckoutPaymentChecker implements CheckoutPaymentCheckerInterface
{
    protected const ERROR_MESSAGE_INVALID_PARAMETER_NONCE = 'Parameter `NONCE` is invalid.';

    /**
     * @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
     * @param \Generated\Shared\Transfer\CheckoutResponseTransfer $checkoutResponseTransfer
     *
     * @return bool
     */
    public function isQuotePaymentValid(
        QuoteTransfer $quoteTransfer,
        CheckoutResponseTransfer $checkoutResponseTransfer
    ): bool {
        $paymentTransfer = $quoteTransfer
            ->requirePayment()
            ->getPayment();
        if ($paymentTransfer->getPaymentProvider() !== BraintreeConfig::PROVIDER_NAME) {
            return true;
        }

        $braintreePaymentTransfer = $paymentTransfer
            ->requireBraintree()
            ->getBraintree();
        if (!$braintreePaymentTransfer->getNonce()) {
            $checkoutResponseTransfer
                ->setIsSuccess(false)
                ->addError($this->createCheckoutErrorTransfer());

            return false;
        }

        return true;
    }

    /**
     * @return \Generated\Shared\Transfer\CheckoutErrorTransfer
     */
    protected function createCheckoutErrorTransfer(): CheckoutErrorTransfer
    {
        return (new CheckoutErrorTransfer())
            ->setMessage(static::ERROR_MESSAGE_INVALID_PARAMETER_NONCE);
    }
}


1			<?php
2
3			/**
4			* MIT License
5			* For full license information, please view the LICENSE file that was distributed with this source code.
6			*/
7
8			namespace SprykerEco\Zed\Braintree\Business\Checkout;
9
10			use Generated\Shared\Transfer\CheckoutErrorTransfer;
			0 ignored issues – show Bug introduced 2020-08-20 10:20 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\CheckoutErrorTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Generated\Shared\Transfer\CheckoutResponseTransfer;
			0 ignored issues – show Bug introduced 2020-09-21 18:55 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\CheckoutResponseTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use Generated\Shared\Transfer\QuoteTransfer;
			0 ignored issues – show Bug introduced 2020-08-20 10:20 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\QuoteTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13			use SprykerEco\Shared\Braintree\BraintreeConfig;
14
15			class CheckoutPaymentChecker implements CheckoutPaymentCheckerInterface
16			{
17			protected const ERROR_MESSAGE_INVALID_PARAMETER_NONCE = 'Parameter `NONCE` is invalid.';
18
19			/**
20			* @param \Generated\Shared\Transfer\QuoteTransfer $quoteTransfer
21			* @param \Generated\Shared\Transfer\CheckoutResponseTransfer $checkoutResponseTransfer
22			*
23			* @return bool
24			*/
25			public function isQuotePaymentValid(
26			QuoteTransfer $quoteTransfer,
27			CheckoutResponseTransfer $checkoutResponseTransfer
28			): bool {
29			$paymentTransfer = $quoteTransfer
30			->requirePayment()
31			->getPayment();
32			if ($paymentTransfer->getPaymentProvider() !== BraintreeConfig::PROVIDER_NAME) {
33			return true;
34			}
35
36			$braintreePaymentTransfer = $paymentTransfer
37			->requireBraintree()
38			->getBraintree();
39			if (!$braintreePaymentTransfer->getNonce()) {
40			$checkoutResponseTransfer
41			->setIsSuccess(false)
42			->addError($this->createCheckoutErrorTransfer());
43
44			return false;
45			}
46
47			return true;
48			}
49
50			/**
51			* @return \Generated\Shared\Transfer\CheckoutErrorTransfer
52			*/
53			protected function createCheckoutErrorTransfer(): CheckoutErrorTransfer
54			{
55			return (new CheckoutErrorTransfer())
56			->setMessage(static::ERROR_MESSAGE_INVALID_PARAMETER_NONCE);
57			}
58			}
59

spryker-eco / braintree

Pull Request — master (#34)

CheckoutPaymentChecker::isQuotePaymentValid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like