ObtainProfileInformationAdapter - Code Metrics - Inspection of "Feature/eco 807 travis ci" - spryker-eco/amazon-pay - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Andrey

created 2017-10-12 12:37 UTC

ObtainProfileInformationAdapter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

Metric	Value
dl	0
loc	39
rs	10
c	0
b	0
f	0
wmc	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	call()	0	9	1

<?php

/**
 * Apache OSL-2
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\Amazonpay\Business\Api\Adapter;

use Generated\Shared\Transfer\AmazonpayCallTransfer;
use PayWithAmazon\ClientInterface;
use SprykerEco\Zed\Amazonpay\Business\Api\Converter\ArrayConverterInterface;

class ObtainProfileInformationAdapter implements CallAdapterInterface
{

    /**
     * @var \PayWithAmazon\ClientInterface
     */
    protected $client;

    /**
     * @var \SprykerEco\Zed\Amazonpay\Business\Api\Converter\ArrayConverterInterface
     */
    protected $converter;

    /**
     * @param \PayWithAmazon\ClientInterface $client
     * @param \SprykerEco\Zed\Amazonpay\Business\Api\Converter\ArrayConverterInterface $converter
     */
    public function __construct(
        ClientInterface $client,
        ArrayConverterInterface $converter
    ) {
        $this->client = $client;
        $this->converter = $converter;
    }

    /**
     * @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonpayCallTransfer
     *
     * @return \Generated\Shared\Transfer\CustomerTransfer
     */
    public function call(AmazonpayCallTransfer $amazonpayCallTransfer)
    {
        $result = $this->client->getUserInfo($amazonpayCallTransfer->getAmazonpayPayment()->getAddressConsentToken());

        /** @var \Generated\Shared\Transfer\CustomerTransfer $customer */
        $customer = $this->converter->convert($result);
        $customer->setIsGuest(true);

        return $customer;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

}


1			<?php
2
3			/**
4			* Apache OSL-2
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\Amazonpay\Business\Api\Adapter;
9
10			use Generated\Shared\Transfer\AmazonpayCallTransfer;
11			use PayWithAmazon\ClientInterface;
12			use SprykerEco\Zed\Amazonpay\Business\Api\Converter\ArrayConverterInterface;
13
14			class ObtainProfileInformationAdapter implements CallAdapterInterface
15			{
16
17			/**
18			* @var \PayWithAmazon\ClientInterface
19			*/
20			protected $client;
21
22			/**
23			* @var \SprykerEco\Zed\Amazonpay\Business\Api\Converter\ArrayConverterInterface
24			*/
25			protected $converter;
26
27			/**
28			* @param \PayWithAmazon\ClientInterface $client
29			* @param \SprykerEco\Zed\Amazonpay\Business\Api\Converter\ArrayConverterInterface $converter
30			*/
31			public function __construct(
32			ClientInterface $client,
33			ArrayConverterInterface $converter
34			) {
35			$this->client = $client;
36			$this->converter = $converter;
37			}
38
39			/**
40			* @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonpayCallTransfer
41			*
42			* @return \Generated\Shared\Transfer\CustomerTransfer
43			*/
44			public function call(AmazonpayCallTransfer $amazonpayCallTransfer)
45			{
46			$result = $this->client->getUserInfo($amazonpayCallTransfer->getAmazonpayPayment()->getAddressConsentToken());
47
48			/** @var \Generated\Shared\Transfer\CustomerTransfer $customer */
49			$customer = $this->converter->convert($result);
50			$customer->setIsGuest(true);
51
52			return $customer;
			0 ignored issues – show Bug Best Practice introduced 2017-10-04 09:17 UTC by Report Bug Copy Issue Report The expression `return $customer` returns the type `Generated\Shared\Transfer\CustomerTransfer` which is incompatible with the return type mandated by `SprykerEco\Zed\Amazonpay...dapterInterface::call()` of `Generated\Shared\Transfe...azonpayResponseTransfer`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
53			}
54
55			}
56

spryker-eco / amazon-pay

Pull Request — master (#4)

ObtainProfileInformationAdapter A

Complexity

Size/Duplication

Importance

2 Methods

Duplication Side-by-Side

Filter issues like