spryker-eco /
amazon-pay
| Conditions | 9 |
| Paths | 21 |
| Total Lines | 53 |
| Code Lines | 28 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 26 | public function execute(OrderTransfer $orderTransfer) |
||
| 27 | { |
||
| 28 | $orderTransfer = parent::execute($orderTransfer); |
||
| 29 | |||
| 30 | $orderTransfer->getAmazonpayPayment()->setAuthorizationDetails( |
||
| 31 | $this->apiResponse->getAuthorizationDetails() |
||
| 32 | ); |
||
| 33 | |||
| 34 | if ($this->apiResponse->getHeader()->getIsSuccess()) { |
||
| 35 | if ($this->apiResponse->getAuthorizationDetails()->getIdList()) { |
||
| 36 | $this->paymentEntity->setAmazonCaptureId( |
||
| 37 | $this->apiResponse->getAuthorizationDetails()->getIdList() |
||
| 38 | ); |
||
| 39 | |||
| 40 | $this->paymentEntity->setStatus( |
||
| 41 | AmazonpayConstants::OMS_STATUS_CAPTURE_COMPLETED |
||
| 42 | ); |
||
| 43 | |||
| 44 | $this->paymentEntity->save(); |
||
| 45 | |||
| 46 | return $orderTransfer; |
||
| 47 | } |
||
| 48 | |||
| 49 | $status = $this->apiResponse->getAuthorizationDetails()->getAuthorizationStatus(); |
||
| 50 | |||
| 51 | if ($status->getIsPending()) { |
||
| 52 | return $orderTransfer; |
||
| 53 | } |
||
| 54 | |||
| 55 | if ($status->getIsDeclined()) { |
||
| 56 | if ($status->getIsSuspended()) { |
||
| 57 | $this->paymentEntity->setStatus(AmazonpayConstants::OMS_STATUS_AUTH_SUSPENDED); |
||
| 58 | } else { |
||
| 59 | $this->paymentEntity->setStatus(AmazonpayConstants::OMS_STATUS_AUTH_DECLINED); |
||
| 60 | } |
||
| 61 | } |
||
| 62 | |||
| 63 | if ($status->getIsOpen()) { |
||
| 64 | $this->paymentEntity->setStatus(AmazonpayConstants::OMS_STATUS_AUTH_OPEN); |
||
| 65 | } |
||
| 66 | |||
| 67 | if ($status->getIsClosed()) { |
||
| 68 | if ($status->getIsReauthorizable()) { |
||
| 69 | $this->paymentEntity->setStatus(AmazonpayConstants::OMS_STATUS_AUTH_EXPIRED); |
||
| 70 | } else { |
||
| 71 | $this->paymentEntity->setStatus(AmazonpayConstants::OMS_STATUS_AUTH_CLOSED); |
||
| 72 | } |
||
| 73 | } |
||
| 74 | |||
| 75 | $this->paymentEntity->save(); |
||
| 76 | } |
||
| 77 | |||
| 78 | return $orderTransfer; |
||
| 79 | } |
||
| 82 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths