Completed
Pull Request — dev (#9)
by Andrey
08:58 queued 03:49
created

UpdateCaptureStatusCommandPlugin   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 18
Duplicated Lines 50 %

Importance

Changes 0
Metric Value
dl 9
loc 18
rs 10
c 0
b 0
f 0
wmc 2

1 Method

Rating   Name   Duplication   Size   Complexity  
A run() 9 9 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/**
4
 * Apache OSL-2
5
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6
 */
7
8
namespace SprykerEco\Zed\AmazonPay\Communication\Plugin\Oms\Command;
9
10
use Orm\Zed\Sales\Persistence\SpySalesOrder;
1 ignored issue
show
Bug introduced by
The type Orm\Zed\Sales\Persistence\SpySalesOrder was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
11
use Spryker\Zed\Oms\Business\Util\ReadOnlyArrayObject;
12
13
/**
14
 * @method \SprykerEco\Zed\AmazonPay\Business\AmazonPayFacadeInterface getFacade()
15
 */
16
class UpdateCaptureStatusCommandPlugin extends AbstractAmazonpayCommandPlugin
17
{
18
    /**
19
     * @param array $salesOrderItems
20
     * @param \Orm\Zed\Sales\Persistence\SpySalesOrder $orderEntity
21
     * @param \Spryker\Zed\Oms\Business\Util\ReadOnlyArrayObject $data
22
     *
23
     * @return array
24
     */
25 View Code Duplication
    public function run(array $salesOrderItems, SpySalesOrder $orderEntity, ReadOnlyArrayObject $data)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
26
    {
27
        $amazonpayCallTransfers = $this->groupSalesOrderItemsByCaptureId($salesOrderItems);
28
29
        foreach ($amazonpayCallTransfers as $amazonpayCallTransfer) {
30
            $this->getFacade()->updateCaptureStatus($amazonpayCallTransfer);
31
        }
32
33
        return [];
34
    }
35
}
36