CaptureOrderTransaction::execute() - Code Metrics - Inspection of "ECO-808 moving temporary files into config" - spryker-eco/amazon-pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/ECO-808-scrutinizer ( 956529...82fb0b )

by Andrey

created 2017-10-04 12:56 UTC

CaptureOrderTransaction::execute() B

↳ Parent: CaptureOrderTransaction

Complexity

Conditions	8
Paths	11

Size

Total Lines	53
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	30
nc	11
nop	1
dl	0
loc	53
rs	7.1199
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * Apache OSL-2
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\Amazonpay\Business\Payment\Handler\Transaction;

use Generated\Shared\Transfer\AmazonpayCallTransfer;
use Generated\Shared\Transfer\AmazonpayStatusTransfer;
use SprykerEco\Shared\Amazonpay\AmazonpayConstants;

class CaptureOrderTransaction extends AbstractAmazonpayTransaction
{

    /**
     * @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonpayCallTransfer
     *
     * @return \Generated\Shared\Transfer\AmazonpayCallTransfer
     */
    public function execute(AmazonpayCallTransfer $amazonpayCallTransfer)
    {
        if (!in_array($amazonpayCallTransfer->getAmazonpayPayment()->getStatus(), [
            AmazonpayConstants::OMS_STATUS_CAPTURE_PENDING,
            AmazonpayConstants::OMS_STATUS_AUTH_OPEN,
            AmazonpayConstants::OMS_STATUS_PAYMENT_METHOD_CHANGED,
        ], true)) {
            return $amazonpayCallTransfer;
        }

        if ($amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()
            && $amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()->getAmazonCaptureId()) {
            return $amazonpayCallTransfer;
        }

        $amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()->setCaptureReferenceId(
            $this->generateOperationReferenceId($amazonpayCallTransfer)
        );

        $amazonpayCallTransfer = parent::execute($amazonpayCallTransfer);

        if (!$amazonpayCallTransfer->getAmazonpayPayment()->getResponseHeader()->getIsSuccess()) {
            return $amazonpayCallTransfer;
        }

        $isPartialProcessing = $this->isPartialProcessing($this->paymentEntity, $amazonpayCallTransfer);

        if ($isPartialProcessing) {
            $this->paymentEntity = $this->duplicatePaymentEntity($this->paymentEntity);
        }

        $amazonpayCallTransfer->getAmazonpayPayment()->setCaptureDetails(
            $this->apiResponse->getCaptureDetails()
        );
        $this->paymentEntity->setAmazonCaptureId(
            $this->apiResponse->getCaptureDetails()->getAmazonCaptureId()
        );
        $this->paymentEntity->setCaptureReferenceId(
            $this->apiResponse->getCaptureDetails()->getCaptureReferenceId()
        );
        $newStatus = $this->getPaymentStatus($amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()->getCaptureStatus());

        if ($newStatus !== false) {
            $this->paymentEntity->setStatus($newStatus);
        }

        $this->paymentEntity->save();

        if ($isPartialProcessing) {
            $this->assignAmazonpayPaymentToItemsIfNew($this->paymentEntity, $amazonpayCallTransfer);
        }

        return $amazonpayCallTransfer;
    }

    /**
     * @param \Generated\Shared\Transfer\AmazonpayStatusTransfer $captureStatus
     *
     * @return bool
     */
    protected function getPaymentStatus(AmazonpayStatusTransfer $captureStatus)
    {
        $paymentStatus = false;

        if ($captureStatus->getIsDeclined()) {
            $paymentStatus = AmazonpayConstants::OMS_STATUS_CAPTURE_DECLINED;
        }

        if ($captureStatus->getIsPending()) {
            $paymentStatus = AmazonpayConstants::OMS_STATUS_CAPTURE_PENDING;
        }

        if ($captureStatus->getIsCompleted()) {
            $paymentStatus = AmazonpayConstants::OMS_STATUS_CAPTURE_COMPLETED;
        }

        return $paymentStatus;

    }

}


1			<?php
2
3			/**
4			* Apache OSL-2
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\Amazonpay\Business\Payment\Handler\Transaction;
9
10			use Generated\Shared\Transfer\AmazonpayCallTransfer;
11			use Generated\Shared\Transfer\AmazonpayStatusTransfer;
12			use SprykerEco\Shared\Amazonpay\AmazonpayConstants;
13
14			class CaptureOrderTransaction extends AbstractAmazonpayTransaction
15			{
16
17			/**
18			* @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonpayCallTransfer
19			*
20			* @return \Generated\Shared\Transfer\AmazonpayCallTransfer
21			*/
22			public function execute(AmazonpayCallTransfer $amazonpayCallTransfer)
23			{
24			if (!in_array($amazonpayCallTransfer->getAmazonpayPayment()->getStatus(), [
25			AmazonpayConstants::OMS_STATUS_CAPTURE_PENDING,
26			AmazonpayConstants::OMS_STATUS_AUTH_OPEN,
27			AmazonpayConstants::OMS_STATUS_PAYMENT_METHOD_CHANGED,
28			], true)) {
29			return $amazonpayCallTransfer;
30			}
31
32			if ($amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()
33			&& $amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()->getAmazonCaptureId()) {
34			return $amazonpayCallTransfer;
35			}
36
37			$amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()->setCaptureReferenceId(
38			$this->generateOperationReferenceId($amazonpayCallTransfer)
39			);
40
41			$amazonpayCallTransfer = parent::execute($amazonpayCallTransfer);
42
43			if (!$amazonpayCallTransfer->getAmazonpayPayment()->getResponseHeader()->getIsSuccess()) {
44			return $amazonpayCallTransfer;
45			}
46
47			$isPartialProcessing = $this->isPartialProcessing($this->paymentEntity, $amazonpayCallTransfer);
48
49			if ($isPartialProcessing) {
50			$this->paymentEntity = $this->duplicatePaymentEntity($this->paymentEntity);
51			}
52
53			$amazonpayCallTransfer->getAmazonpayPayment()->setCaptureDetails(
54			$this->apiResponse->getCaptureDetails()
55			);
56			$this->paymentEntity->setAmazonCaptureId(
57			$this->apiResponse->getCaptureDetails()->getAmazonCaptureId()
58			);
59			$this->paymentEntity->setCaptureReferenceId(
60			$this->apiResponse->getCaptureDetails()->getCaptureReferenceId()
61			);
62			$newStatus = $this->getPaymentStatus($amazonpayCallTransfer->getAmazonpayPayment()->getCaptureDetails()->getCaptureStatus());
63
64			if ($newStatus !== false) {
65			$this->paymentEntity->setStatus($newStatus);
66			}
67
68			$this->paymentEntity->save();
69
70			if ($isPartialProcessing) {
71			$this->assignAmazonpayPaymentToItemsIfNew($this->paymentEntity, $amazonpayCallTransfer);
72			}
73
74			return $amazonpayCallTransfer;
75			}
76
77			/**
78			* @param \Generated\Shared\Transfer\AmazonpayStatusTransfer $captureStatus
79			*
80			* @return bool
81			*/
82			protected function getPaymentStatus(AmazonpayStatusTransfer $captureStatus)
83			{
84			$paymentStatus = false;
85
86			if ($captureStatus->getIsDeclined()) {
87			$paymentStatus = AmazonpayConstants::OMS_STATUS_CAPTURE_DECLINED;
88			}
89
90			if ($captureStatus->getIsPending()) {
91			$paymentStatus = AmazonpayConstants::OMS_STATUS_CAPTURE_PENDING;
92			}
93
94			if ($captureStatus->getIsCompleted()) {
95			$paymentStatus = AmazonpayConstants::OMS_STATUS_CAPTURE_COMPLETED;
96			}
97
98			return $paymentStatus;
			0 ignored issues – show Bug Best Practice introduced 2017-09-29 10:26 UTC by Report Bug Copy Issue Report The expression `return $paymentStatus` also could return the type `string` which is incompatible with the documented return type `boolean`. Loading history...
99			}
100
101			}
102

spryker-eco / amazon-pay

Push — feature/ECO-808-scrutinizer ( 956529...82fb0b )

CaptureOrderTransaction::execute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like