RefundDetailsConverter::convert() - Code Metrics - Inspection of "ECO-965 refactoring" - spryker-eco/amazon-pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — feature/ECO-948-renaming-and-r... (#7)

by Andrey

created 2017-11-10 12:26 UTC

RefundDetailsConverter::convert() A

↳ Parent: RefundDetailsConverter

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	1
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Apache OSL-2
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\AmazonPay\Business\Api\Converter\Details;

use Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer;
use SprykerEco\Zed\AmazonPay\Business\Api\Converter\AbstractArrayConverter;

class RefundDetailsConverter extends AbstractArrayConverter
{
    const REFUND_AMOUNT = 'RefundAmount';
    const REFUND_STATUS = 'RefundStatus';

    /**
     * @param array $refundDetailsData
     *
     * @return \Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer
     */
    public function convert(array $refundDetailsData)
    {
        $refundDetails = new AmazonpayRefundDetailsTransfer();
        $refundDetails->fromArray($refundDetailsData, true);

        $this->hydrateRefundAmount($refundDetailsData, $refundDetails);

        $this->hydrateStatus($refundDetailsData, $refundDetails);

        return $refundDetails;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * @param array $refundDetailsData
     * @param \Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer $refundDetails
     *
     * @return void
     */
    protected function hydrateRefundAmount(array $refundDetailsData, AmazonpayRefundDetailsTransfer $refundDetails)
    {
        $refundDetails->setRefundAmount(
            $this->convertPriceToTransfer(
                $refundDetailsData[static::REFUND_AMOUNT]
            )
        );
    }

    /**
     * @param array $refundDetailsData
     * @param \Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer $refundDetails
     *
     * @return void
     */
    protected function hydrateStatus(array $refundDetailsData, AmazonpayRefundDetailsTransfer $refundDetails)
    {
        if (!empty($refundDetailsData[static::REFUND_STATUS])) {
            $refundDetails->setRefundStatus(
                $this->convertStatusToTransfer($refundDetailsData[static::REFUND_STATUS])
            );
        }
    }
}


1			<?php
2
3			/**
4			* Apache OSL-2
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\AmazonPay\Business\Api\Converter\Details;
9
10			use Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer;
11			use SprykerEco\Zed\AmazonPay\Business\Api\Converter\AbstractArrayConverter;
12
13			class RefundDetailsConverter extends AbstractArrayConverter
14			{
15			const REFUND_AMOUNT = 'RefundAmount';
16			const REFUND_STATUS = 'RefundStatus';
17
18			/**
19			* @param array $refundDetailsData
20			*
21			* @return \Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer
22			*/
23			public function convert(array $refundDetailsData)
24			{
25			$refundDetails = new AmazonpayRefundDetailsTransfer();
26			$refundDetails->fromArray($refundDetailsData, true);
27
28			$this->hydrateRefundAmount($refundDetailsData, $refundDetails);
29
30			$this->hydrateStatus($refundDetailsData, $refundDetails);
31
32			return $refundDetails;
			0 ignored issues – show Bug Best Practice introduced 2017-11-10 12:30 UTC by Report Bug Copy Issue Report The expression `return $refundDetails` returns the type `Generated\Shared\Transfe...ayRefundDetailsTransfer` which is incompatible with the return type mandated by `SprykerEco\Zed\AmazonPay...terInterface::convert()` of `Generated\Shared\Transfe...azonpayResponseTransfer`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
33			}
34
35			/**
36			* @param array $refundDetailsData
37			* @param \Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer $refundDetails
38			*
39			* @return void
40			*/
41			protected function hydrateRefundAmount(array $refundDetailsData, AmazonpayRefundDetailsTransfer $refundDetails)
42			{
43			$refundDetails->setRefundAmount(
44			$this->convertPriceToTransfer(
45			$refundDetailsData[static::REFUND_AMOUNT]
46			)
47			);
48			}
49
50			/**
51			* @param array $refundDetailsData
52			* @param \Generated\Shared\Transfer\AmazonpayRefundDetailsTransfer $refundDetails
53			*
54			* @return void
55			*/
56			protected function hydrateStatus(array $refundDetailsData, AmazonpayRefundDetailsTransfer $refundDetails)
57			{
58			if (!empty($refundDetailsData[static::REFUND_STATUS])) {
59			$refundDetails->setRefundStatus(
60			$this->convertStatusToTransfer($refundDetailsData[static::REFUND_STATUS])
61			);
62			}
63			}
64			}
65

spryker-eco / amazon-pay

Pull Request — feature/ECO-948-renaming-and-r... (#7)

RefundDetailsConverter::convert() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like