CancelOrderTransaction::updatePaymentEntity() - Code Metrics - Inspection of "Bugfix/eco 1031 recent review" - spryker-eco/amazon-pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — dev (#9)

by Andrey

created 2018-01-29 14:44 UTC

CancelOrderTransaction::updatePaymentEntity() B

↳ Parent: CancelOrderTransaction

Complexity

Conditions	5
Paths	6

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	11
nc	6
nop	1
dl	0
loc	21
rs	8.7624
c	0
b	0
f	0

<?php

/**
 * Apache OSL-2
 * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
 */

namespace SprykerEco\Zed\AmazonPay\Business\Payment\Handler\Transaction;

use Generated\Shared\Transfer\AmazonpayCallTransfer;
filter:
    dependency_paths: ["lib/*"]
use SprykerEco\Shared\AmazonPay\AmazonPayConfig;

class CancelOrderTransaction extends AbstractAmazonpayTransaction
{
    /**
     * @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonPayCallTransfer
     *
     * @return \Generated\Shared\Transfer\AmazonpayCallTransfer
     */
    public function execute(AmazonpayCallTransfer $amazonPayCallTransfer)
    {
        $amazonPayCallTransfer = parent::execute($amazonPayCallTransfer);

        $this->updatePaymentEntity($amazonPayCallTransfer);

        return $amazonPayCallTransfer;
    }

    /**
     * @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonPayCallTransfer
     *
     * @return void
     */
    protected function updatePaymentEntity(AmazonpayCallTransfer $amazonPayCallTransfer)
    {
        if (!$this->paymentEntity) {
            return;
        }

        $isPartialProcessing = $this->isPartialProcessing($this->paymentEntity, $amazonPayCallTransfer);

        if (!$this->apiResponse->getResponseHeader()->getIsSuccess()) {
            return;
        }

        if ($isPartialProcessing) {
            $this->paymentEntity = $this->paymentProcessor->duplicatePaymentEntity($this->paymentEntity);
        }

        $this->paymentEntity->setStatus(AmazonPayConfig::STATUS_CANCELLED);
        $this->paymentEntity->save();

        if ($isPartialProcessing) {
            $this->paymentProcessor->assignAmazonpayPaymentToItems($this->paymentEntity, $amazonPayCallTransfer);
        }
    }

    /**
     * @return bool
     */
    protected function allowPartialProcessing()
    {
        return false;
    }
}


1			<?php
2
3			/**
4			* Apache OSL-2
5			* Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
6			*/
7
8			namespace SprykerEco\Zed\AmazonPay\Business\Payment\Handler\Transaction;
9
10			use Generated\Shared\Transfer\AmazonpayCallTransfer;
			1 ignored issue – show Bug introduced 2017-09-29 10:26 UTC by Report Bug Copy Issue Report The type `Generated\Shared\Transfer\AmazonpayCallTransfer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use SprykerEco\Shared\AmazonPay\AmazonPayConfig;
12
13			class CancelOrderTransaction extends AbstractAmazonpayTransaction
14			{
15			/**
16			* @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonPayCallTransfer
17			*
18			* @return \Generated\Shared\Transfer\AmazonpayCallTransfer
19			*/
20			public function execute(AmazonpayCallTransfer $amazonPayCallTransfer)
21			{
22			$amazonPayCallTransfer = parent::execute($amazonPayCallTransfer);
23
24			$this->updatePaymentEntity($amazonPayCallTransfer);
25
26			return $amazonPayCallTransfer;
27			}
28
29			/**
30			* @param \Generated\Shared\Transfer\AmazonpayCallTransfer $amazonPayCallTransfer
31			*
32			* @return void
33			*/
34			protected function updatePaymentEntity(AmazonpayCallTransfer $amazonPayCallTransfer)
35			{
36			if (!$this->paymentEntity) {
37			return;
38			}
39
40			$isPartialProcessing = $this->isPartialProcessing($this->paymentEntity, $amazonPayCallTransfer);
41
42			if (!$this->apiResponse->getResponseHeader()->getIsSuccess()) {
43			return;
44			}
45
46			if ($isPartialProcessing) {
47			$this->paymentEntity = $this->paymentProcessor->duplicatePaymentEntity($this->paymentEntity);
48			}
49
50			$this->paymentEntity->setStatus(AmazonPayConfig::STATUS_CANCELLED);
51			$this->paymentEntity->save();
52
53			if ($isPartialProcessing) {
54			$this->paymentProcessor->assignAmazonpayPaymentToItems($this->paymentEntity, $amazonPayCallTransfer);
55			}
56			}
57
58			/**
59			* @return bool
60			*/
61			protected function allowPartialProcessing()
62			{
63			return false;
64			}
65			}
66

spryker-eco / amazon-pay

Pull Request — dev (#9)

CancelOrderTransaction::updatePaymentEntity() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like