spryker-eco /
akeneo-pim-middleware-connector
| Conditions | 2 |
| Paths | 1 |
| Total Lines | 55 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 2 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function getMap(): array |
||
| 33 | { |
||
| 34 | return [ |
||
| 35 | 'taxSetName' => function ($item) { |
||
| 36 | return $this->config->getTaxSet(); |
||
| 37 | }, |
||
| 38 | 'color_code' => function ($item) { |
||
| 39 | return ''; |
||
| 40 | }, |
||
| 41 | 'new_from' => function ($item) { |
||
| 42 | return null; |
||
| 43 | }, |
||
| 44 | 'new_to' => function ($item) { |
||
| 45 | return null; |
||
| 46 | }, |
||
| 47 | 'category_key' => 'categories', |
||
| 48 | 'category_product_order' => function ($item) { |
||
| 49 | return 0; |
||
| 50 | }, |
||
| 51 | 'stores' => function ($item) { |
||
| 52 | return $this->config->getActiveStoresForProducts(); |
||
| 53 | }, |
||
| 54 | 'concrete_sku' => 'identifier', |
||
| 55 | 'abstract_sku' => 'parent.abstract_sku', |
||
| 56 | 'abstract_product_creation' => 'parent.abstract_product_creation', |
||
| 57 | 'prices' => function ($item) { |
||
| 58 | $result = []; |
||
| 59 | foreach ($item['values']['price'] as $value) { |
||
| 60 | $result[] = [ |
||
| 61 | 'price' => $value['price'], |
||
| 62 | 'price_type' => $value['type'], |
||
| 63 | 'currency' => $value['currency'], |
||
| 64 | 'store' => $value['store'], |
||
| 65 | 'concrete_sku' => $item['identifier'], |
||
| 66 | 'value_gross' => $value['price'], |
||
| 67 | 'value_net' => $value['price'], |
||
| 68 | ]; |
||
| 69 | } |
||
| 70 | |||
| 71 | return $result; |
||
| 72 | }, |
||
| 73 | 'images' => 'values.bild_information', |
||
| 74 | 'picto_images' => 'values.picto_informationen', |
||
| 75 | 'is_active' => 'enabled', |
||
| 76 | 'attributes' => [ |
||
| 77 | 'values.attributes', |
||
| 78 | ], |
||
| 79 | 'localizedAttributes' => [ |
||
| 80 | 'values.localizedAttributes', |
||
| 81 | ], |
||
| 82 | 'relations.others' => 'associations.PACK.product_models', |
||
| 83 | 'relations.x_sell' => 'associations.X_SELL.product_models', |
||
| 84 | 'relations.addon' => 'associations.SUBSTITUTION.product_models', |
||
| 85 | 'is_searchable' => function () { |
||
| 86 | return true; |
||
| 87 | }, |
||
| 99 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths