SprykerEco\Zed\AdyenApi\Business\Converter\AbstractConverter

Complexity

Total Complexity

3

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	convertToResponseTransfer()	0	14	2

<?php

/**
 * MIT License
 * For full license information, please view the LICENSE file that was distributed with this source code.
 */

namespace SprykerEco\Zed\AdyenApi\Business\Converter;

use Generated\Shared\Transfer\AdyenApiErrorResponseTransfer;

The type Generated\Shared\Transfer\AdyenApiErrorResponseTransfer was not found. Maybe you did not declare it correctly or list all dependencies?

use Generated\Shared\Transfer\AdyenApiResponseTransfer;

The type Generated\Shared\Transfer\AdyenApiResponseTransfer was not found. Maybe you did not declare it correctly or list all dependencies?

use Psr\Http\Message\ResponseInterface;
use SprykerEco\Zed\AdyenApi\AdyenApiConfig;
use SprykerEco\Zed\AdyenApi\Dependency\Service\AdyenApiToUtilEncodingServiceInterface;

abstract class AbstractConverter implements AdyenApiConverterInterface
{
    /**
     * @var \SprykerEco\Zed\AdyenApi\AdyenApiConfig
     */
    protected $config;

    /**
     * @var \SprykerEco\Zed\AdyenApi\Dependency\Service\AdyenApiToUtilEncodingServiceInterface
     */
    protected $encodingService;

    /**
     * @param \Generated\Shared\Transfer\AdyenApiResponseTransfer $responseTransfer
     * @param array $response
     *
     * @return \Generated\Shared\Transfer\AdyenApiResponseTransfer
     */
    abstract protected function updateResponseTransfer(AdyenApiResponseTransfer $responseTransfer, array $response): AdyenApiResponseTransfer;

    /**
     * @param \SprykerEco\Zed\AdyenApi\AdyenApiConfig $config
     * @param \SprykerEco\Zed\AdyenApi\Dependency\Service\AdyenApiToUtilEncodingServiceInterface $encodingService
     */
    public function __construct(
        AdyenApiConfig $config,
        AdyenApiToUtilEncodingServiceInterface $encodingService
    ) {
        $this->config = $config;
        $this->encodingService = $encodingService;
    }

    /**
     * @param \Psr\Http\Message\ResponseInterface $response
     * @param bool $isSuccess
     *
     * @return \Generated\Shared\Transfer\AdyenApiResponseTransfer
     */
    public function convertToResponseTransfer(ResponseInterface $response, $isSuccess = true): AdyenApiResponseTransfer
    {
        $responseBody = $this->encodingService->decodeJson($response->getBody(), true);
        $responseTransfer = new AdyenApiResponseTransfer();
        $responseTransfer->setIsSuccess($isSuccess);

        if ($isSuccess) {
            return $this->updateResponseTransfer($responseTransfer, $responseBody);

It seems like $responseBody can also be of type null; however, parameter $response of SprykerEco\Zed\AdyenApi\Business\Converter\AbstractConverter::updateResponseTransfer() does only seem to accept array, maybe add an additional type check?

        }

        $error = (new AdyenApiErrorResponseTransfer())->fromArray($responseBody, true);
        $responseTransfer->setError($error);

        return $responseTransfer;
    }
}