Issues in Builder.php (master) - Issues in master - sprocketbox/eloquent-identity - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Query/Builder.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Sprocketbox\Eloquent\Identity\Query;

use Closure;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
use Illuminate\Database\Eloquent\Relations\BelongsToMany;
use Illuminate\Support\Str;
use Sprocketbox\Eloquent\Identity\Concerns\MapsIdentity;
use Sprocketbox\Eloquent\Identity\Facades\Identity;
use Sprocketbox\Eloquent\Identity\ModelIdentity;

class Builder extends EloquentBuilder
{
    /**
     * @var bool
     */
    protected bool  $identityIsMapped       = false;


    protected bool  $refreshIdentityMap     = false;

    protected array $noConstraintEagerLoads = [];

    public function useIdentityMap(): self
    {
        $this->refreshIdentityMap = false;

        return $this;
    }

    public function refreshIdentityMap(): self
    {
        $this->refreshIdentityMap = true;

        return $this;
    }

    /**
     * Find an instance of the model from the identity map or database.
     *
     * @param       $id
     *
     * @param array $columns
     *
     * @return \Illuminate\Database\Eloquent\Model|\Illuminate\Database\Eloquent\Collection|null
     */
    public function findOrIdentify($id, array $columns = ['*'])
    {
        if (is_array($id) || $id instanceof Arrayable) {
            return $this->findMany($id, $columns);
        }

        $model = $this->identifyModel($id);

        if ($model !== null) {
            return $model;
        }

        return $this->whereKey($id)->first($columns);
    }

    public function find($id, $columns = ['*'])
    {
        if ($this->shouldUseIdentityMap()) {
            return $this->findOrIdentify($id, $columns);
        }

        return parent::find($id, $columns);
    }

    public function findMany($ids, $columns = ['*']): Collection
    {
        $ids = $ids instanceof Arrayable ? $ids->toArray() : $ids;

        if (empty($ids)) {
            return $this->model->newCollection();
        }

        if ($this->shouldUseIdentityMap()) {
            $models = [];
            $newIds = [];

            foreach ($ids as $id) {
                $models[$id] = $this->identifyModel($id);

                if ($models[$id] === null) {
                    $newIds[] = $id;
                }
            }

            $newModels = $this->whereKey($newIds)->get($columns);
            $newModels->each(fn(Model $model) => $models[$model->getKey()] = $model);

            return $this->model->newCollection(array_values($models));
        }

        return parent::findMany($ids, $columns);
    }

    public function setModel(Model $model): self
    {
        if (in_array(MapsIdentity::class, class_uses($model), true)) {
            $this->identityIsMapped = true;
        }

        return parent::setModel($model);
    }

    protected function shouldUseIdentityMap(): bool
    {
        return ! $this->refreshIdentityMap
            && empty($this->query->bindings['where'])
            && empty($this->query->bindings['join'] ?? [])
            && empty($this->query->bindings['having'] ?? []);
    }

    protected function identifyModel($id): ?Model
    {
        if (! $this->identityIsMapped || ! $this->shouldUseIdentityMap()) {
            return null;
        }

        if ($id instanceof ModelIdentity) {
            $identity = $id;
        } else {
            $identity = $this->model->getModelIdentity($id, $this->getConnection()->getName());
        }

        if (Identity::hasIdentity($identity)) {
            return Identity::getIdentity($identity);
        }

        return null;
    }

    protected function eagerLoadRelation(array $models, $name, Closure $constraints)
    {
        $relation     = $this->getRelation($name);
        $loadedModels = [];
        $newModels    = $models;

        if ($this->eagerLoadHasNoConstraints($name) && $this->shouldUseIdentityMap()) {
            /**
             * This is intentionally empty so that the relation doesn't get caught in the
             * belongs to block below it.
             *
             * @noinspection PhpStatementHasEmptyBodyInspection
             * @noinspection MissingOrEmptyGroupStatementInspection
             */
            if ($relation instanceof BelongsToMany) {
                //
            } else if ($relation instanceof BelongsTo) {
                $loadedModels = $this->eagerLoadBelongsToIdentities($relation, $newModels);
            }
        }

        if (empty($newModels)) {
            $eagerModels = $relation->getRelated()->newCollection($loadedModels);
        } else {
            $relation->addEagerConstraints($newModels);
            $constraints($relation);
            $eagerModels = $relation->getEager()->merge($loadedModels);
        }

        // Once we have the results, we just match those back up to their parent models
        // using the relationship instance. Then we just return the finished arrays
        // of models which have been eagerly hydrated and are readied for return.
        return $relation->match(
            $relation->initRelation($models, $name),
            $eagerModels, $name
        );
    }

    /**
     * Parse a list of relations into individuals.
     *
     * @param array $relations
     *
     * @return array
     */
    protected function parseWithRelations(array $relations): array
    {
        $results = [];

        foreach ($relations as $name => $constraints) {
            // If the "name" value is a numeric key, we can assume that no constraints
            // have been specified. We will just put an empty Closure there so that
            // we can treat these all the same while we are looping through them.
            if (is_numeric($name)) {
                $name = $constraints;

                if (Str::contains($name, ':')) {
                    [$name, $constraints] = $this->createSelectWithConstraint($name);
                } else {
                    $this->noConstraintEagerLoads[] = $name;
                    $constraints                    = static function () {
                        //
                    };
                }
            }

            // We need to separate out any nested includes, which allows the developers
            // to load deep relationships using "dots" without stating each level of
            // the relationship with its own key in the array of eager-load names.
            $results = $this->addNestedWiths($name, $results);

            $results[$name] = $constraints;
        }

        return $results;
    }

    protected function eagerLoadHasNoConstraints(string $name): bool
    {
        return in_array($name, $this->noConstraintEagerLoads, true);
    }

    protected function eagerLoadBelongsToIdentities(BelongsTo $relation, array &$models): array
    {
        $newModels    = [];
        $loadedModels = [];

        foreach ($models as $i => $model) {
            $key = $model->getAttribute($relation->getForeignKeyName());

            if ($key !== null) {
                if (method_exists($relation->getRelated(), 'getModelIdentity')) {
                    $loadedModel = $this->identifyModel(
                        $relation->getRelated()->getModelIdentity($key, $this->getConnection()->getName())
                    );

                    if ($loadedModel !== null) {
                        $loadedModels[] = $loadedModel;
                        continue;
                    }
                }

                $newModels[] = $key;
            }
        }

        $models = $newModels;

        return array_unique($loadedModels);
    }
}

1			<?php
2
3			namespace Sprocketbox\Eloquent\Identity\Query;
4
5			use Closure;
6			use Illuminate\Contracts\Support\Arrayable;
7			use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
8			use Illuminate\Database\Eloquent\Collection;
9			use Illuminate\Database\Eloquent\Model;
10			use Illuminate\Database\Eloquent\Relations\BelongsTo;
11			use Illuminate\Database\Eloquent\Relations\BelongsToMany;
12			use Illuminate\Support\Str;
13			use Sprocketbox\Eloquent\Identity\Concerns\MapsIdentity;
14			use Sprocketbox\Eloquent\Identity\Facades\Identity;
15			use Sprocketbox\Eloquent\Identity\ModelIdentity;
16
17			class Builder extends EloquentBuilder
18			{
19			/**
20			* @var bool
21			*/
22			protected bool $identityIsMapped = false;
			0 ignored issues – show Bug introduced 2020-07-07 08:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
23
24			protected bool $refreshIdentityMap = false;
25
26			protected array $noConstraintEagerLoads = [];
27
28			public function useIdentityMap(): self
29			{
30			$this->refreshIdentityMap = false;
31
32			return $this;
33			}
34
35			public function refreshIdentityMap(): self
36			{
37			$this->refreshIdentityMap = true;
38
39			return $this;
40			}
41
42			/**
43			* Find an instance of the model from the identity map or database.
44			*
45			* @param $id
46			*
47			* @param array $columns
48			*
49			* @return \Illuminate\Database\Eloquent\Model\|\Illuminate\Database\Eloquent\Collection\|null
50			*/
51			public function findOrIdentify($id, array $columns = ['*'])
52			{
53			if (is_array($id) \|\| $id instanceof Arrayable) {
54			return $this->findMany($id, $columns);
55			}
56
57			$model = $this->identifyModel($id);
58
59			if ($model !== null) {
60			return $model;
61			}
62
63			return $this->whereKey($id)->first($columns);
64			}
65
66			public function find($id, $columns = ['*'])
67			{
68			if ($this->shouldUseIdentityMap()) {
69			return $this->findOrIdentify($id, $columns);
70			}
71
72			return parent::find($id, $columns);
73			}
74
75			public function findMany($ids, $columns = ['*']): Collection
76			{
77			$ids = $ids instanceof Arrayable ? $ids->toArray() : $ids;
78
79			if (empty($ids)) {
80			return $this->model->newCollection();
81			}
82
83			if ($this->shouldUseIdentityMap()) {
84			$models = [];
85			$newIds = [];
86
87			foreach ($ids as $id) {
88			$models[$id] = $this->identifyModel($id);
89
90			if ($models[$id] === null) {
91			$newIds[] = $id;
92			}
93			}
94
95			$newModels = $this->whereKey($newIds)->get($columns);
96			$newModels->each(fn(Model $model) => $models[$model->getKey()] = $model);
97
98			return $this->model->newCollection(array_values($models));
99			}
100
101			return parent::findMany($ids, $columns);
102			}
103
104			public function setModel(Model $model): self
105			{
106			if (in_array(MapsIdentity::class, class_uses($model), true)) {
107			$this->identityIsMapped = true;
108			}
109
110			return parent::setModel($model);
111			}
112
113			protected function shouldUseIdentityMap(): bool
114			{
115			return ! $this->refreshIdentityMap
116			&& empty($this->query->bindings['where'])
117			&& empty($this->query->bindings['join'] ?? [])
118			&& empty($this->query->bindings['having'] ?? []);
119			}
120
121			protected function identifyModel($id): ?Model
122			{
123			if (! $this->identityIsMapped \|\| ! $this->shouldUseIdentityMap()) {
124			return null;
125			}
126
127			if ($id instanceof ModelIdentity) {
128			$identity = $id;
129			} else {
130			$identity = $this->model->getModelIdentity($id, $this->getConnection()->getName());
131			}
132
133			if (Identity::hasIdentity($identity)) {
134			return Identity::getIdentity($identity);
135			}
136
137			return null;
138			}
139
140			protected function eagerLoadRelation(array $models, $name, Closure $constraints)
141			{
142			$relation = $this->getRelation($name);
143			$loadedModels = [];
144			$newModels = $models;
145
146			if ($this->eagerLoadHasNoConstraints($name) && $this->shouldUseIdentityMap()) {
147			/**
148			* This is intentionally empty so that the relation doesn't get caught in the
149			* belongs to block below it.
150			*
151			* @noinspection PhpStatementHasEmptyBodyInspection
152			* @noinspection MissingOrEmptyGroupStatementInspection
153			*/
154			if ($relation instanceof BelongsToMany) {
155			//
156			} else if ($relation instanceof BelongsTo) {
157			$loadedModels = $this->eagerLoadBelongsToIdentities($relation, $newModels);
158			}
159			}
160
161			if (empty($newModels)) {
162			$eagerModels = $relation->getRelated()->newCollection($loadedModels);
163			} else {
164			$relation->addEagerConstraints($newModels);
165			$constraints($relation);
166			$eagerModels = $relation->getEager()->merge($loadedModels);
167			}
168
169			// Once we have the results, we just match those back up to their parent models
170			// using the relationship instance. Then we just return the finished arrays
171			// of models which have been eagerly hydrated and are readied for return.
172			return $relation->match(
173			$relation->initRelation($models, $name),
174			$eagerModels, $name
175			);
176			}
177
178			/**
179			* Parse a list of relations into individuals.
180			*
181			* @param array $relations
182			*
183			* @return array
184			*/
185			protected function parseWithRelations(array $relations): array
186			{
187			$results = [];
188
189			foreach ($relations as $name => $constraints) {
190			// If the "name" value is a numeric key, we can assume that no constraints
191			// have been specified. We will just put an empty Closure there so that
192			// we can treat these all the same while we are looping through them.
193			if (is_numeric($name)) {
194			$name = $constraints;
195
196			if (Str::contains($name, ':')) {
197			[$name, $constraints] = $this->createSelectWithConstraint($name);
198			} else {
199			$this->noConstraintEagerLoads[] = $name;
200			$constraints = static function () {
201			//
202			};
203			}
204			}
205
206			// We need to separate out any nested includes, which allows the developers
207			// to load deep relationships using "dots" without stating each level of
208			// the relationship with its own key in the array of eager-load names.
209			$results = $this->addNestedWiths($name, $results);
210
211			$results[$name] = $constraints;
212			}
213
214			return $results;
215			}
216
217			protected function eagerLoadHasNoConstraints(string $name): bool
218			{
219			return in_array($name, $this->noConstraintEagerLoads, true);
220			}
221
222			protected function eagerLoadBelongsToIdentities(BelongsTo $relation, array &$models): array
223			{
224			$newModels = [];
225			$loadedModels = [];
226
227			foreach ($models as $i => $model) {
228			$key = $model->getAttribute($relation->getForeignKeyName());
229
230			if ($key !== null) {
231			if (method_exists($relation->getRelated(), 'getModelIdentity')) {
232			$loadedModel = $this->identifyModel(
233			$relation->getRelated()->getModelIdentity($key, $this->getConnection()->getName())
234			);
235
236			if ($loadedModel !== null) {
237			$loadedModels[] = $loadedModel;
238			continue;
239			}
240			}
241
242			$newModels[] = $key;
243			}
244			}
245
246			$models = $newModels;
247
248			return array_unique($loadedModels);
249			}
250			}

sprocketbox / eloquent-identity

Issues (5)

Security Analysis no request data

src/Query/Builder.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like