ArrayAccessTrait - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sporti..." - sportic/timing-racetec-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 1b5216...e31da6 )

by Gabriel

created 2018-05-21 20:58 UTC

ArrayAccessTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

15.38%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	5
c	1
b	0
f	0
lcom	0
cbo	0
dl	0
loc	49
ccs	2
cts	13
cp	0.1538
rs	10

4 Methods

Rating	Name	Size	Complexity
A	offsetExists()	4	1
A	offsetGet()	4	1
A	offsetSet()	8	2
A	offsetUnset()	4	1

<?php

namespace Sportic\Timing\RaceTecClient\Content\Traits;

/**
 * Class ArrayAccessTrait
 * @package Nip\Collections
 */
trait ArrayAccessTrait
{

    /**
     * Determine if the given configuration option exists.
     *
     * @param  string $key
     * @return bool
     */
    public function offsetExists($key)
    {
        return $this->has($key);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get a configuration option.
     *
     * @param  string $key
     * @return mixed
     */
    public function offsetGet($key)
    {
        return $this->get($key);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param  string $offset
     * @param  mixed $value
     * @return void
     */
    public function offsetSet($offset, $value)
    {
        if (!isset($offset)) {
            $this->add($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return;
        }
        $this->set($offset, $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Unset a configuration option.
     *
     * @inheritdoc
     */
    public function offsetUnset($key)
    {
        $this->unset($key);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Sportic\Timing\RaceTecClient\Content\Traits;
4
5		/**
6		* Class ArrayAccessTrait
7		* @package Nip\Collections
8		*/
9		trait ArrayAccessTrait
10		{
11
12		/**
13		* Determine if the given configuration option exists.
14		*
15		* @param string $key
16		* @return bool
17		*/
18		public function offsetExists($key)
19		{
20		return $this->has($key);
		0 ignored issues – show Bug introduced 2018-05-21 21:10 UTC by Report Bug Copy Issue Report It seems like `has()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21		}
22
23		/**
24		* Get a configuration option.
25		*
26		* @param string $key
27		* @return mixed
28		*/
29	6	public function offsetGet($key)
30		{
31	6	return $this->get($key);
		0 ignored issues – show Bug introduced 2018-05-21 21:10 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32		}
33
34		/**
35		* @param string $offset
36		* @param mixed $value
37		* @return void
38		*/
39		public function offsetSet($offset, $value)
40		{
41		if (!isset($offset)) {
42		$this->add($value);
		0 ignored issues – show Bug introduced 2018-05-21 21:10 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43		return;
44		}
45		$this->set($offset, $value);
		0 ignored issues – show Bug introduced 2018-05-21 21:10 UTC by Report Bug Copy Issue Report It seems like `set()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
46		}
47
48		/**
49		* Unset a configuration option.
50		*
51		* @inheritdoc
52		*/
53		public function offsetUnset($key)
54		{
55		$this->unset($key);
		0 ignored issues – show Bug introduced 2018-05-21 21:10 UTC by Report Bug Copy Issue Report It seems like `unset()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56		}
57		}
58

sportic / timing-racetec-client

Push — master ( 1b5216...e31da6 )

ArrayAccessTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like