EventPageTest::testGenerateContentResultPagination() - Code Metrics - Inspection of "update tests to abstract classes" - sportic/timing-racetec-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( b97929...aafad9 )

by Gabriel

created 2018-05-24 18:23 UTC

testGenerateContentResultPagination() A

↳ Parent: EventPageTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	6
nc	1
nop	0

<?php

namespace Sportic\Timing\RaceTecClient\Tests\Parsers;

use Sportic\Timing\RaceTecClient\Models\Result;
use Sportic\Timing\RaceTecClient\Scrapers\EventPage as EventPageScraper;
use Sportic\Timing\RaceTecClient\Parsers\EventPage as EventPageParser;

/**
 * Class EventPageTest
 * @package Sportic\Timing\RaceTecClient\Tests\Scrapers
 */
class EventPageTest extends AbstractPageTest
{

    public function testGenerateContentRaces()
    {
        self::assertCount(5, self::$parametersParsed['races']);
    }

    public function testGenerateContentResultHeader()
    {
        self::assertCount(8, self::$parametersParsed['results']['header']);
    }

    public function testGenerateContentResultList()
    {
        self::assertCount(50, self::$parametersParsed['results']['list']);
        self::assertInstanceOf(Result::class, self::$parametersParsed['results']['list'][5]);
        self::assertEquals(
            [
                'posGen'      => '6',
                'bib'         => '247',
                'fullName'    => 'Sorin Boriceanu',
                'href'        => 'MyResults.aspx?uid=16648-2091-1-29984',
                'time'        => '02:04:16',
                'category'    => 'Masculin 35-39',
                'posCategory' => '3',
                'gender'      => 'Male',
                'posGender'   => '6',
            ],
            self::$parametersParsed['results']['list'][5]->__toArray()
        );
    }

    public function testGenerateContentResultPagination()
    {
        self::assertEquals(
            [
                'current' => 1,
                'all'     => 5,
                'items'   => 222,
            ],
            self::$parametersParsed['results']['pagination']
        );
    }

    public function testGenerateContentAll()
    {
        self::assertEquals(self::$parameters, self::$parametersParsed->all());

    }

    /**
     * @inheritdoc
     */
    protected static function getNewScraper()
    {
        return new EventPageScraper('16648', '2091', '1');
    }

    /**
     * @inheritdoc
     */
    protected static function getNewParser()
    {
        return new EventPageParser();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    protected static function getSerializedFile()
    {
        return 'event_page.serialized';
    }

    /**
     * @inheritdoc
     */
    protected static function getHtmlFile()
    {
        return 'event_page.html';
    }
}


1			<?php
2
3			namespace Sportic\Timing\RaceTecClient\Tests\Parsers;
4
5			use Sportic\Timing\RaceTecClient\Models\Result;
6			use Sportic\Timing\RaceTecClient\Scrapers\EventPage as EventPageScraper;
7			use Sportic\Timing\RaceTecClient\Parsers\EventPage as EventPageParser;
8
9			/**
10			* Class EventPageTest
11			* @package Sportic\Timing\RaceTecClient\Tests\Scrapers
12			*/
13			class EventPageTest extends AbstractPageTest
14			{
15
16			public function testGenerateContentRaces()
17			{
18			self::assertCount(5, self::$parametersParsed['races']);
19			}
20
21			public function testGenerateContentResultHeader()
22			{
23			self::assertCount(8, self::$parametersParsed['results']['header']);
24			}
25
26			public function testGenerateContentResultList()
27			{
28			self::assertCount(50, self::$parametersParsed['results']['list']);
29			self::assertInstanceOf(Result::class, self::$parametersParsed['results']['list'][5]);
30			self::assertEquals(
31			[
32			'posGen' => '6',
33			'bib' => '247',
34			'fullName' => 'Sorin Boriceanu',
35			'href' => 'MyResults.aspx?uid=16648-2091-1-29984',
36			'time' => '02:04:16',
37			'category' => 'Masculin 35-39',
38			'posCategory' => '3',
39			'gender' => 'Male',
40			'posGender' => '6',
41			],
42			self::$parametersParsed['results']['list'][5]->__toArray()
43			);
44			}
45
46			public function testGenerateContentResultPagination()
47			{
48			self::assertEquals(
49			[
50			'current' => 1,
51			'all' => 5,
52			'items' => 222,
53			],
54			self::$parametersParsed['results']['pagination']
55			);
56			}
57
58			public function testGenerateContentAll()
59			{
60			self::assertEquals(self::$parameters, self::$parametersParsed->all());
			0 ignored issues – show Bug introduced 2018-05-21 21:10 UTC by Report Bug Copy Issue Report The method `all` cannot be called on `self::$parametersParsed` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
61			}
62
63			/**
64			* @inheritdoc
65			*/
66			protected static function getNewScraper()
67			{
68			return new EventPageScraper('16648', '2091', '1');
69			}
70
71			/**
72			* @inheritdoc
73			*/
74			protected static function getNewParser()
75			{
76			return new EventPageParser();
			0 ignored issues – show Bug Best Practice introduced 2018-05-24 18:25 UTC by Report Bug Copy Issue Report The return type of `return new \Sportic\Timi...nt\Parsers\EventPage();` (`Sportic\Timing\RaceTecClient\Parsers\EventPage`) is incompatible with the return type declared by the abstract method `Sportic\Timing\RaceTecCl...tPageTest::getNewParser` of type `Sportic\Timing\RaceTecCl...crapers\AbstractScraper`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
77			}
78
79			/**
80			* @inheritdoc
81			*/
82			protected static function getSerializedFile()
83			{
84			return 'event_page.serialized';
85			}
86
87			/**
88			* @inheritdoc
89			*/
90			protected static function getHtmlFile()
91			{
92			return 'event_page.html';
93			}
94			}
95

sportic / timing-racetec-client

Push — master ( b97929...aafad9 )

testGenerateContentResultPagination() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like