Sportic\Timing\RaceTecClient\Parsers\AbstractParser

Complexity

Total Complexity

14

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	getContent()	0	13	3
	generateContent()	0	1	?
A	isValidContent()	0	9	2
A	doValidation()	0	3	1
A	getScraper()	0	4	1
A	setScraper()	0	4	1
A	getCrawler()	0	4	1
A	setCrawler()	0	4	1
A	getArray()	0	4	1
A	getModel()	0	8	1
A	getNewModel()	0	7	1
	getModelClassName()	0	1	?
A	getContentClassName()	0	4	1

<?php

namespace Sportic\Timing\RaceTecClient\Parsers;

use Sportic\Timing\CommonClient\Content\ContentFactory;
use Sportic\Timing\CommonClient\Models\AbstractModel;
use Sportic\Timing\RaceTecClient\Scrapers\AbstractScraper;
use Symfony\Component\DomCrawler\Crawler;

/**
 * Class AbstractParser
 * @package Sportic\Timing\RaceTecClient\Parsers
 */
abstract class AbstractParser
{

    /**
     * @var AbstractScraper
     */
    protected $scraper;

    /**
     * @var Crawler
     */
    protected $crawler;

    /**
     * @var null|boolean
     */
    protected $isValidContent = null;

    /**
     * @var null|AbstractContent
     */
    protected $contents = null;

    /**
     * @return mixed
     */
    public function getContent()
    {
        if ($this->contents === null) {
            if ($this->isValidContent()) {
                $contents = $this->generateContent();
                $this->contents = ContentFactory::createFromArray($contents);

It seems like \Sportic\Timing\CommonClient\Content\ContentFactory::createFromArray($contents) of type object<Sportic\Timing\CommonClient\Content\AbstractContent> is incompatible with the declared type null|object<Sportic\Timing\RaceTecClient\Parsers\AbstractContent> of property $contents.

            } else {
                $this->contents = false;

It seems like false of type false is incompatible with the declared type null|object<Sportic\Timing\RaceTecClient\Parsers\AbstractContent> of property $contents.

            }
        }

        return $this->contents;
    }

    abstract protected function generateContent();

    /**
     * @return bool|null
     */
    public function isValidContent()
    {
        if ($this->isValidContent == null) {
            $this->doValidation();
            $this->isValidContent = true;
        }

        return $this->isValidContent;
    }

    /**
     * @return void
     */
    protected function doValidation()
    {
    }

    /**
     * @return AbstractScraper
     */
    public function getScraper()
    {
        return $this->scraper;
    }

    /**
     * @param AbstractScraper $scraper
     */
    public function setScraper($scraper)
    {
        $this->scraper = $scraper;
    }

    /**
     * @return Crawler
     */
    public function getCrawler(): Crawler
    {
        return $this->crawler;
    }

    /**
     * @param Crawler $crawler
     */
    public function setCrawler(Crawler $crawler)
    {
        $this->crawler = $crawler;
    }

    /**
     * @return array
     */
    public function getArray()
    {
        return $this->getContent();
    }

    /**
     * @return AbstractModel
     */
    public function getModel()
    {
        $model      = $this->getNewModel();
        $parameters = $this->getContent();
        $model->setParameters($parameters);

It seems like $parameters defined by $this->getContent() on line 122 can also be of type false or object<Sportic\Timing\CommonClient\Content\AbstractContent>; however, Sportic\Timing\CommonClient\Models\AbstractModel::setParameters() does only seem to accept array, maybe add an additional type check?

        return $model;
    }

    /**
     * @return AbstractModel
     */
    public function getNewModel()
    {
        $className = $this->getModelClassName();
        $model     = new $className();

        return $model;
    }

    abstract public function getModelClassName();

    /**
     * @return string
     */
    protected function getContentClassName()
    {
        return GenericContent::class;
    }
}