sportarchive / CloudProcessingEngine

client_example/ClientCommander.php

Braces +50 added lines, -41 removed lines

@@ -38,8 +38,7 @@ 
         $decodedClient = json_decode($clientInfo);
         
         $CpeClientSdk->start_job($decodedClient, $content);
-    }
-    catch (Exception $e) {
+    } catch (Exception $e) {
         print("[ERROR] " . $e->getMessage() . "\n");
     }
 }
@@ -68,42 +67,51 @@ 
     global $argv;
         
     // Handle input parameters
-    if (!($options = getopt("c:k::s::r::hd")))
-        usage();
-    if (isset($options['h']))
-        usage();
+    if (!($options = getopt("c:k::s::r::hd"))) {
+            usage();
+    }
+    if (isset($options['h'])) {
+            usage();
+    }
     
-    if (isset($options['d']))
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
   
     if (isset($options['c']))
     {
         $clientConfFile = $options['c'];
-        if (!file_exists($clientConfFile))
-            throw new Exception("The client config file is not valid!");
-        if (!($clientInfo = file_get_contents($clientConfFile)))
-            throw new Exception("Unable to read the file");
-    }
-    else
-        throw new Exception("Please provide the client config file!");
-
-    if (isset($options['k']))
-        $key = $options['k'];
-    else
-        $key = getenv("AWS_ACCESS_KEY_ID");
+        if (!file_exists($clientConfFile)) {
+                    throw new Exception("The client config file is not valid!");
+        }
+        if (!($clientInfo = file_get_contents($clientConfFile))) {
+                    throw new Exception("Unable to read the file");
+        }
+    } else {
+            throw new Exception("Please provide the client config file!");
+    }
+
+    if (isset($options['k'])) {
+            $key = $options['k'];
+    } else {
+            $key = getenv("AWS_ACCESS_KEY_ID");
+    }
     
-    if (isset($options['s']))
-        $secret = $options['s'];
-    else
-        $secret = getenv("AWS_SECRET_KEY");
-
-    if (isset($options['r']))
-        $region = $options['r'];
-    else 
-        $region = getenv("AWS_DEFAULT_REGION");
-    if (!$region)
-        throw new Exception("Please provide your AWS region as parameter or using AWS_DEFAULT_REGION env var !");
-}
+    if (isset($options['s'])) {
+            $secret = $options['s'];
+    } else {
+            $secret = getenv("AWS_SECRET_KEY");
+    }
+
+    if (isset($options['r'])) {
+            $region = $options['r'];
+    } else {
+            $region = getenv("AWS_DEFAULT_REGION");
+    }
+    if (!$region) {
+            throw new Exception("Please provide your AWS region as parameter or using AWS_DEFAULT_REGION env var !");
+    }
+    }
 
     function usage()
     {
@@ -123,8 +131,7 @@ 
 
 try {
     check_input_parameters();
-} 
-catch (Exception $e) {
+} catch (Exception $e) {
     print "[ERROR] " . $e->getMessage() . "\n";
     exit(2);
 }
@@ -147,14 +154,16 @@ 
 {
     // Prompt (<3 php)
     $line = readline("Command [enter]: ");
-    if (!$line)
-        continue;
+    if (!$line) {
+            continue;
+    }
     readline_add_history($line);
 
     // Process user input
     $args = explode(" ", $line);
-    if (!isset($commandMap[$args[0]]))
-        print "[ERROR] Command not found!\n";
-    else 
-        $commandMap[$args[0]]($args);
-}
\ No newline at end of file
+    if (!isset($commandMap[$args[0]])) {
+            print "[ERROR] Command not found!\n";
+    } else {
+            $commandMap[$args[0]]($args);
+    }
+    }
\ No newline at end of file

pollers/src/InputPoller.php

Braces +35 added lines, -25 removed lines

@@ -86,9 +86,10 @@ 
     // If a msg is received, we pass it to 'handle_input' for processing
     public function poll_SQS_queues()
     {
-        if (!isset($this->config->{'clients'}))
-            throw new CpeSdk\CpeException("Clients configuration invalid. Check the config file or your parameters.",
+        if (!isset($this->config->{'clients'})) {
+                    throw new CpeSdk\CpeException("Clients configuration invalid. Check the config file or your parameters.",
                 self::INVALID_CONFIG);
+        }
         
         // For all clients in config files
         // We poll from queues
@@ -102,13 +103,14 @@ 
             try {
                 if ($msg = $this->cpeSqsListener->receive_message($queue, 10))
                 {
-                    if (!($decoded = json_decode($msg['Body'])))
-                        $this->cpeLogger->log_out(
+                    if (!($decoded = json_decode($msg['Body']))) {
+                                            $this->cpeLogger->log_out(
                             "ERROR", 
                             basename(__FILE__), 
                             "JSON data invalid in queue: '$queue'");
-                    else                    
-                        $this->handle_message($decoded);
+                    } else {
+                                            $this->handle_message($decoded);
+                    }
                 }
             } catch (CpeSdk\CpeException $e) {
                 $this->cpeLogger->log_out(
@@ -123,8 +125,9 @@ 
             }
             
             // Message polled. Valid or not, we delete it from SQS
-            if ($msg)
-                $this->cpeSqsListener->delete_message($queue, $msg);
+            if ($msg) {
+                            $this->cpeSqsListener->delete_message($queue, $msg);
+            }
         }
     }
 
@@ -149,12 +152,13 @@ 
             basename(__FILE__), 
             "Received message '" . $message->{"type"}  . "'"
         );
-        if ($this->debug)
-            $this->cpeLogger->log_out(
+        if ($this->debug) {
+                    $this->cpeLogger->log_out(
                 "DEBUG", 
                 basename(__FILE__), 
                 "Details:\n" . json_encode($message, JSON_PRETTY_PRINT)
             );
+        }
 
         // We call the callback function that handles this message  
         $this->{$this->typesMap[$message->{"type"}]}($message);
@@ -168,12 +172,13 @@ 
     // Start a new workflow in SWF to initiate new transcoding job
     private function start_job($message)
     {
-        if ($this->debug)
-            $this->cpeLogger->log_out(
+        if ($this->debug) {
+                    $this->cpeLogger->log_out(
                 "DEBUG",
                 basename(__FILE__),
                 "Starting new workflow!"
             );
+        }
         
         // Workflow info
         $workflowType = array(
@@ -192,9 +197,10 @@ 
                 "taskList"     => array("name" => $message->{'data'}->{'workflow'}->{'taskList'}),
                 "input"        => json_encode($message->{'data'})
             );
-            if (isset($message->{'data'}->{'workflow'}->{'executionStartToCloseTimeout'})) 
-                $payload["executionStartToCloseTimeout"] =
+            if (isset($message->{'data'}->{'workflow'}->{'executionStartToCloseTimeout'})) {
+                            $payload["executionStartToCloseTimeout"] =
                     $message->{'data'}->{'workflow'}->{'executionStartToCloseTimeout'};
+            }
             $workflowRunId = $this->cpeSwfHandler->swf->startWorkflowExecution($payload);
 
             $this->cpeLogger->log_out(
@@ -229,13 +235,15 @@ 
             !isset($message->{"time"})   || $message->{"time"} == "" || 
             !isset($message->{"jobId"})  || $message->{"jobId"} == "" || 
             !isset($message->{"type"})   || $message->{"type"} == "" || 
-            !isset($message->{"data"})   || $message->{"data"} == "")
-            throw new CpeSdk\CpeException("'time', 'type', 'jobId' or 'data' fields missing in JSON message file!",
+            !isset($message->{"data"})   || $message->{"data"} == "") {
+                    throw new CpeSdk\CpeException("'time', 'type', 'jobId' or 'data' fields missing in JSON message file!",
                 self::INVALID_JSON);
+        }
         
-        if (!isset($message->{'data'}->{'workflow'}))
-            throw new CpeSdk\CpeException("Input doesn't contain any workflow information. You must provide the workflow you want to send this job to!",
+        if (!isset($message->{'data'}->{'workflow'})) {
+                    throw new CpeSdk\CpeException("Input doesn't contain any workflow information. You must provide the workflow you want to send this job to!",
                 self::INVALID_JSON);
+        }
     }
 }
 
@@ -266,11 +274,13 @@ 
     // Handle input parameters
     $options = getopt("l:hdn:");
 
-    if (isset($options['h']))
-        usage();
+    if (isset($options['h'])) {
+            usage();
+    }
     
-    if (isset($options['d'])) 
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
         
     $logPath = null;
     if (isset($options['l']))
@@ -308,8 +318,7 @@ 
 // Create InputPoller object
 try {
     $inputPoller = new InputPoller($config);
-}
-catch (CpeSdk\CpeException $e) {
+} catch (CpeSdk\CpeException $e) {
     echo $e->getMessage();
     $cpeLogger->log_out(
         "FATAL", 
@@ -323,5 +332,6 @@ 
 print "Start polling ...\n";
 
 // Start polling loop to get incoming commands from SQS input queues
-while (42)
+while (42) {
     $inputPoller->poll_SQS_queues();
+}

pollers/src/ActivityPoller.php

Braces +40 added lines, -29 removed lines

@@ -98,9 +98,10 @@ 
     public function poll_for_activities()
     {
         // Poll from all the taskList registered for each activities 
-        if ($this->debug)
-            $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
+        if ($this->debug) {
+                    $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
                 "Polling activity taskList '" . $this->taskList  . "' ... ");
+        }
             
         try {
             // Call SWF and poll for incoming tasks
@@ -124,8 +125,9 @@ 
     {
         // Get activityType and WorkflowExecution info
         if (!($activityType      = $activityTask->get("activityType")) ||
-            !($workflowExecution = $activityTask->get("workflowExecution")))
-            return false;
+            !($workflowExecution = $activityTask->get("workflowExecution"))) {
+                    return false;
+        }
         
         $this->cpeLogger->log_out("INFO",
             basename(__FILE__),
@@ -152,16 +154,18 @@ 
             // Perform input validation
             $this->activityHandler->do_input_validation();
 
-            if ($this->debug)
-                $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
+            if ($this->debug) {
+                            $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
                     "Activity input:\n" . print_r($this->activityHandler->input, true));
+            }
         
             // Run activity task
             $result = $this->activityHandler->do_activity($activityTask);
 
-            if ($this->debug && $result)
-                $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
+            if ($this->debug && $result) {
+                            $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
                     "Activity output:\n" . print_r($result, true));
+            }
         
         } catch (CpeSdk\CpeException $e) {
             $reason  = $e->ref;
@@ -216,26 +220,31 @@ 
                 // Instantiate the Activity class that will process Tasks
 
                 if (!isset($this->cpeLogger) ||
-                    !$this->cpeLogger)
-                    print "EMPTY !!!\n";
+                    !$this->cpeLogger) {
+                                    print "EMPTY !!!\n";
+                }
 
                 $params = [
                     "domain"  => $this->domain,
                     "name"    => $activityToHandle->{"name"},
                     "version" => $activityToHandle->{"version"}
                 ];
-                if (isset($activityToHandle->{"defaultTaskStartToCloseTimeout"}))
-                    $params["defaultTaskStartToCloseTimeout"] =
+                if (isset($activityToHandle->{"defaultTaskStartToCloseTimeout"})) {
+                                    $params["defaultTaskStartToCloseTimeout"] =
                         $activityToHandle->{"defaultTaskStartToCloseTimeout"};
-                if (isset($activityToHandle->{"defaultTaskHeartbeatTimeout"}))
-                    $params["defaultTaskHeartbeatTimeout"] =
+                }
+                if (isset($activityToHandle->{"defaultTaskHeartbeatTimeout"})) {
+                                    $params["defaultTaskHeartbeatTimeout"] =
                         $activityToHandle->{"defaultTaskHeartbeatTimeout"};
-                if (isset($activityToHandle->{"defaultTaskScheduleToStartTimeout"}))
-                    $params["defaultTaskScheduleToStartTimeout"] =
+                }
+                if (isset($activityToHandle->{"defaultTaskScheduleToStartTimeout"})) {
+                                    $params["defaultTaskScheduleToStartTimeout"] =
                         $activityToHandle->{"defaultTaskScheduleToStartTimeout"};
-                if (isset($activityToHandle->{"defaultTaskScheduleToCloseTimeout"}))
-                    $params["defaultTaskScheduleToCloseTimeout"] =
+                }
+                if (isset($activityToHandle->{"defaultTaskScheduleToCloseTimeout"})) {
+                                    $params["defaultTaskScheduleToCloseTimeout"] =
                         $activityToHandle->{"defaultTaskScheduleToCloseTimeout"};
+                }
                 
                 $this->activityHandler = 
                     new $activityToHandle->{"class"}(
@@ -301,15 +310,18 @@ 
     global $activityVersion;
     
     // Handle input parameters
-    if (!($options = getopt("D:T:A:V:c:l:hd")))
-        usage($defaultConfigFile);
+    if (!($options = getopt("D:T:A:V:c:l:hd"))) {
+            usage($defaultConfigFile);
+    }
     
-    if (!count($options) || isset($options['h']))
-        usage($defaultConfigFile);
+    if (!count($options) || isset($options['h'])) {
+            usage($defaultConfigFile);
+    }
 
     // Debug
-    if (isset($options['d']))
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
 
     // Domain
     if (!isset($options['D']))
@@ -367,8 +379,7 @@ 
             print "\n[CONFIG ISSUE]\nConfiguration file '$defaultConfigFile' invalid or non-existant.\n\n[EASY FIX]\nGo to the directory mentioned in the error above and rename the template file 'cpeConfigTemplate.json' to 'cpeConfig.json'. Configure your Activities. As example you have Activities for CloudTranscode already setup in the template. You can declare your Activities and start executing tasks in an SWF workflow.\n";
             exit(1);
         }
-    }
-    catch (Exception $e) {
+    } catch (Exception $e) {
         print $e;
     }
             
@@ -388,8 +399,7 @@ 
 // Instantiate ActivityPoller
 try {
     $activityPoller = new ActivityPoller($config);
-} 
-catch (CpeSdk\CpeException $e) {
+} catch (CpeSdk\CpeException $e) {
     $cpeLogger->log_out("FATAL",
         basename(__FILE__), $e->getMessage());
     exit(1);
@@ -398,6 +408,7 @@ 
 $cpeLogger->log_out("INFO", basename(__FILE__), "Starting activity tasks polling");
 
 // Start polling loop
-while (42)
+while (42) {
     $activityPoller->poll_for_activities();
+}