SWFDecider._run() - Code Metrics - sportarchive/CloudProcessingEngine-Decider - Measure and Improve Code Quality continuously with Scrutinizer

SWFDecider._run() B
last analyzed 2016-11-10 17:43 UTC

↳ Parent: SWFDecider

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
cc	5
dl	0
loc	71
rs	8.1638
c	5
b	0
f	0

How to fix Long Method

from __future__ import (
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    absolute_import,
    division,
    print_function
)

import json
import logging
import time

import boto.swf.layer2 as swf
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
import boto.sqs.connection as sqs
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
import boto.sqs.queue as sqs_queue
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from .state_machine import StateMachine

_LOGGER = logging.getLogger(__name__)


class SWFDecider(swf.Decider):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    name = 'generic'
    version = '1.0'

    def __init__(self, domain, task_list, output_queue, plan=None):
        self.domain = domain
        self.task_list = task_list
        super(SWFDecider, self).__init__()

        self.statemachine = StateMachine(plan)
        self.sqs = sqs.SQSConnection()
        

        self.output_queue = sqs_queue.Queue(self.sqs, output_queue)

    def run(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        decision_task = self.poll()

        _LOGGER.info('Received decision task: %r', decision_task)
        if 'events' in decision_task:
            # Collect the entire history if there are enough events to become
            # paginated
            events = decision_task['events']
            while 'nextPageToken' in decision_task:
                decision_task = self.poll(

                    next_page_token=decision_task['nextPageToken']
                )
                if 'events' in decision_task:
                    events.extend(decision_task['events'])

            # Compute decision based on events
            decisions = self._run(events, decision_task['workflowExecution'])
            self.complete(decisions=decisions)


        _LOGGER.debug('Tic')
        return True

    def _run(self, events, workflowExecution):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        # Run the statemachine on the events
        results = self.statemachine.eval(events)

        # Now we can do 4 things:
        #  - Complete the workflow
        #  - Fail the workflow
        #  - Schedule more activities
        #  - Nothing
        decisions = swf.Layer1Decisions()

        if self.statemachine.is_succeeded:
            self.sqs.send_message(self.output_queue, json.dumps({
                'time': time.time(),
                'type': 'WORKFLOW_COMPLETED',
                'data': {
                    'workflow': workflowExecution
                }
            }))
            decisions.complete_workflow_execution(result=None)
            return decisions

        elif self.statemachine.is_failed:
            # FIXME: Improve error reporting

            self.sqs.send_message(self.output_queue, json.dumps({
                'time': time.time(),
                'type': 'WORKFLOW_FAILED',
                'data': {
                    'workflow': workflowExecution
                }
            }))
            decisions.fail_workflow_execution(reason='State machine aborted')
            return decisions

        # We are still going, start any ready activity
        for next_step in results:

            activity = next_step.activity
            # FIXME: We are assuming JSON activity input here

            activity_input = (
                json.dumps(next_step.activity_input)
                if next_step.activity_input is not None
                else None
            )

            self.sqs.send_message(self.output_queue, json.dumps({
                'time': time.time(),
                'type': 'ACTIVITY_SCHEDULED',
                'data': {
                    'workflow': workflowExecution,
                    'activity': {
                        'activityId': next_step.name,
                        'activityType': activity.name,
                        'activityVersion': activity.version
                    }
                }
            }))
            decisions.schedule_activity_task(
                activity_id=next_step.name,
                activity_type_name=activity.name,
                activity_type_version=activity.version,
                task_list=activity.task_list,
                control=None,  # FIXME: Do we want to pass context data?

                heartbeat_timeout=activity.heartbeat_timeout,
                schedule_to_close_timeout=activity.schedule_to_close_timeout,
                schedule_to_start_timeout=activity.schedule_to_start_timeout,
                start_to_close_timeout=activity.start_to_close_timeout,
                input=activity_input,
            )

        return decisions


1			from __future__ import (
			0 ignored issues – show Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			absolute_import,
3			division,
4			print_function
5			)
6
7			import json
8			import logging
9			import time
10
11			import boto.swf.layer2 as swf
			0 ignored issues – show Configuration introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report The import `boto.swf.layer2` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
12			import boto.sqs.connection as sqs
			0 ignored issues – show Configuration introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report The import `boto.sqs.connection` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
13			import boto.sqs.queue as sqs_queue
			0 ignored issues – show Configuration introduced 2015-12-30 21:27 UTC by Report Bug Copy Issue Report The import `boto.sqs.queue` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
14
15			from .state_machine import StateMachine
16
17			_LOGGER = logging.getLogger(__name__)
18
19
20			class SWFDecider(swf.Decider):
			0 ignored issues – show Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
21
22			name = 'generic'
23			version = '1.0'
24
25			def __init__(self, domain, task_list, output_queue, plan=None):
26			self.domain = domain
27			self.task_list = task_list
28			super(SWFDecider, self).__init__()
29
30			self.statemachine = StateMachine(plan)
31			self.sqs = sqs.SQSConnection()
32
			0 ignored issues – show Coding Style introduced 2016-02-05 02:14 UTC by Report Bug Copy Issue Report Trailing whitespace Loading history...
33			self.output_queue = sqs_queue.Queue(self.sqs, output_queue)
34
35			def run(self):
			0 ignored issues – show Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
36			decision_task = self.poll()
			0 ignored issues – show Bug introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report The Instance of `SWFDecider` does not seem to have a member named `poll`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
37			_LOGGER.info('Received decision task: %r', decision_task)
38			if 'events' in decision_task:
39			# Collect the entire history if there are enough events to become
40			# paginated
41			events = decision_task['events']
42			while 'nextPageToken' in decision_task:
43			decision_task = self.poll(
			0 ignored issues – show Bug introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report The Instance of `SWFDecider` does not seem to have a member named `poll`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
44			next_page_token=decision_task['nextPageToken']
45			)
46			if 'events' in decision_task:
47			events.extend(decision_task['events'])
48
49			# Compute decision based on events
50			decisions = self._run(events, decision_task['workflowExecution'])
51			self.complete(decisions=decisions)
			0 ignored issues – show Bug introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report The Instance of `SWFDecider` does not seem to have a member named `complete`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
52
53			_LOGGER.debug('Tic')
54			return True
55
56			def _run(self, events, workflowExecution):
			0 ignored issues – show Coding Style Naming introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report The name `workflowExecution` does not conform to the argument naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
57			# Run the statemachine on the events
58			results = self.statemachine.eval(events)
59
60			# Now we can do 4 things:
61			# - Complete the workflow
62			# - Fail the workflow
63			# - Schedule more activities
64			# - Nothing
65			decisions = swf.Layer1Decisions()
66
67			if self.statemachine.is_succeeded:
68			self.sqs.send_message(self.output_queue, json.dumps({
69			'time': time.time(),
70			'type': 'WORKFLOW_COMPLETED',
71			'data': {
72			'workflow': workflowExecution
73			}
74			}))
75			decisions.complete_workflow_execution(result=None)
76			return decisions
77
78			elif self.statemachine.is_failed:
79			# FIXME: Improve error reporting
			0 ignored issues – show Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
80			self.sqs.send_message(self.output_queue, json.dumps({
81			'time': time.time(),
82			'type': 'WORKFLOW_FAILED',
83			'data': {
84			'workflow': workflowExecution
85			}
86			}))
87			decisions.fail_workflow_execution(reason='State machine aborted')
88			return decisions
89
90			# We are still going, start any ready activity
91			for next_step in results:
92
93			activity = next_step.activity
94			# FIXME: We are assuming JSON activity input here
			0 ignored issues – show Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
95			activity_input = (
96			json.dumps(next_step.activity_input)
97			if next_step.activity_input is not None
98			else None
99			)
100
101			self.sqs.send_message(self.output_queue, json.dumps({
102			'time': time.time(),
103			'type': 'ACTIVITY_SCHEDULED',
104			'data': {
105			'workflow': workflowExecution,
106			'activity': {
107			'activityId': next_step.name,
108			'activityType': activity.name,
109			'activityVersion': activity.version
110			}
111			}
112			}))
113			decisions.schedule_activity_task(
114			activity_id=next_step.name,
115			activity_type_name=activity.name,
116			activity_type_version=activity.version,
117			task_list=activity.task_list,
118			control=None, # FIXME: Do we want to pass context data?
			0 ignored issues – show Coding Style introduced 2015-12-30 07:05 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
119			heartbeat_timeout=activity.heartbeat_timeout,
120			schedule_to_close_timeout=activity.schedule_to_close_timeout,
121			schedule_to_start_timeout=activity.schedule_to_start_timeout,
122			start_to_close_timeout=activity.start_to_close_timeout,
123			input=activity_input,
124			)
125
126			return decisions
127

SWFDecider._run() B
last analyzed 2016-11-10 17:43 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

sportarchive / CloudProcessingEngine-Decider

SWFDecider._run() B last analyzed 2016-11-10 17:43 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

SWFDecider._run() B
last analyzed 2016-11-10 17:43 UTC

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files