StateMachineTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	59
Duplicated Lines	44.07 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	test_workflow_start()	13	13	2
A	test_workflow_first_completed()	13	13	2
A	setUp()	0	11	3
A	test_workflow_invalid_input_abort()	0	6	1
A	test_workflow_unknown_abort()	0	6	1

"""Unit tests for pydecider.state_machine
"""

import os
import sys
import unittest

sys.path.append(
    os.path.realpath(
        os.path.join(
            os.path.dirname(__file__),
            '..'
        )
    )
)

import copy
import mock

The import mock seems to be unused.

import yaml

The import yaml could not be resolved.

import pydecider
import pydecider.plan
import pydecider.state_machine


class StateMachineTest(unittest.TestCase):

This class should have a docstring.

    MY_DIR = os.path.realpath(os.path.dirname(__file__))

    def setUp(self):
        # Load reference plan
        with open(os.path.join(self.MY_DIR, 'plan_hello.yml')) as f:

The name f does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

            plan_data = yaml.load(f)
        self.plan = pydecider.plan.Plan.from_data(plan_data)
        # Load reference events
        with open(os.path.join(self.MY_DIR, 'plan_hello_events.yml')) as f:

The name f does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

            events_data = yaml.load(f)
        self.events = events_data['events']
        # Create a state machine
        self.statemachine = pydecider.state_machine.StateMachine(self.plan)

    def test_workflow_start(self):

This method should have a docstring.

This code seems to be duplicated in your project.

        results = self.statemachine.eval(self.events[:3])
        self.assertTrue(self.statemachine.state.is_in_state('running'))
        self.assertEquals(
            [
                (result.name, result.activity, result.activity_input)
                 for result in results
            ],
            [
                (
                    'saying_hi',
                    self.plan.activities['HelloWorld'],
                    {'who': 'world'}
                )
            ]
        )

    def test_workflow_unknown_abort(self):

This method should have a docstring.

        myevents = copy.deepcopy(self.events[:3])
        myevents[-1]['eventType'] = 'Foo'
        results = self.statemachine.eval(myevents[:3])
        self.assertTrue(self.statemachine.state.is_in_state('failed'))
        self.assertEquals([], results)

    def test_workflow_invalid_input_abort(self):

The name test_workflow_invalid_input_abort does not conform to the method naming conventions ([a-z_][a-z0-9_]{2,30}$).

This method should have a docstring.

        myevents = copy.deepcopy(self.events[:3])
        myevents[0]['eventType'] = 'Foo'
        results = self.statemachine.eval(myevents[:3])
        self.assertTrue(self.statemachine.state.is_in_state('failed'))
        self.assertEquals([], results)

    def test_workflow_first_completed(self):

This method should have a docstring.

This code seems to be duplicated in your project.

        results = self.statemachine.eval(self.events[:13])
        self.assertTrue(self.statemachine.state.is_in_state('running'))
        self.assertEquals(
            [
                (result.name, result.activity, result.activity_input)
                 for result in results
            ],
            [
                (
                    'saying_hi_again',
                    self.plan.activities['HelloWorld'],
                    {'who': 'world'}
                )
            ]
        )


if __name__ == '__main__':
    import logging
    logging.basicConfig(level=logging.DEBUG)
    unittest.main()