action_plugin_acl::handleAjaxCallAcl() - Code Metrics - Inspection of "Merge branch 'master' into psr2" - splitbrain/dokuwiki - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — psr2 ( fdf613...a390de )

by Andreas

created 2018-05-11 16:53 UTC

action_plugin_acl::handleAjaxCallAcl() B

↳ Parent: action_plugin_acl

Complexity

Conditions	8
Paths	9

Size

Total Lines	53
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	35
nc	9
nop	2
dl	0
loc	53
rs	7.1199
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * AJAX call handler for ACL plugin
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Andreas Gohr <[email protected]>
 */

/**
 * Register handler
 */
class action_plugin_acl extends DokuWiki_Action_Plugin
{

    /**
     * Registers a callback function for a given event
     *
     * @param Doku_Event_Handler $controller DokuWiki's event controller object
     * @return void
     */
    public function register(Doku_Event_Handler $controller)
    {

        $controller->register_hook('AJAX_CALL_UNKNOWN', 'BEFORE', $this, 'handleAjaxCallAcl');
    }

    /**
     * AJAX call handler for ACL plugin
     *
     * @param Doku_Event $event  event object by reference
     * @param mixed $param  empty
     * @return void
     */

    public function handleAjaxCallAcl(Doku_Event $event, $param)

    {
        if ($event->data !== 'plugin_acl') {
            return;
        }
        $event->stopPropagation();
        $event->preventDefault();

        global $ID;
        global $INPUT;

        if (!auth_isadmin()) {
            echo 'for admins only';
            return;
        }
        if (!checkSecurityToken()) {
            echo 'CRSF Attack';
            return;
        }

        $ID = getID();

        /** @var $acl admin_plugin_acl */
        $acl = plugin_load('admin', 'acl');
        $acl->handle();

        $ajax = $INPUT->str('ajax');
        header('Content-Type: text/html; charset=utf-8');

        if ($ajax == 'info') {
            $acl->printInfo();
        } elseif ($ajax == 'tree') {
            $ns = $INPUT->str('ns');
            if ($ns == '*') {
                $ns = '';
            }
            $ns = cleanID($ns);
            $lvl = count(explode(':', $ns));
            $ns = utf8_encodeFN(str_replace(':', '/', $ns));

            $data = $acl->makeTree($ns, $ns);

            foreach (array_keys($data) as $item) {
                $data[$item]['level'] = $lvl + 1;
            }
            echo html_buildlist(
                $data,
                'acl',
                array($acl, 'makeTreeItem'),
                array($acl, 'makeListItem')
            );
        }
    }
}


1			<?php
2			/**
3			* AJAX call handler for ACL plugin
4			*
5			* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6			* @author Andreas Gohr <[email protected]>
7			*/
8
9			/**
10			* Register handler
11			*/
12			class action_plugin_acl extends DokuWiki_Action_Plugin
13			{
14
15			/**
16			* Registers a callback function for a given event
17			*
18			* @param Doku_Event_Handler $controller DokuWiki's event controller object
19			* @return void
20			*/
21			public function register(Doku_Event_Handler $controller)
22			{
23
24			$controller->register_hook('AJAX_CALL_UNKNOWN', 'BEFORE', $this, 'handleAjaxCallAcl');
25			}
26
27			/**
28			* AJAX call handler for ACL plugin
29			*
30			* @param Doku_Event $event event object by reference
31			* @param mixed $param empty
32			* @return void
33			*/
34
35			public function handleAjaxCallAcl(Doku_Event $event, $param)
			0 ignored issues – show Unused Code introduced 2018-05-11 16:52 UTC by Report Bug Copy Issue Report The parameter `$param` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
36			{
37			if ($event->data !== 'plugin_acl') {
38			return;
39			}
40			$event->stopPropagation();
41			$event->preventDefault();
42
43			global $ID;
44			global $INPUT;
45
46			if (!auth_isadmin()) {
47			echo 'for admins only';
48			return;
49			}
50			if (!checkSecurityToken()) {
51			echo 'CRSF Attack';
52			return;
53			}
54
55			$ID = getID();
56
57			/** @var $acl admin_plugin_acl */
58			$acl = plugin_load('admin', 'acl');
59			$acl->handle();
60
61			$ajax = $INPUT->str('ajax');
62			header('Content-Type: text/html; charset=utf-8');
63
64			if ($ajax == 'info') {
65			$acl->printInfo();
66			} elseif ($ajax == 'tree') {
67			$ns = $INPUT->str('ns');
68			if ($ns == '*') {
69			$ns = '';
70			}
71			$ns = cleanID($ns);
72			$lvl = count(explode(':', $ns));
73			$ns = utf8_encodeFN(str_replace(':', '/', $ns));
74
75			$data = $acl->makeTree($ns, $ns);
76
77			foreach (array_keys($data) as $item) {
78			$data[$item]['level'] = $lvl + 1;
79			}
80			echo html_buildlist(
81			$data,
82			'acl',
83			array($acl, 'makeTreeItem'),
84			array($acl, 'makeListItem')
85			);
86			}
87			}
88			}
89

splitbrain / dokuwiki

Push — psr2 ( fdf613...a390de )

action_plugin_acl::handleAjaxCallAcl() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like