It seems like $options->getOpt('skip') can also be of type string. However, the property $skip is declared as type boolean. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
It seems like $options->getOpt('sort') can also be of type boolean. However, the property $sort is declared as type string. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
70
71
$this->info("searching $startdir");
72
73
foreach($this->get_pages($startdir) as $page) {
74
$this->internal_links($page);
75
}
76
ksort($this->result);
77
foreach($this->result as $main => $subs) {
78
if($this->skip) {
79
print "$main\n";
80
} else {
81
$subs = array_unique($subs);
82
sort($subs);
83
foreach($subs as $sub) {
84
printf("%-40s %s\n", $main, $sub);
85
}
86
}
87
}
88
}
89
90
/**
91
* Determine directions of the search loop
92
*
93
* @param string $entry
94
* @param string $basepath
95
* @return int
96
*/
97
protected function dir_filter($entry, $basepath) {
98
if($entry == '.' || $entry == '..') {
99
return WantedPagesCLI::DIR_CONTINUE;
100
}
101
if(is_dir($basepath . '/' . $entry)) {
102
if(strpos($entry, '_') === 0) {
103
return WantedPagesCLI::DIR_CONTINUE;
104
}
105
return WantedPagesCLI::DIR_NS;
106
}
107
if(preg_match('/\.txt$/', $entry)) {
108
return WantedPagesCLI::DIR_PAGE;
109
}
110
return WantedPagesCLI::DIR_CONTINUE;
111
}
112
113
/**
114
* Collects recursively the pages in a namespace
115
*
116
* @param string $dir
117
* @return array
118
* @throws DokuCLI_Exception
119
*/
120
protected function get_pages($dir) {
121
static $trunclen = null;
122
if(!$trunclen) {
123
global $conf;
124
$trunclen = strlen($conf['datadir'] . ':');
125
}
126
127
if(!is_dir($dir)) {
128
throw new DokuCLI_Exception("Unable to read directory $dir");
splitbrain /
dokuwiki
Andreas Gohr
Loading history...
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.