inc/media.php ➔ media_file_diff()

Complexity

Conditions	21
Paths	1596

Size

Total Lines	113
Code Lines	80

Duplication

Lines	0
Ratio	0 %

<?php
function media_file_diff($image, $l_rev, $r_rev, $ns, $auth, $fromajax){

The parameter $ns is not used and could be removed.

    global $lang;
    global $INPUT;

    $l_meta = new JpegMeta(mediaFN($image, $l_rev));
    $r_meta = new JpegMeta(mediaFN($image, $r_rev));

    $is_img = preg_match('/\.(jpe?g|gif|png)$/', $image);
    if ($is_img) {
        $l_size = media_image_preview_size($image, $l_rev, $l_meta);
        $r_size = media_image_preview_size($image, $r_rev, $r_meta);
        $is_img = ($l_size && $r_size && ($l_size[0] >= 30 || $r_size[0] >= 30));

        $difftype = $INPUT->str('difftype');

        if (!$fromajax) {
            $form = new Doku_Form(array(
                'action' => media_managerURL(array(), '&'),
                'method' => 'get',
                'id' => 'mediamanager__form_diffview',
                'class' => 'diffView'
            ));
            $form->addHidden('sectok', null);
            $form->addElement('<input type="hidden" name="rev2[]" value="'.$l_rev.'" ></input>');
            $form->addElement('<input type="hidden" name="rev2[]" value="'.$r_rev.'" ></input>');
            $form->addHidden('mediado', 'diff');
            $form->printForm();

            echo NL.'<div id="mediamanager__diff" >'.NL;
        }

        if ($difftype == 'opacity' || $difftype == 'portions') {
            media_image_diff($image, $l_rev, $r_rev, $l_size, $r_size, $difftype);

It seems like $l_size defined by media_image_preview_size($image, $l_rev, $l_meta) on line 1258 can also be of type false; however, media_image_diff() does only seem to accept array, did you maybe forget to handle an error condition?

It seems like $r_size defined by media_image_preview_size($image, $r_rev, $r_meta) on line 1259 can also be of type false; however, media_image_diff() does only seem to accept array, did you maybe forget to handle an error condition?

            if (!$fromajax) echo '</div>';
            return;
        }
    }

    list($l_head, $r_head) = html_diff_head($l_rev, $r_rev, $image, true);

    ?>
    <div class="table">
    <table>
      <tr>
        <th><?php echo $l_head; ?></th>
        <th><?php echo $r_head; ?></th>
      </tr>
    <?php

    echo '<tr class="image">';
    echo '<td>';
    media_preview($image, $auth, $l_rev, $l_meta);
    echo '</td>';

    echo '<td>';
    media_preview($image, $auth, $r_rev, $r_meta);
    echo '</td>';
    echo '</tr>'.NL;

    echo '<tr class="actions">';
    echo '<td>';
    media_preview_buttons($image, $auth, $l_rev);
    echo '</td>';

    echo '<td>';
    media_preview_buttons($image, $auth, $r_rev);
    echo '</td>';
    echo '</tr>'.NL;

    $l_tags = media_file_tags($l_meta);
    $r_tags = media_file_tags($r_meta);
    // FIXME r_tags-only stuff
    foreach ($l_tags as $key => $l_tag) {
        if ($l_tag['value'] != $r_tags[$key]['value']) {
            $r_tags[$key]['highlighted'] = true;
            $l_tags[$key]['highlighted'] = true;
        } else if (!$l_tag['value'] || !$r_tags[$key]['value']) {
            unset($r_tags[$key]);
            unset($l_tags[$key]);
        }
    }

    echo '<tr>';
    foreach(array($l_tags,$r_tags) as $tags){
        echo '<td>'.NL;

        echo '<dl class="img_tags">';
        foreach($tags as $tag){
            $value = cleanText($tag['value']);
            if (!$value) $value = '-';
            echo '<dt>'.$lang[$tag['tag'][1]].'</dt>';
            echo '<dd>';
            if ($tag['highlighted']) {
                echo '<strong>';
            }
            if ($tag['tag'][2] == 'date') echo dformat($value);
            else echo hsc($value);
            if ($tag['highlighted']) {
                echo '</strong>';
            }
            echo '</dd>';
        }
        echo '</dl>'.NL;

        echo '</td>';
    }
    echo '</tr>'.NL;

    echo '</table>'.NL;
    echo '</div>'.NL;

    if ($is_img && !$fromajax) echo '</div>';
}